From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 5/6] arm64: Use __pa_symbol for _end
Date: Wed, 2 Nov 2016 22:52:42 +0000 [thread overview]
Message-ID: <20161102225241.GA19591@remoulade> (raw)
In-Reply-To: <20161102210054.16621-6-labbott@redhat.com>
On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote:
>
> __pa_symbol is technically the marco that should be used for kernel
> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL.
Nit: s/marco/macro/
I see there are some other uses of __pa() that look like they could/should be
__pa_symbol(), e.g. in mark_rodata_ro().
I guess strictly speaking those need to be updated to? Or is there a reason
that we should not?
Thanks,
Mark.
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> arch/arm64/mm/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 212c4d1..3236eb0 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void)
> * linear mapping. Take care not to clip the kernel which may be
> * high in memory.
> */
> - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)),
> - ULLONG_MAX);
> + memblock_remove(max_t(u64, memstart_addr + linear_region_size,
> + __pa_symbol(_end)), ULLONG_MAX);
> if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) {
> /* ensure that memstart_addr remains sufficiently aligned */
> memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size,
> --
> 2.10.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 5/6] arm64: Use __pa_symbol for _end
Date: Wed, 2 Nov 2016 22:52:42 +0000 [thread overview]
Message-ID: <20161102225241.GA19591@remoulade> (raw)
In-Reply-To: <20161102210054.16621-6-labbott@redhat.com>
On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote:
>
> __pa_symbol is technically the marco that should be used for kernel
> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL.
Nit: s/marco/macro/
I see there are some other uses of __pa() that look like they could/should be
__pa_symbol(), e.g. in mark_rodata_ro().
I guess strictly speaking those need to be updated to? Or is there a reason
that we should not?
Thanks,
Mark.
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> arch/arm64/mm/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 212c4d1..3236eb0 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void)
> * linear mapping. Take care not to clip the kernel which may be
> * high in memory.
> */
> - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)),
> - ULLONG_MAX);
> + memblock_remove(max_t(u64, memstart_addr + linear_region_size,
> + __pa_symbol(_end)), ULLONG_MAX);
> if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) {
> /* ensure that memstart_addr remains sufficiently aligned */
> memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size,
> --
> 2.10.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 5/6] arm64: Use __pa_symbol for _end
Date: Wed, 2 Nov 2016 22:52:42 +0000 [thread overview]
Message-ID: <20161102225241.GA19591@remoulade> (raw)
In-Reply-To: <20161102210054.16621-6-labbott@redhat.com>
On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote:
>
> __pa_symbol is technically the marco that should be used for kernel
> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL.
Nit: s/marco/macro/
I see there are some other uses of __pa() that look like they could/should be
__pa_symbol(), e.g. in mark_rodata_ro().
I guess strictly speaking those need to be updated to? Or is there a reason
that we should not?
Thanks,
Mark.
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> arch/arm64/mm/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 212c4d1..3236eb0 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void)
> * linear mapping. Take care not to clip the kernel which may be
> * high in memory.
> */
> - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)),
> - ULLONG_MAX);
> + memblock_remove(max_t(u64, memstart_addr + linear_region_size,
> + __pa_symbol(_end)), ULLONG_MAX);
> if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) {
> /* ensure that memstart_addr remains sufficiently aligned */
> memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size,
> --
> 2.10.1
>
next prev parent reply other threads:[~2016-11-02 22:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 21:00 [PATCHv2 0/6] CONFIG_DEBUG_VIRTUAL for arm64 Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` [PATCHv2 1/6] lib/Kconfig.debug: Add ARCH_HAS_DEBUG_VIRTUAL Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` [PATCHv2 2/6] mm/cma: Cleanup highmem check Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` [PATCHv2 3/6] arm64: Move some macros under #ifndef __ASSEMBLY__ Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` [PATCHv2 4/6] arm64: Add cast for virt_to_pfn Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` [PATCHv2 5/6] arm64: Use __pa_symbol for _end Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 22:52 ` Mark Rutland [this message]
2016-11-02 22:52 ` Mark Rutland
2016-11-02 22:52 ` Mark Rutland
2016-11-02 23:56 ` Laura Abbott
2016-11-02 23:56 ` Laura Abbott
2016-11-02 23:56 ` Laura Abbott
2016-11-03 15:51 ` Mark Rutland
2016-11-03 15:51 ` Mark Rutland
2016-11-03 15:51 ` Mark Rutland
2016-11-14 18:19 ` Catalin Marinas
2016-11-14 18:19 ` Catalin Marinas
2016-11-14 18:19 ` Catalin Marinas
2016-11-14 18:41 ` Laura Abbott
2016-11-14 18:41 ` Laura Abbott
2016-11-14 18:41 ` Laura Abbott
2016-11-15 18:35 ` Catalin Marinas
2016-11-15 18:35 ` Catalin Marinas
2016-11-15 18:35 ` Catalin Marinas
2016-11-16 0:09 ` Laura Abbott
2016-11-16 0:09 ` Laura Abbott
2016-11-16 0:09 ` Laura Abbott
2016-11-16 17:32 ` Catalin Marinas
2016-11-16 17:32 ` Catalin Marinas
2016-11-16 17:32 ` Catalin Marinas
2016-11-18 10:23 ` Ard Biesheuvel
2016-11-18 10:23 ` Ard Biesheuvel
2016-11-18 10:23 ` Ard Biesheuvel
2016-11-02 21:00 ` [PATCHv2 6/6] arm64: Add support for CONFIG_DEBUG_VIRTUAL Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 21:00 ` Laura Abbott
2016-11-02 23:06 ` Mark Rutland
2016-11-02 23:06 ` Mark Rutland
2016-11-02 23:06 ` Mark Rutland
2016-11-03 0:05 ` Laura Abbott
2016-11-03 0:05 ` Laura Abbott
2016-11-03 0:05 ` Laura Abbott
2016-11-03 15:57 ` Mark Rutland
2016-11-03 15:57 ` Mark Rutland
2016-11-03 15:57 ` Mark Rutland
2016-11-02 23:07 ` [PATCHv2 0/6] CONFIG_DEBUG_VIRTUAL for arm64 Mark Rutland
2016-11-02 23:07 ` Mark Rutland
2016-11-02 23:07 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102225241.GA19591@remoulade \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.