From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Steffen Maier <maier@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Johannes Thumshirn <jth@kernel.org>,
James Smart <james.smart@avagotech.com>,
Dic
Subject: Re: [PATCH v3 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done
Date: Thu, 3 Nov 2016 08:17:33 -0700 [thread overview]
Message-ID: <20161103151733.GC7404@infradead.org> (raw)
In-Reply-To: <2b02bb8460fa27db4fe971a2161e0cb7c2fca4df.1476369687.git.jthumshirn@suse.de>
On Thu, Oct 13, 2016 at 05:00:20PM +0200, Johannes Thumshirn wrote:
> Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
> diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
> on.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
Looks fine, although I would have merged it into the previous patch:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Steffen Maier <maier@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Johannes Thumshirn <jth@kernel.org>,
James Smart <james.smart@avagotech.com>,
Dick Kennedy <dick.kennedy@avagotech.com>,
"supporter:QLOGIC QLA2XXX FC-SCSI DRIVER"
<qla2xxx-upstream@qlogic.com>,
"open list:S390 ZFCP DRIVER" <linux-s390@vger.kernel.org>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>,
"open list:FCOE SUBSYSTEM (libfc, libfcoe,
fcoe)" <fcoe-devel@open-fcoe.org>
Subject: Re: [PATCH v3 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done
Date: Thu, 3 Nov 2016 08:17:33 -0700 [thread overview]
Message-ID: <20161103151733.GC7404@infradead.org> (raw)
In-Reply-To: <2b02bb8460fa27db4fe971a2161e0cb7c2fca4df.1476369687.git.jthumshirn@suse.de>
On Thu, Oct 13, 2016 at 05:00:20PM +0200, Johannes Thumshirn wrote:
> Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
> diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
> on.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
Looks fine, although I would have merged it into the previous patch:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-11-03 15:17 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 15:00 [PATCH v3 00/16] Convert FibreChannel bsg code to use bsg-lib Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 01/16] scsi: Get rid of struct fc_bsg_buffer Johannes Thumshirn
2016-11-03 15:15 ` Christoph Hellwig
[not found] ` <cover.1476369687.git.jthumshirn-l3A5Bk7waGM@public.gmane.org>
2016-10-13 15:00 ` [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-10-13 15:55 ` Steffen Maier
2016-10-13 15:55 ` Steffen Maier
2016-10-13 15:55 ` Steffen Maier
[not found] ` <ebc46cfa-0bee-aa71-ba0b-d7c86628df0c-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-13 16:12 ` Johannes Thumshirn
2016-10-13 16:12 ` Johannes Thumshirn
2016-10-14 7:38 ` Johannes Thumshirn
2016-10-14 7:38 ` Johannes Thumshirn
2016-10-25 7:43 ` Johannes Thumshirn
2016-10-25 7:43 ` Johannes Thumshirn
2016-11-15 11:56 ` Johannes Thumshirn
2016-11-15 11:56 ` Johannes Thumshirn
2016-11-15 14:31 ` Steffen Maier
2016-11-15 14:31 ` Steffen Maier
2016-11-15 14:31 ` Steffen Maier
2016-11-15 14:48 ` Johannes Thumshirn
2016-11-15 14:48 ` Johannes Thumshirn
2016-11-15 15:39 ` Johannes Thumshirn
2016-11-15 15:39 ` Johannes Thumshirn
2016-11-16 11:35 ` Johannes Thumshirn
2016-11-16 11:35 ` Johannes Thumshirn
2016-11-03 15:17 ` Christoph Hellwig
2016-11-03 15:17 ` Christoph Hellwig
2016-11-03 17:42 ` Johannes Thumshirn
2016-11-03 17:42 ` Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-11-03 15:17 ` Christoph Hellwig
2016-11-03 15:17 ` Christoph Hellwig
2016-11-03 22:04 ` Tyrel Datwyler
2016-11-03 22:04 ` Tyrel Datwyler
2016-11-03 22:04 ` Tyrel Datwyler
2016-10-13 15:00 ` [PATCH v3 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-11-03 15:17 ` Christoph Hellwig [this message]
2016-11-03 15:17 ` Christoph Hellwig
2016-11-03 22:06 ` Tyrel Datwyler
2016-11-03 22:06 ` Tyrel Datwyler
2016-10-13 15:00 ` [PATCH v3 05/16] scsi: fc: provide fc_bsg_to_shost() helper Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-11-03 22:07 ` Tyrel Datwyler
2016-11-03 22:07 ` Tyrel Datwyler
2016-10-13 15:00 ` [PATCH v3 06/16] scsi: fc: provide fc_bsg_to_rport() helper Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-11-03 22:08 ` Tyrel Datwyler
2016-11-03 22:08 ` Tyrel Datwyler
2016-11-03 22:08 ` Tyrel Datwyler
2016-10-13 15:00 ` [PATCH v3 07/16] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 10/16] scsi: change FC drivers to use 'struct bsg_job' Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-11-03 22:10 ` Tyrel Datwyler
2016-11-03 22:10 ` Tyrel Datwyler
2016-11-03 22:10 ` Tyrel Datwyler
2016-10-13 15:00 ` [PATCH v3 13/16] scsi: fc: use bsg_job_done Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-11-03 22:10 ` Tyrel Datwyler
2016-11-03 22:10 ` Tyrel Datwyler
2016-10-13 15:00 ` [PATCH v3 08/16] scsi: fc: implement kref backed reference counting Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 09/16] block: add reference counting for struct bsg_job Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 11/16] scsi: fc: Use bsg_destroy_job Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 12/16] scsi: fc: use bsg_softirq_done Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 14/16] block: add bsg_job_put() and bsg_job_get() Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 15/16] scsi: fc: move FC transport's bsg code to bsg-lib Johannes Thumshirn
2016-10-13 15:00 ` [PATCH v3 16/16] block: unexport bsg_softirq_done() again Johannes Thumshirn
2016-10-13 15:00 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103151733.GC7404@infradead.org \
--to=hch@infradead.org \
--cc=anil.gurumurthy@qlogic.com \
--cc=benh@kernel.crashing.org \
--cc=hare@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=james.smart@avagotech.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jth@kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=sudarsana.kalluru@qlogic.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.