From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 9/9] clocksource: import ARC timer driver
Date: Thu, 3 Nov 2016 19:11:12 +0100 [thread overview]
Message-ID: <20161103181112.GK1859@mai> (raw)
In-Reply-To: <f73c498d-d2f4-2fc8-49ec-9fbf5c5c96b7@synopsys.com>
On Thu, Nov 03, 2016@10:57:48AM -0700, Vineet Gupta wrote:
> Hi Daniel,
>
> On 11/03/2016 09:50 AM, Daniel Lezcano wrote:
> > On Thu, Nov 03, 2016@09:40:23AM -0700, Vineet Gupta wrote:
> >> On 11/01/2016 06:03 PM, Vineet Gupta wrote:
> >>>>> Because of the git mv you, diff didn't include bulk of driver code which would
> >>>>>>> make for bulk of review anyways. So perhaps in v2 I don't do the git mv. OK ?
> >>>>>
> >>>>> That means I will review and comment existing code. It is not a problem for me
> >>>>> if you agree to do the changes.
> >>> Sure, the whole point is to make things better as an outcome of review. I have no
> >>> issues changing code provided we don't add major performance regressions.
> >>
> >> So just wondering if I could have some comments on the initial import of driver
> >> before I send out a v2.
> >
> > Yeah, ok. Let me comment the other patches of the series and then you can send a V2.
>
> Thx for taking a quick look - this is a good start. How about the actual driver
> itself, do you want to take a quick look there as well before v2 ?
At the first glance, with your changes it is acceptable to be moved. Perhaps,
you can have a look to remove the BIG_ENDIAN stuff in the clock read function.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
Noam Camus <noamca@mellanox.com>,
Alexey.Brodkin@synopsys.com
Subject: Re: [PATCH 9/9] clocksource: import ARC timer driver
Date: Thu, 3 Nov 2016 19:11:12 +0100 [thread overview]
Message-ID: <20161103181112.GK1859@mai> (raw)
In-Reply-To: <f73c498d-d2f4-2fc8-49ec-9fbf5c5c96b7@synopsys.com>
On Thu, Nov 03, 2016 at 10:57:48AM -0700, Vineet Gupta wrote:
> Hi Daniel,
>
> On 11/03/2016 09:50 AM, Daniel Lezcano wrote:
> > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote:
> >> On 11/01/2016 06:03 PM, Vineet Gupta wrote:
> >>>>> Because of the git mv you, diff didn't include bulk of driver code which would
> >>>>>>> make for bulk of review anyways. So perhaps in v2 I don't do the git mv. OK ?
> >>>>>
> >>>>> That means I will review and comment existing code. It is not a problem for me
> >>>>> if you agree to do the changes.
> >>> Sure, the whole point is to make things better as an outcome of review. I have no
> >>> issues changing code provided we don't add major performance regressions.
> >>
> >> So just wondering if I could have some comments on the initial import of driver
> >> before I send out a v2.
> >
> > Yeah, ok. Let me comment the other patches of the series and then you can send a V2.
>
> Thx for taking a quick look - this is a good start. How about the actual driver
> itself, do you want to take a quick look there as well before v2 ?
At the first glance, with your changes it is acceptable to be moved. Perhaps,
you can have a look to remove the BIG_ENDIAN stuff in the clock read function.
next prev parent reply other threads:[~2016-11-03 18:11 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 12:12 [PATCH v2 0/3] Add clockevet for timer-nps driver to NPS400 SoC Noam Camus
2016-10-23 12:12 ` Noam Camus
2016-10-23 12:12 ` [PATCH v2 1/3] soc: Support for NPS HW scheduling Noam Camus
2016-10-23 12:12 ` Noam Camus
[not found] ` <1477224748-25223-2-git-send-email-noamca-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-31 10:26 ` Daniel Lezcano
2016-10-31 10:26 ` Daniel Lezcano
2016-10-31 12:26 ` Noam Camus
[not found] ` <1477224748-25223-1-git-send-email-noamca-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-23 12:12 ` [PATCH v2 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer Noam Camus
2016-10-23 12:12 ` Noam Camus
[not found] ` <1477224748-25223-3-git-send-email-noamca-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-31 10:28 ` Daniel Lezcano
2016-10-31 10:28 ` Daniel Lezcano
2016-10-31 15:19 ` Noam Camus
2016-10-23 12:12 ` [PATCH v2 3/3] clocksource: Add clockevent support to NPS400 driver Noam Camus
2016-10-23 12:12 ` Noam Camus
2016-10-30 20:41 ` Rob Herring
2016-10-31 10:52 ` Daniel Lezcano
2016-10-31 17:03 ` Noam Camus
2016-10-31 17:51 ` Vineet Gupta
2016-10-31 22:48 ` [PATCH 0/9] Move ARC timer code into drivers/clocksource/ Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-10-31 22:48 ` [PATCH 1/9] ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-03 17:00 ` Daniel Lezcano
2016-11-03 17:00 ` Daniel Lezcano
2016-11-03 17:41 ` Vineet Gupta
2016-11-03 17:41 ` Vineet Gupta
2016-10-31 22:48 ` [PATCH 2/9] ARC: timer: rtc: implement read loop in "C" vs. inline asm Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-03 17:02 ` Daniel Lezcano
2016-11-03 17:02 ` Daniel Lezcano
2016-11-03 17:45 ` Vineet Gupta
2016-11-03 17:45 ` Vineet Gupta
2016-10-31 22:48 ` [PATCH 3/9] ARC: timer: gfrc: boot print alongside other timers Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-03 17:09 ` Daniel Lezcano
2016-11-03 17:09 ` Daniel Lezcano
2016-11-03 17:47 ` Vineet Gupta
2016-11-03 17:47 ` Vineet Gupta
2016-11-03 17:51 ` Daniel Lezcano
2016-11-03 17:51 ` Daniel Lezcano
2016-10-31 22:48 ` [PATCH 4/9] ARC: time: move time_init() out of the driver Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-03 17:15 ` Daniel Lezcano
2016-11-03 17:15 ` Daniel Lezcano
2016-10-31 22:48 ` [PATCH 5/9] ARC: breakout aux handling into a seperate header Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-01 7:49 ` Noam Camus
2016-11-01 7:49 ` Noam Camus
2016-10-31 22:48 ` [PATCH 6/9] ARC: move mcip.h into include/soc and adjust the includes Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-03 17:20 ` Daniel Lezcano
2016-11-03 17:20 ` Daniel Lezcano
2016-10-31 22:48 ` [PATCH 7/9] ARC: breakout timer stuff into a seperate header Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-03 17:25 ` Daniel Lezcano
2016-11-03 17:25 ` Daniel Lezcano
2016-10-31 22:48 ` [PATCH 8/9] ARC: timer: rename config options Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-10-31 22:48 ` [PATCH 9/9] clocksource: import ARC timer driver Vineet Gupta
2016-10-31 22:48 ` Vineet Gupta
2016-11-01 0:01 ` kbuild test robot
2016-11-01 0:01 ` kbuild test robot
2016-11-01 0:45 ` Vineet Gupta
2016-11-01 0:45 ` Vineet Gupta
2016-11-01 20:42 ` Daniel Lezcano
2016-11-01 20:42 ` Daniel Lezcano
2016-11-01 20:57 ` Vineet Gupta
2016-11-01 20:57 ` Vineet Gupta
2016-11-02 0:19 ` Daniel Lezcano
2016-11-02 0:19 ` Daniel Lezcano
2016-11-02 1:03 ` Vineet Gupta
2016-11-02 1:03 ` Vineet Gupta
2016-11-03 16:40 ` Vineet Gupta
2016-11-03 16:40 ` Vineet Gupta
2016-11-03 16:50 ` Daniel Lezcano
2016-11-03 16:50 ` Daniel Lezcano
2016-11-03 17:57 ` Vineet Gupta
2016-11-03 17:57 ` Vineet Gupta
2016-11-03 18:11 ` Daniel Lezcano [this message]
2016-11-03 18:11 ` Daniel Lezcano
2016-11-03 18:43 ` Vineet Gupta
2016-11-03 18:43 ` Vineet Gupta
2016-11-03 17:33 ` Daniel Lezcano
2016-11-03 17:33 ` Daniel Lezcano
2016-11-03 18:14 ` Daniel Lezcano
2016-11-03 18:14 ` Daniel Lezcano
2016-11-03 18:47 ` Vineet Gupta
2016-11-03 18:47 ` Vineet Gupta
2016-11-03 17:28 ` [PATCH 0/9] Move ARC timer code into drivers/clocksource/ Daniel Lezcano
2016-11-03 17:28 ` Daniel Lezcano
[not found] ` <DB6PR0501MB2518720A0F95ACBBBCB1CB27AAAE0-wTfl6qNNZ1PL+HUNrKNnF8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-01 20:01 ` [PATCH v2 3/3] clocksource: Add clockevent support to NPS400 driver Daniel Lezcano
2016-11-01 20:01 ` Daniel Lezcano
2016-11-08 8:30 ` Noam Camus
2016-11-10 10:34 ` Daniel Lezcano
2016-11-10 13:00 ` Noam Camus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103181112.GK1859@mai \
--to=daniel.lezcano@linaro.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.