From: Oleg Nesterov <oleg@redhat.com>
To: Jann Horn <jann@thejh.net>
Cc: security@kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
mchong@google.com, Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@kernel.org>, Nick Kralevich <nnk@google.com>,
Janis Danisevskis <jdanis@google.com>,
linux-security-module@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] fs/exec: don't force writing memory access
Date: Thu, 3 Nov 2016 19:24:39 +0100 [thread overview]
Message-ID: <20161103182439.GC11212@redhat.com> (raw)
In-Reply-To: <1478142286-18427-4-git-send-email-jann@thejh.net>
On 11/03, Jann Horn wrote:
>
> This shouldn't change behavior in any way - at this point, there should be
> no non-writable mappings, only the initial stack mapping -,
So this FOLL_FORCE just adds the unnecessary confusion,
> but this change
> makes it easier to reason about the correctness of the following commits
> that place restrictions on forced memory writes.
and to me it looks like a good cleanup regardless. Exactly because it
is not clear why do we need FOLL_FORCE.
> Signed-off-by: Jann Horn <jann@thejh.net>
> Reviewed-by: Janis Danisevskis <jdanis@android.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Jann Horn <jann@thejh.net>
Cc: security@kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
mchong@google.com, Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@kernel.org>, Nick Kralevich <nnk@google.com>,
Janis Danisevskis <jdanis@google.com>,
linux-security-module@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] fs/exec: don't force writing memory access
Date: Thu, 3 Nov 2016 19:24:39 +0100 [thread overview]
Message-ID: <20161103182439.GC11212@redhat.com> (raw)
In-Reply-To: <1478142286-18427-4-git-send-email-jann@thejh.net>
On 11/03, Jann Horn wrote:
>
> This shouldn't change behavior in any way - at this point, there should be
> no non-writable mappings, only the initial stack mapping -,
So this FOLL_FORCE just adds the unnecessary confusion,
> but this change
> makes it easier to reason about the correctness of the following commits
> that place restrictions on forced memory writes.
and to me it looks like a good cleanup regardless. Exactly because it
is not clear why do we need FOLL_FORCE.
> Signed-off-by: Jann Horn <jann@thejh.net>
> Reviewed-by: Janis Danisevskis <jdanis@android.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2016-11-03 17:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 3:04 [PATCH 1/3] fs/exec: don't force writing memory access Jann Horn
2016-11-03 3:04 ` Jann Horn
2016-11-03 3:04 ` [PATCH 2/3] mm: add LSM hook for writes to readonly memory Jann Horn
2016-11-03 3:04 ` Jann Horn
2016-11-03 10:39 ` Jann Horn
2016-11-03 3:04 ` [PATCH 3/3] selinux: require EXECMEM for forced ptrace poke Jann Horn
2016-11-03 3:04 ` Jann Horn
2016-11-03 3:04 ` [PATCH v3 1/3] fs/exec: don't force writing memory access Jann Horn
2016-11-03 3:04 ` Jann Horn
2016-11-03 18:24 ` Oleg Nesterov [this message]
2016-11-03 18:24 ` Oleg Nesterov
2016-11-03 3:04 ` [PATCH v3 2/3] mm: add LSM hook for writes to readonly memory Jann Horn
2016-11-03 3:04 ` Jann Horn
2016-11-03 3:10 ` Jann Horn
2016-11-03 3:04 ` [PATCH v3 3/3] selinux: require EXECMEM for forced ptrace poke Jann Horn
2016-11-03 3:04 ` Jann Horn
2016-11-03 13:21 ` Stephen Smalley
2016-11-03 13:21 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103182439.GC11212@redhat.com \
--to=oleg@redhat.com \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=jann@thejh.net \
--cc=jdanis@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mchong@google.com \
--cc=mingo@kernel.org \
--cc=nnk@google.com \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=security@kernel.org \
--cc=serge@hallyn.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.