From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: hugetlb: remove the wrong pmd check in find_num_contig()
Date: Thu, 3 Nov 2016 18:16:16 -0600 [thread overview]
Message-ID: <20161104001616.ssjbemliorxi6evl@localhost> (raw)
In-Reply-To: <1478140059-13829-2-git-send-email-shijie.huang@arm.com>
On Thu, Nov 03, 2016 at 10:27:38AM +0800, Huang Shijie wrote:
> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
> index 2e49bd2..4811ef1 100644
> --- a/arch/arm64/mm/hugetlbpage.c
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -61,10 +61,6 @@ static int find_num_contig(struct mm_struct *mm, unsigned long addr,
> return 1;
> }
> pmd = pmd_offset(pud, addr);
> - if (!pmd_present(*pmd)) {
> - VM_BUG_ON(!pmd_present(*pmd));
> - return 1;
> - }
> if ((pte_t *)pmd == ptep) {
> *pgsize = PMD_SIZE;
> return CONT_PMDS;
BTW, for the !pud_present() and !pgd_present() cases, shouldn't
find_num_contig() actually return 0? These are more likely real bugs, so
no point in setting the huge pte.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Huang Shijie <shijie.huang@arm.com>
Cc: dwoods@mellanox.com, steve.capper@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, kaly.xin@arm.com,
akpm@linux-foundation.org, nd@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: hugetlb: remove the wrong pmd check in find_num_contig()
Date: Thu, 3 Nov 2016 18:16:16 -0600 [thread overview]
Message-ID: <20161104001616.ssjbemliorxi6evl@localhost> (raw)
In-Reply-To: <1478140059-13829-2-git-send-email-shijie.huang@arm.com>
On Thu, Nov 03, 2016 at 10:27:38AM +0800, Huang Shijie wrote:
> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
> index 2e49bd2..4811ef1 100644
> --- a/arch/arm64/mm/hugetlbpage.c
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -61,10 +61,6 @@ static int find_num_contig(struct mm_struct *mm, unsigned long addr,
> return 1;
> }
> pmd = pmd_offset(pud, addr);
> - if (!pmd_present(*pmd)) {
> - VM_BUG_ON(!pmd_present(*pmd));
> - return 1;
> - }
> if ((pte_t *)pmd == ptep) {
> *pgsize = PMD_SIZE;
> return CONT_PMDS;
BTW, for the !pud_present() and !pgd_present() cases, shouldn't
find_num_contig() actually return 0? These are more likely real bugs, so
no point in setting the huge pte.
--
Catalin
next prev parent reply other threads:[~2016-11-04 0:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 2:27 [PATCH 0/2] arm64: fix the bugs found in the hugetlb test Huang Shijie
2016-11-03 2:27 ` Huang Shijie
2016-11-03 2:27 ` [PATCH 1/2] arm64: hugetlb: remove the wrong pmd check in find_num_contig() Huang Shijie
2016-11-03 2:27 ` Huang Shijie
2016-11-04 0:16 ` Catalin Marinas [this message]
2016-11-04 0:16 ` Catalin Marinas
2016-11-04 2:52 ` Huang Shijie
2016-11-04 2:52 ` Huang Shijie
2016-11-04 15:48 ` Catalin Marinas
2016-11-04 15:48 ` Catalin Marinas
2016-11-08 2:25 ` Huang Shijie
2016-11-08 2:25 ` Huang Shijie
2016-11-03 2:27 ` [PATCH 2/2] arm64: hugetlb: fix the wrong address for several functions Huang Shijie
2016-11-03 2:27 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104001616.ssjbemliorxi6evl@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.