All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] arm64: arch_timer: Introduce a generic erratum handing mechanism for fsl-a008585
Date: Fri, 4 Nov 2016 18:55:40 +0000	[thread overview]
Message-ID: <20161104185540.GA22791@arm.com> (raw)
In-Reply-To: <20161104182050.GA1651@buserror.net>

On Fri, Nov 04, 2016 at 01:20:50PM -0500, Scott Wood wrote:
> On Fri, Nov 04, 2016 at 09:06:30PM +0800, Ding Tianhong wrote:
> > The workaround for hisilicon,161601 will check the return value of the system counter
> > by different way, in order to distinguish with the fsl-a008585 workaround, introduce
> > a new generic erratum handing mechanism for fsl-a008585 and rename some functions.
> > 
> > v2: Introducing a new generic erratum handling mechanism for fsl erratum a008585.
> > 
> > v3: Introducing the erratum_workaround_set_sne generic function for fsl erratum a008585
> >     and make the #define __fsl_a008585_read_reg to be private to the .c file instead of
> >     being globally visible. After discussion with Marc and Will, a consensus decision was
> >     made to remove the commandline parameter for enabling fsl,erratum-a008585 erratum,
> >     and make some generic name more specific, export timer_unstable_counter_workaround
> >     for module access.
> 
> The command line paramter was added at Marc's request to provide a way of
> enbaling the workaround in a KVM guest, until API is added to allow QEMU to
> discover the need to set the property in the guest device tree.  Is there an
> alternative?

Yes -- generate the device-tree property to indicate that there's an issue.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Scott Wood <scott-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>
Cc: Ding Tianhong
	<dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	stuart.yoder-3arQi8VN3Tc@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v3 2/6] arm64: arch_timer: Introduce a generic erratum handing mechanism for fsl-a008585
Date: Fri, 4 Nov 2016 18:55:40 +0000	[thread overview]
Message-ID: <20161104185540.GA22791@arm.com> (raw)
In-Reply-To: <20161104182050.GA1651-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>

On Fri, Nov 04, 2016 at 01:20:50PM -0500, Scott Wood wrote:
> On Fri, Nov 04, 2016 at 09:06:30PM +0800, Ding Tianhong wrote:
> > The workaround for hisilicon,161601 will check the return value of the system counter
> > by different way, in order to distinguish with the fsl-a008585 workaround, introduce
> > a new generic erratum handing mechanism for fsl-a008585 and rename some functions.
> > 
> > v2: Introducing a new generic erratum handling mechanism for fsl erratum a008585.
> > 
> > v3: Introducing the erratum_workaround_set_sne generic function for fsl erratum a008585
> >     and make the #define __fsl_a008585_read_reg to be private to the .c file instead of
> >     being globally visible. After discussion with Marc and Will, a consensus decision was
> >     made to remove the commandline parameter for enabling fsl,erratum-a008585 erratum,
> >     and make some generic name more specific, export timer_unstable_counter_workaround
> >     for module access.
> 
> The command line paramter was added at Marc's request to provide a way of
> enbaling the workaround in a KVM guest, until API is added to allow QEMU to
> discover the need to set the property in the guest device tree.  Is there an
> alternative?

Yes -- generate the device-tree property to indicate that there's an issue.

Will
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-11-04 18:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 13:06 [PATCH v3 1/6] arm64: arch_timer: Add device tree binding for hisilicon-161601 erratum Ding Tianhong
2016-11-04 13:06 ` Ding Tianhong
2016-11-04 13:06 ` [PATCH v3 2/6] arm64: arch_timer: Introduce a generic erratum handing mechanism for fsl-a008585 Ding Tianhong
2016-11-04 13:06   ` Ding Tianhong
2016-11-04 18:20   ` Scott Wood
2016-11-04 18:20     ` Scott Wood
2016-11-04 18:55     ` Will Deacon [this message]
2016-11-04 18:55       ` Will Deacon
2016-11-04 13:06 ` [PATCH v3 3/6] arm64: arch_timer: Work around Erratum Hisilicon-161601 Ding Tianhong
2016-11-04 13:06   ` Ding Tianhong
2016-11-04 13:06 ` [PATCH v3 4/6] arm64: arch timer: Add timer erratum property for Hip05-d02 and Hip06-d03 Ding Tianhong
2016-11-04 13:06   ` Ding Tianhong
2016-11-04 13:06 ` [PATCH v3 5/6] arm64: arch_timer: apci: Introduce a generic aquirk framework for erratum Ding Tianhong
2016-11-04 13:06   ` Ding Tianhong
2016-11-14  8:12   ` Hanjun Guo
2016-11-14  8:12     ` Hanjun Guo
2016-11-14 11:15     ` Ding Tianhong
2016-11-14 11:15       ` Ding Tianhong
2016-11-04 13:06 ` [PATCH v3 6/6] arm64: arch_timer: acpi: add hisi timer errata data Ding Tianhong
2016-11-04 13:06   ` Ding Tianhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104185540.GA22791@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.