All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] mmc: sunxi: Enable 8bits bus width for sun8i
Date: Mon, 7 Nov 2016 09:39:30 +0100	[thread overview]
Message-ID: <20161107083930.ynpvdioskrs33wdk@lukather> (raw)
In-Reply-To: <CAGb2v67x5KZbNYN2M51Gy5ruzcb3trDs6Gv+BTo8esPtUW0Rkg@mail.gmail.com>

1;4600;0c
On Mon, Nov 07, 2016 at 09:53:00AM +0800, Chen-Yu Tsai wrote:
> On Mon, Nov 7, 2016 at 1:15 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Sat, Nov 05, 2016 at 09:34:25AM +0800, Chen-Yu Tsai wrote:
> >> On Fri, Nov 4, 2016 at 11:18 PM, Maxime Ripard
> >> <maxime.ripard@free-electrons.com> wrote:
> >> > The sun8i SoCs also have a 8 bits capable MMC2 controller. Enable the
> >> > support for those too.
> >> >
> >> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> > ---
> >> >  drivers/mmc/sunxi_mmc.c | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> >> > index 6953accce123..b8716c93cb06 100644
> >> > --- a/drivers/mmc/sunxi_mmc.c
> >> > +++ b/drivers/mmc/sunxi_mmc.c
> >> > @@ -463,7 +463,7 @@ struct mmc *sunxi_mmc_init(int sdc_no)
> >> >
> >> >         cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
> >> >         cfg->host_caps = MMC_MODE_4BIT;
> >> > -#ifdef CONFIG_MACH_SUN50I
> >> > +#if defined(CONFIG_MACH_SUN50I) || defined(CONFIG_MACH_SUN8I)
> >>
> >> 8 come before 50. :)
> >
> > But 5 comes before 8, and 0 before i :)
> 
> Indeed, though 8 and 50 are akin to a generation number, so
> it makes sense to sort them in natural order. :)

I know, but it was one of the comments I had in Linux, and we used
that ordering there. And we probably want to be consistent, but I
don't really care.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161107/8c125758/attachment.sig>

  reply	other threads:[~2016-11-07  8:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 15:18 [U-Boot] [PATCH 0/4] sunxi: Improve the SinA33 support Maxime Ripard
2016-11-04 15:18 ` [U-Boot] [PATCH 1/4] mmc: Retry the switch command Maxime Ripard
2016-11-13 18:50   ` Hans de Goede
2016-11-13 22:50     ` Tom Rini
2016-11-14  0:34       ` Jaehoon Chung
2016-11-14  9:56         ` Hans de Goede
2016-11-14 10:20           ` Jaehoon Chung
2016-11-14 12:04     ` Jaehoon Chung
2016-11-04 15:18 ` [U-Boot] [PATCH 2/4] mmc: sunxi: Enable 8bits bus width for sun8i Maxime Ripard
2016-11-05  1:34   ` Chen-Yu Tsai
2016-11-06 17:15     ` Maxime Ripard
2016-11-07  1:53       ` Chen-Yu Tsai
2016-11-07  8:39         ` Maxime Ripard [this message]
2016-11-07  8:47           ` Chen-Yu Tsai
2016-11-13 18:51   ` Hans de Goede
2016-11-14 12:04     ` Jaehoon Chung
2016-11-04 15:18 ` [U-Boot] [PATCH 3/4] sunxi: sina33: Enable the eMMC Maxime Ripard
2016-11-05  1:34   ` Chen-Yu Tsai
2016-11-13 18:51   ` Hans de Goede
2016-11-14 12:05     ` Jaehoon Chung
2016-11-04 15:18 ` [U-Boot] [PATCH 4/4] sunxi: sina33: Enable the LCD Maxime Ripard
2016-11-11 10:30   ` Chen-Yu Tsai
2016-11-13 18:51   ` Hans de Goede
2016-11-14 11:10     ` Jaehoon Chung
2016-11-14 12:05     ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107083930.ynpvdioskrs33wdk@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.