All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure
Date: Mon, 7 Nov 2016 11:03:31 +0100	[thread overview]
Message-ID: <20161107100331.GA19666@kroah.com> (raw)
In-Reply-To: <20161031081035.22677-1-mzoran@crowfest.net>

On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote:
> The current dma_map_sg based implementation for bulk messages
> computes many offsets into a single allocation multiple times in
> both the create and free code paths.  This is inefficient,
> error prone and in fact still has a few lingering issues
> with arm64.
> 
> This change replaces a small portion of that inplementation with
> new code that uses a new struct vchiq_pagelist_info to store the
> needed information rather then complex offset calculations.
> 
> This improved implementation should be more efficient and easier
> to understand and maintain.
> 
> Tests Run(Both Pass):
> vchiq_test -p 1
> vchiq_test -f 10
> 
> Signed-off-by: Michael Zoran <mzoran@crowfest.net>
> ---
>  .../interface/vchiq_arm/vchiq_2835_arm.c           | 223 +++++++++++----------
>  1 file changed, 113 insertions(+), 110 deletions(-)

This doesn't apply to the tree anymore because of your previous patch :(

Can you refresh it and resend?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Zoran <mzoran@crowfest.net>
Cc: devel@driverdev.osuosl.org, daniels@collabora.com,
	swarren@wwwdotorg.org, lee@kernel.org,
	linux-kernel@vger.kernel.org, eric@anholt.net,
	noralf@tronnes.org, linux-rpi-kernel@lists.infradead.org,
	popcornmix@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure
Date: Mon, 7 Nov 2016 11:03:31 +0100	[thread overview]
Message-ID: <20161107100331.GA19666@kroah.com> (raw)
In-Reply-To: <20161031081035.22677-1-mzoran@crowfest.net>

On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote:
> The current dma_map_sg based implementation for bulk messages
> computes many offsets into a single allocation multiple times in
> both the create and free code paths.  This is inefficient,
> error prone and in fact still has a few lingering issues
> with arm64.
> 
> This change replaces a small portion of that inplementation with
> new code that uses a new struct vchiq_pagelist_info to store the
> needed information rather then complex offset calculations.
> 
> This improved implementation should be more efficient and easier
> to understand and maintain.
> 
> Tests Run(Both Pass):
> vchiq_test -p 1
> vchiq_test -f 10
> 
> Signed-off-by: Michael Zoran <mzoran@crowfest.net>
> ---
>  .../interface/vchiq_arm/vchiq_2835_arm.c           | 223 +++++++++++----------
>  1 file changed, 113 insertions(+), 110 deletions(-)

This doesn't apply to the tree anymore because of your previous patch :(

Can you refresh it and resend?

thanks,

greg k-h

  reply	other threads:[~2016-11-07 10:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31  8:10 [PATCH] staging: vc04_services: add vchiq_pagelist_info structure Michael Zoran
2016-10-31  8:10 ` Michael Zoran
2016-11-07 10:03 ` Greg KH [this message]
2016-11-07 10:03   ` Greg KH
2016-11-07 15:41   ` Michael Zoran
2016-11-07 15:41     ` Michael Zoran
2016-11-10 22:50     ` Greg KH
2016-11-10 22:50       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107100331.GA19666@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.