* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 8:18 ` LABBE Corentin 0 siblings, 0 replies; 18+ messages in thread From: LABBE Corentin @ 2016-11-07 8:18 UTC (permalink / raw) To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8, wens-jdAy2FN1RRM Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A, linux-gpio-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw Hello With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 Without it, all subsequent drivers fail to load. Tested on Orange PI PC board. Regards ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 8:18 ` LABBE Corentin 0 siblings, 0 replies; 18+ messages in thread From: LABBE Corentin @ 2016-11-07 8:18 UTC (permalink / raw) To: maxime.ripard, wens Cc: linus.walleij, linux-gpio, linux-arm-kernel, linux-kernel, linux-sunxi Hello With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 Without it, all subsequent drivers fail to load. Tested on Orange PI PC board. Regards ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 8:18 ` LABBE Corentin 0 siblings, 0 replies; 18+ messages in thread From: LABBE Corentin @ 2016-11-07 8:18 UTC (permalink / raw) To: linux-arm-kernel Hello With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 Without it, all subsequent drivers fail to load. Tested on Orange PI PC board. Regards ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE 2016-11-07 8:18 ` LABBE Corentin @ 2016-11-07 9:48 ` Chen-Yu Tsai -1 siblings, 0 replies; 18+ messages in thread From: Chen-Yu Tsai @ 2016-11-07 9:48 UTC (permalink / raw) To: LABBE Corentin Cc: Maxime Ripard, Chen-Yu Tsai, Linus Walleij, linux-gpio@vger.kernel.org, linux-arm-kernel, linux-kernel, linux-sunxi Hi, On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > Hello > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > Without it, all subsequent drivers fail to load. > Tested on Orange PI PC board. I don't think the pinctrl drivers were designed to be removed. And I thought the lack of a .remove callback in the driver blocks the core from removing the device? Maybe I remember wrong... ChenYu > > Regards ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 9:48 ` Chen-Yu Tsai 0 siblings, 0 replies; 18+ messages in thread From: Chen-Yu Tsai @ 2016-11-07 9:48 UTC (permalink / raw) To: linux-arm-kernel Hi, On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > Hello > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > Without it, all subsequent drivers fail to load. > Tested on Orange PI PC board. I don't think the pinctrl drivers were designed to be removed. And I thought the lack of a .remove callback in the driver blocks the core from removing the device? Maybe I remember wrong... ChenYu > > Regards ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE 2016-11-07 9:48 ` Chen-Yu Tsai @ 2016-11-07 9:56 ` Maxime Ripard -1 siblings, 0 replies; 18+ messages in thread From: Maxime Ripard @ 2016-11-07 9:56 UTC (permalink / raw) To: Chen-Yu Tsai Cc: LABBE Corentin, Linus Walleij, linux-gpio@vger.kernel.org, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1446 bytes --] On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > <clabbe.montjoie@gmail.com> wrote: > > Hello > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > Without it, all subsequent drivers fail to load. > > Tested on Orange PI PC board. > > I don't think the pinctrl drivers were designed to be removed. > And I thought the lack of a .remove callback in the driver blocks > the core from removing the device? Maybe I remember wrong... Using a builtin_platform_driver should be enough to prevent it to be removed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 9:56 ` Maxime Ripard 0 siblings, 0 replies; 18+ messages in thread From: Maxime Ripard @ 2016-11-07 9:56 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > <clabbe.montjoie@gmail.com> wrote: > > Hello > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > Without it, all subsequent drivers fail to load. > > Tested on Orange PI PC board. > > I don't think the pinctrl drivers were designed to be removed. > And I thought the lack of a .remove callback in the driver blocks > the core from removing the device? Maybe I remember wrong... Using a builtin_platform_driver should be enough to prevent it to be removed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161107/862f84d3/attachment.sig> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE 2016-11-07 9:56 ` Maxime Ripard (?) @ 2016-11-07 9:58 ` Chen-Yu Tsai -1 siblings, 0 replies; 18+ messages in thread From: Chen-Yu Tsai @ 2016-11-07 9:58 UTC (permalink / raw) To: LABBE Corentin Cc: Chen-Yu Tsai, Maxime Ripard, Linus Walleij, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel, linux-kernel, linux-sunxi On Mon, Nov 7, 2016 at 5:56 PM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin >> <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >> > Hello >> > >> > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. >> > >> > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver >> > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip >> > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register >> > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 >> > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver >> > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip >> > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register >> > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 >> > >> > Without it, all subsequent drivers fail to load. >> > Tested on Orange PI PC board. >> >> I don't think the pinctrl drivers were designed to be removed. >> And I thought the lack of a .remove callback in the driver blocks >> the core from removing the device? Maybe I remember wrong... > > Using a builtin_platform_driver should be enough to prevent it to be > removed. Labbe, can you test it again on linux-next? Or at least with this patch 0c8c6ba00cbf pinctrl: sunxi: make bool drivers explicitly non-modular from linux-pinctrl applied. This should fix it. ChenYu ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 9:58 ` Chen-Yu Tsai 0 siblings, 0 replies; 18+ messages in thread From: Chen-Yu Tsai @ 2016-11-07 9:58 UTC (permalink / raw) To: LABBE Corentin Cc: Chen-Yu Tsai, Maxime Ripard, Linus Walleij, linux-gpio@vger.kernel.org, linux-arm-kernel, linux-kernel, linux-sunxi On Mon, Nov 7, 2016 at 5:56 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin >> <clabbe.montjoie@gmail.com> wrote: >> > Hello >> > >> > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. >> > >> > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver >> > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip >> > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register >> > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 >> > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver >> > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip >> > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register >> > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 >> > >> > Without it, all subsequent drivers fail to load. >> > Tested on Orange PI PC board. >> >> I don't think the pinctrl drivers were designed to be removed. >> And I thought the lack of a .remove callback in the driver blocks >> the core from removing the device? Maybe I remember wrong... > > Using a builtin_platform_driver should be enough to prevent it to be > removed. Labbe, can you test it again on linux-next? Or at least with this patch 0c8c6ba00cbf pinctrl: sunxi: make bool drivers explicitly non-modular from linux-pinctrl applied. This should fix it. ChenYu ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 9:58 ` Chen-Yu Tsai 0 siblings, 0 replies; 18+ messages in thread From: Chen-Yu Tsai @ 2016-11-07 9:58 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 7, 2016 at 5:56 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin >> <clabbe.montjoie@gmail.com> wrote: >> > Hello >> > >> > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. >> > >> > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver >> > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip >> > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register >> > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 >> > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver >> > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip >> > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register >> > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 >> > >> > Without it, all subsequent drivers fail to load. >> > Tested on Orange PI PC board. >> >> I don't think the pinctrl drivers were designed to be removed. >> And I thought the lack of a .remove callback in the driver blocks >> the core from removing the device? Maybe I remember wrong... > > Using a builtin_platform_driver should be enough to prevent it to be > removed. Labbe, can you test it again on linux-next? Or at least with this patch 0c8c6ba00cbf pinctrl: sunxi: make bool drivers explicitly non-modular from linux-pinctrl applied. This should fix it. ChenYu ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE 2016-11-07 9:56 ` Maxime Ripard (?) @ 2016-11-07 9:59 ` Corentin Labbe -1 siblings, 0 replies; 18+ messages in thread From: Corentin Labbe @ 2016-11-07 9:59 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Linus Walleij, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel, linux-kernel, linux-sunxi On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > Hi, > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > > Hello > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > Without it, all subsequent drivers fail to load. > > > Tested on Orange PI PC board. > > > > I don't think the pinctrl drivers were designed to be removed. > > And I thought the lack of a .remove callback in the driver blocks > > the core from removing the device? Maybe I remember wrong... > > Using a builtin_platform_driver should be enough to prevent it to be > removed. > The problem is that it is already builtin_platform_driver() ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 9:59 ` Corentin Labbe 0 siblings, 0 replies; 18+ messages in thread From: Corentin Labbe @ 2016-11-07 9:59 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Linus Walleij, linux-gpio@vger.kernel.org, linux-arm-kernel, linux-kernel, linux-sunxi On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > Hi, > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > <clabbe.montjoie@gmail.com> wrote: > > > Hello > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > Without it, all subsequent drivers fail to load. > > > Tested on Orange PI PC board. > > > > I don't think the pinctrl drivers were designed to be removed. > > And I thought the lack of a .remove callback in the driver blocks > > the core from removing the device? Maybe I remember wrong... > > Using a builtin_platform_driver should be enough to prevent it to be > removed. > The problem is that it is already builtin_platform_driver() ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 9:59 ` Corentin Labbe 0 siblings, 0 replies; 18+ messages in thread From: Corentin Labbe @ 2016-11-07 9:59 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > Hi, > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > <clabbe.montjoie@gmail.com> wrote: > > > Hello > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > Without it, all subsequent drivers fail to load. > > > Tested on Orange PI PC board. > > > > I don't think the pinctrl drivers were designed to be removed. > > And I thought the lack of a .remove callback in the driver blocks > > the core from removing the device? Maybe I remember wrong... > > Using a builtin_platform_driver should be enough to prevent it to be > removed. > The problem is that it is already builtin_platform_driver() ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE 2016-11-07 9:59 ` Corentin Labbe (?) @ 2016-11-07 10:15 ` Maxime Ripard -1 siblings, 0 replies; 18+ messages in thread From: Maxime Ripard @ 2016-11-07 10:15 UTC (permalink / raw) To: Corentin Labbe Cc: Chen-Yu Tsai, Linus Walleij, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1807 bytes --] On Mon, Nov 07, 2016 at 10:59:53AM +0100, Corentin Labbe wrote: > On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > > Hi, > > > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > > <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > > > Hello > > > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > > > Without it, all subsequent drivers fail to load. > > > > Tested on Orange PI PC board. > > > > > > I don't think the pinctrl drivers were designed to be removed. > > > And I thought the lack of a .remove callback in the driver blocks > > > the core from removing the device? Maybe I remember wrong... > > > > Using a builtin_platform_driver should be enough to prevent it to be > > removed. > > > > The problem is that it is already builtin_platform_driver() Then there's no way it can be removed in the first place. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 10:15 ` Maxime Ripard 0 siblings, 0 replies; 18+ messages in thread From: Maxime Ripard @ 2016-11-07 10:15 UTC (permalink / raw) To: Corentin Labbe Cc: Chen-Yu Tsai, Linus Walleij, linux-gpio@vger.kernel.org, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1819 bytes --] On Mon, Nov 07, 2016 at 10:59:53AM +0100, Corentin Labbe wrote: > On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > > Hi, > > > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > > <clabbe.montjoie@gmail.com> wrote: > > > > Hello > > > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > > > Without it, all subsequent drivers fail to load. > > > > Tested on Orange PI PC board. > > > > > > I don't think the pinctrl drivers were designed to be removed. > > > And I thought the lack of a .remove callback in the driver blocks > > > the core from removing the device? Maybe I remember wrong... > > > > Using a builtin_platform_driver should be enough to prevent it to be > > removed. > > > > The problem is that it is already builtin_platform_driver() Then there's no way it can be removed in the first place. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 10:15 ` Maxime Ripard 0 siblings, 0 replies; 18+ messages in thread From: Maxime Ripard @ 2016-11-07 10:15 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 07, 2016 at 10:59:53AM +0100, Corentin Labbe wrote: > On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > > Hi, > > > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > > <clabbe.montjoie@gmail.com> wrote: > > > > Hello > > > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > > > Without it, all subsequent drivers fail to load. > > > > Tested on Orange PI PC board. > > > > > > I don't think the pinctrl drivers were designed to be removed. > > > And I thought the lack of a .remove callback in the driver blocks > > > the core from removing the device? Maybe I remember wrong... > > > > Using a builtin_platform_driver should be enough to prevent it to be > > removed. > > > > The problem is that it is already builtin_platform_driver() Then there's no way it can be removed in the first place. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161107/7d77b907/attachment.sig> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE 2016-11-07 10:15 ` Maxime Ripard @ 2016-11-07 10:28 ` Corentin Labbe -1 siblings, 0 replies; 18+ messages in thread From: Corentin Labbe @ 2016-11-07 10:28 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Linus Walleij, linux-gpio@vger.kernel.org, linux-arm-kernel, linux-kernel, linux-sunxi On Mon, Nov 07, 2016 at 11:15:00AM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2016 at 10:59:53AM +0100, Corentin Labbe wrote: > > On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > > > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > > > Hi, > > > > > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > > > <clabbe.montjoie@gmail.com> wrote: > > > > > Hello > > > > > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > > > > > Without it, all subsequent drivers fail to load. > > > > > Tested on Orange PI PC board. > > > > > > > > I don't think the pinctrl drivers were designed to be removed. > > > > And I thought the lack of a .remove callback in the driver blocks > > > > the core from removing the device? Maybe I remember wrong... > > > > > > Using a builtin_platform_driver should be enough to prevent it to be > > > removed. > > > > > > > The problem is that it is already builtin_platform_driver() > > Then there's no way it can be removed in the first place. > I will send a patch for fixing CONFIG_DEBUG_TEST_DRIVER_REMOVE ^ permalink raw reply [flat|nested] 18+ messages in thread
* [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE @ 2016-11-07 10:28 ` Corentin Labbe 0 siblings, 0 replies; 18+ messages in thread From: Corentin Labbe @ 2016-11-07 10:28 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 07, 2016 at 11:15:00AM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2016 at 10:59:53AM +0100, Corentin Labbe wrote: > > On Mon, Nov 07, 2016 at 10:56:12AM +0100, Maxime Ripard wrote: > > > On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote: > > > > Hi, > > > > > > > > On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin > > > > <clabbe.montjoie@gmail.com> wrote: > > > > > Hello > > > > > > > > > > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. > > > > > > > > > > [ 3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver > > > > > [ 3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip > > > > > [ 3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register > > > > > [ 3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16 > > > > > [ 3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver > > > > > [ 3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip > > > > > [ 3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register > > > > > [ 3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16 > > > > > > > > > > Without it, all subsequent drivers fail to load. > > > > > Tested on Orange PI PC board. > > > > > > > > I don't think the pinctrl drivers were designed to be removed. > > > > And I thought the lack of a .remove callback in the driver blocks > > > > the core from removing the device? Maybe I remember wrong... > > > > > > Using a builtin_platform_driver should be enough to prevent it to be > > > removed. > > > > > > > The problem is that it is already builtin_platform_driver() > > Then there's no way it can be removed in the first place. > I will send a patch for fixing CONFIG_DEBUG_TEST_DRIVER_REMOVE ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-11-07 11:53 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-07 8:18 [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE LABBE Corentin 2016-11-07 8:18 ` LABBE Corentin 2016-11-07 8:18 ` LABBE Corentin 2016-11-07 9:48 ` Chen-Yu Tsai 2016-11-07 9:48 ` Chen-Yu Tsai 2016-11-07 9:56 ` Maxime Ripard 2016-11-07 9:56 ` Maxime Ripard 2016-11-07 9:58 ` Chen-Yu Tsai 2016-11-07 9:58 ` Chen-Yu Tsai 2016-11-07 9:58 ` Chen-Yu Tsai 2016-11-07 9:59 ` Corentin Labbe 2016-11-07 9:59 ` Corentin Labbe 2016-11-07 9:59 ` Corentin Labbe 2016-11-07 10:15 ` Maxime Ripard 2016-11-07 10:15 ` Maxime Ripard 2016-11-07 10:15 ` Maxime Ripard 2016-11-07 10:28 ` Corentin Labbe 2016-11-07 10:28 ` Corentin Labbe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.