[PATCH] drm/tegra: sor: No need to free devm_ allocated memory

[PATCH] drm/tegra: sor: No need to free devm_ allocated memory

[Christophe JAILLET]

'brick' has been allocated by 'devm_kzalloc', so there is no need here to
free it explicitly.
There is only one caller of 'tegra_clk_sor_brick_register()'. This function
is a probe function which correctly checks and handles the return value of
'tegra_clk_sor_brick_register()'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/tegra/sor.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 74d0540b8d4c..a8f528925009 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -349,8 +349,6 @@ static struct clk *tegra_clk_sor_brick_register(struct tegra_sor *sor,
 	brick->hw.init = &init;
 
 	clk = devm_clk_register(sor->dev, &brick->hw);
-	if (IS_ERR(clk))
-		kfree(brick);
 
 	return clk;
 }
-- 
2.7.4

[PATCH] drm/tegra: sor: No need to free devm_ allocated memory

[Christophe JAILLET]

'brick' has been allocated by 'devm_kzalloc', so there is no need here to
free it explicitly.
There is only one caller of 'tegra_clk_sor_brick_register()'. This function
is a probe function which correctly checks and handles the return value of
'tegra_clk_sor_brick_register()'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/tegra/sor.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 74d0540b8d4c..a8f528925009 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -349,8 +349,6 @@ static struct clk *tegra_clk_sor_brick_register(struct tegra_sor *sor,
 	brick->hw.init = &init;
 
 	clk = devm_clk_register(sor->dev, &brick->hw);
-	if (IS_ERR(clk))
-		kfree(brick);
 
 	return clk;
 }
-- 
2.7.4

Re: [PATCH] drm/tegra: sor: No need to free devm_ allocated memory

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Sat, Sep 24, 2016 at 10:07:30PM +0200, Christophe JAILLET wrote:
> 'brick' has been allocated by 'devm_kzalloc', so there is no need here to
> free it explicitly.
> There is only one caller of 'tegra_clk_sor_brick_register()'. This function
> is a probe function which correctly checks and handles the return value of
> 'tegra_clk_sor_brick_register()'.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/tegra/sor.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, with a slightly reworded commit message.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH] drm/tegra: sor: No need to free devm_ allocated memory

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]

On Sat, Sep 24, 2016 at 10:07:30PM +0200, Christophe JAILLET wrote:
> 'brick' has been allocated by 'devm_kzalloc', so there is no need here to
> free it explicitly.
> There is only one caller of 'tegra_clk_sor_brick_register()'. This function
> is a probe function which correctly checks and handles the return value of
> 'tegra_clk_sor_brick_register()'.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/tegra/sor.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, with a slightly reworded commit message.

Thanks,
Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/tegra: sor: No need to free devm_ allocated memory

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Sat, Sep 24, 2016 at 10:07:30PM +0200, Christophe JAILLET wrote:
> 'brick' has been allocated by 'devm_kzalloc', so there is no need here to
> free it explicitly.
> There is only one caller of 'tegra_clk_sor_brick_register()'. This function
> is a probe function which correctly checks and handles the return value of
> 'tegra_clk_sor_brick_register()'.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/tegra/sor.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, with a slightly reworded commit message.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]