From: Andrew Morton <akpm@linux-foundation.org>
To: Thomas Garnier <thgarnie@google.com>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
gthelen@google.com, vdavydov.dev@gmail.com, mhocko@kernel.org
Subject: Re: [PATCH v3 1/2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB
Date: Mon, 7 Nov 2016 14:19:19 -0800 [thread overview]
Message-ID: <20161107141919.fe50cef419918c7a4660f3c2@linux-foundation.org> (raw)
In-Reply-To: <1478553075-120242-1-git-send-email-thgarnie@google.com>
On Mon, 7 Nov 2016 13:11:14 -0800 Thomas Garnier <thgarnie@google.com> wrote:
> From: Greg Thelen <gthelen@google.com>
>
> While testing OBJFREELIST_SLAB integration with pagealloc, we found a
> bug where kmem_cache(sys) would be created with both CFLGS_OFF_SLAB &
> CFLGS_OBJFREELIST_SLAB.
>
> The original kmem_cache is created early making OFF_SLAB not possible.
> When kmem_cache(sys) is created, OFF_SLAB is possible and if pagealloc
> is enabled it will try to enable it first under certain conditions.
> Given kmem_cache(sys) reuses the original flag, you can have both flags
> at the same time resulting in allocation failures and odd behaviors.
Can we please have a better description of the problems which this bug
causes? Without this info it's unclear to me which kernel version(s)
need the fix.
Given that the bug is 6 months old I'm assuming "not very urgent".
> This fix discards allocator specific flags from memcg before calling
> create_cache.
>
> Fixes: b03a017bebc4 ("mm/slab: introduce new slab management type, OBJFREELIST_SLAB")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Tested-by: Thomas Garnier <thgarnie@google.com>
This should have had your signed-off-by, as you were on the delivery
path. I've made that change.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Thomas Garnier <thgarnie@google.com>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
gthelen@google.com, vdavydov.dev@gmail.com, mhocko@kernel.org
Subject: Re: [PATCH v3 1/2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB
Date: Mon, 7 Nov 2016 14:19:19 -0800 [thread overview]
Message-ID: <20161107141919.fe50cef419918c7a4660f3c2@linux-foundation.org> (raw)
In-Reply-To: <1478553075-120242-1-git-send-email-thgarnie@google.com>
On Mon, 7 Nov 2016 13:11:14 -0800 Thomas Garnier <thgarnie@google.com> wrote:
> From: Greg Thelen <gthelen@google.com>
>
> While testing OBJFREELIST_SLAB integration with pagealloc, we found a
> bug where kmem_cache(sys) would be created with both CFLGS_OFF_SLAB &
> CFLGS_OBJFREELIST_SLAB.
>
> The original kmem_cache is created early making OFF_SLAB not possible.
> When kmem_cache(sys) is created, OFF_SLAB is possible and if pagealloc
> is enabled it will try to enable it first under certain conditions.
> Given kmem_cache(sys) reuses the original flag, you can have both flags
> at the same time resulting in allocation failures and odd behaviors.
Can we please have a better description of the problems which this bug
causes? Without this info it's unclear to me which kernel version(s)
need the fix.
Given that the bug is 6 months old I'm assuming "not very urgent".
> This fix discards allocator specific flags from memcg before calling
> create_cache.
>
> Fixes: b03a017bebc4 ("mm/slab: introduce new slab management type, OBJFREELIST_SLAB")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Tested-by: Thomas Garnier <thgarnie@google.com>
This should have had your signed-off-by, as you were on the delivery
path. I've made that change.
next prev parent reply other threads:[~2016-11-07 22:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 21:11 [PATCH v3 1/2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB Thomas Garnier
2016-11-07 21:11 ` Thomas Garnier
2016-11-07 21:11 ` [PATCH v3 2/2] mm: Check kmem_create_cache flags are commons Thomas Garnier
2016-11-07 21:11 ` Thomas Garnier
2016-11-07 23:07 ` Andrew Morton
2016-11-07 23:07 ` Andrew Morton
2016-11-08 4:22 ` Thomas Garnier
2016-11-08 4:22 ` Thomas Garnier
2016-11-07 22:19 ` Andrew Morton [this message]
2016-11-07 22:19 ` [PATCH v3 1/2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB Andrew Morton
2016-11-07 22:32 ` Thomas Garnier
2016-11-07 22:32 ` Thomas Garnier
2016-11-07 22:49 ` Andrew Morton
2016-11-07 22:49 ` Andrew Morton
2016-11-08 4:23 ` Thomas Garnier
2016-11-08 4:23 ` Thomas Garnier
2016-11-08 23:51 ` Christoph Lameter
2016-11-08 23:51 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107141919.fe50cef419918c7a4660f3c2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=thgarnie@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.