From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/vdso: introduce vdso_mremap hook
Date: Mon, 7 Nov 2016 18:27:35 +0000 [thread overview]
Message-ID: <20161107182734.GL1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161101172214.2938-1-dsafonov@virtuozzo.com>
On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index 53cf86cf2d1a..d1001f87c2f6 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
> .pages = &vdso_data_page,
> };
>
> +static int vdso_mremap(const struct vm_special_mapping *sm,
> + struct vm_area_struct *new_vma);
I'd much rather avoid this forward declaration. Is there any reason the
function body can't be here?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
Kevin Brodsky <kevin.brodsky@arm.com>,
Christopher Covington <cov@codeaurora.org>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH] arm/vdso: introduce vdso_mremap hook
Date: Mon, 7 Nov 2016 18:27:35 +0000 [thread overview]
Message-ID: <20161107182734.GL1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161101172214.2938-1-dsafonov@virtuozzo.com>
On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index 53cf86cf2d1a..d1001f87c2f6 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
> .pages = &vdso_data_page,
> };
>
> +static int vdso_mremap(const struct vm_special_mapping *sm,
> + struct vm_area_struct *new_vma);
I'd much rather avoid this forward declaration. Is there any reason the
function body can't be here?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
Kevin Brodsky <kevin.brodsky@arm.com>,
Christopher Covington <cov@codeaurora.org>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH] arm/vdso: introduce vdso_mremap hook
Date: Mon, 7 Nov 2016 18:27:35 +0000 [thread overview]
Message-ID: <20161107182734.GL1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161101172214.2938-1-dsafonov@virtuozzo.com>
On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index 53cf86cf2d1a..d1001f87c2f6 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
> .pages = &vdso_data_page,
> };
>
> +static int vdso_mremap(const struct vm_special_mapping *sm,
> + struct vm_area_struct *new_vma);
I'd much rather avoid this forward declaration. Is there any reason the
function body can't be here?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-11-07 18:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 17:22 [PATCH] arm/vdso: introduce vdso_mremap hook Dmitry Safonov
2016-11-01 17:22 ` Dmitry Safonov
2016-11-01 17:22 ` Dmitry Safonov
2016-11-07 17:00 ` Christopher Covington
2016-11-07 17:00 ` Christopher Covington
2016-11-07 17:00 ` Christopher Covington
2016-11-07 17:16 ` Dmitry Safonov
2016-11-07 17:16 ` Dmitry Safonov
2016-11-07 17:16 ` Dmitry Safonov
2016-11-07 18:08 ` Christopher Covington
2016-11-07 18:08 ` Christopher Covington
2016-11-07 18:08 ` Christopher Covington
2016-11-07 18:13 ` Dmitry Safonov
2016-11-07 18:13 ` Dmitry Safonov
2016-11-07 18:13 ` Dmitry Safonov
2016-11-07 18:27 ` Russell King - ARM Linux [this message]
2016-11-07 18:27 ` Russell King - ARM Linux
2016-11-07 18:27 ` Russell King - ARM Linux
2016-11-07 18:36 ` Dmitry Safonov
2016-11-07 18:36 ` Dmitry Safonov
2016-11-07 18:36 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107182734.GL1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.