From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Scott Bauer <scott.bauer@intel.com>,
linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com,
axboe@fb.com, jonathan.derrick@intel.com, j.naumann@fu-berlin.de,
hch@infradead.org, linux-block@vger.kernel.org
Subject: Re: [RFC PATCH 5/6] nvme: Add unlock_from_suspend
Date: Mon, 7 Nov 2016 13:45:42 -0500 [thread overview]
Message-ID: <20161107184541.GA21698@localhost.localdomain> (raw)
In-Reply-To: <6a6a131a-09fe-4c7c-85a7-01149555e427@grimberg.me>
On Tue, Nov 01, 2016 at 10:18:13AM +0200, Sagi Grimberg wrote:
> > - spin_lock_irq(&nvmeq->q_lock);
> > + spin_lock_irqsave(&nvmeq->q_lock, flags);
> > if (unlikely(nvmeq->cq_vector < 0)) {
> > if (ns && !test_bit(NVME_NS_DEAD, &ns->flags))
> > ret = BLK_MQ_RQ_QUEUE_BUSY;
> > else
> > ret = BLK_MQ_RQ_QUEUE_ERROR;
> > - spin_unlock_irq(&nvmeq->q_lock);
> > + spin_unlock_irqrestore(&nvmeq->q_lock, flags);
> > goto out;
> > }
> > __nvme_submit_cmd(nvmeq, &cmnd);
> > nvme_process_cq(nvmeq);
> > - spin_unlock_irq(&nvmeq->q_lock);
> > + spin_unlock_irqrestore(&nvmeq->q_lock, flags);
>
> No documentation why this is needed...
Let's forget documenting why it's needed; this solution should instead
figure out a way to make it so it's not needed.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [RFC PATCH 5/6] nvme: Add unlock_from_suspend
Date: Mon, 7 Nov 2016 13:45:42 -0500 [thread overview]
Message-ID: <20161107184541.GA21698@localhost.localdomain> (raw)
In-Reply-To: <6a6a131a-09fe-4c7c-85a7-01149555e427@grimberg.me>
On Tue, Nov 01, 2016@10:18:13AM +0200, Sagi Grimberg wrote:
> > - spin_lock_irq(&nvmeq->q_lock);
> > + spin_lock_irqsave(&nvmeq->q_lock, flags);
> > if (unlikely(nvmeq->cq_vector < 0)) {
> > if (ns && !test_bit(NVME_NS_DEAD, &ns->flags))
> > ret = BLK_MQ_RQ_QUEUE_BUSY;
> > else
> > ret = BLK_MQ_RQ_QUEUE_ERROR;
> > - spin_unlock_irq(&nvmeq->q_lock);
> > + spin_unlock_irqrestore(&nvmeq->q_lock, flags);
> > goto out;
> > }
> > __nvme_submit_cmd(nvmeq, &cmnd);
> > nvme_process_cq(nvmeq);
> > - spin_unlock_irq(&nvmeq->q_lock);
> > + spin_unlock_irqrestore(&nvmeq->q_lock, flags);
>
> No documentation why this is needed...
Let's forget documenting why it's needed; this solution should instead
figure out a way to make it so it's not needed.
next prev parent reply other threads:[~2016-11-07 18:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 21:58 [RFC PATCH 0/6] Sed Opal Scott Bauer
2016-10-31 21:58 ` Scott Bauer
2016-10-31 21:58 ` [RFC PATCH 1/6] Include: Add definitions for sed Scott Bauer
2016-10-31 21:58 ` Scott Bauer
2016-10-31 21:58 ` [RFC PATCH 2/6] lib: Add Sed-opal library Scott Bauer
2016-10-31 21:58 ` Scott Bauer
2016-11-01 18:56 ` Jon Derrick
2016-11-01 18:56 ` Jon Derrick
2016-10-31 21:58 ` [RFC PATCH 3/6] lib: Add Sed to Kconfig and Makefile Scott Bauer
2016-10-31 21:58 ` Scott Bauer
2016-10-31 21:58 ` [RFC PATCH 4/6] include: Add sec_ops to block device operations Scott Bauer
2016-10-31 21:58 ` Scott Bauer
2016-10-31 21:58 ` [RFC PATCH 5/6] nvme: Add unlock_from_suspend Scott Bauer
2016-10-31 21:58 ` Scott Bauer
2016-11-01 8:18 ` Sagi Grimberg
2016-11-01 8:18 ` Sagi Grimberg
2016-11-01 13:57 ` Christoph Hellwig
2016-11-01 13:57 ` Christoph Hellwig
2016-11-01 14:40 ` Scott Bauer
2016-11-01 14:40 ` Scott Bauer
2016-11-10 23:01 ` Scott Bauer
2016-11-10 23:01 ` Scott Bauer
2016-11-10 23:23 ` Keith Busch
2016-11-10 23:23 ` Keith Busch
2016-11-10 23:19 ` Christoph Hellwig
2016-11-10 23:19 ` Christoph Hellwig
2016-11-07 18:45 ` Keith Busch [this message]
2016-11-07 18:45 ` Keith Busch
2016-11-07 18:33 ` Scott Bauer
2016-11-07 18:33 ` Scott Bauer
2016-10-31 21:58 ` [RFC PATCH 6/6] block: ioctl: Wire up Sed to block ioctls Scott Bauer
2016-10-31 21:58 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107184541.GA21698@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=Rafael.Antognolli@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=j.naumann@fu-berlin.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.