All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Michal Suchanek <msuchanek@suse.de>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.
Date: Mon, 7 Nov 2016 23:07:41 +0100	[thread overview]
Message-ID: <20161107220741.GL2367@var.home> (raw)
In-Reply-To: <20161107172656.1b2c59bb.cornelia.huck@de.ibm.com> <CAFEAcA8auW70Bpji93ujCjur3q4m3sffAtccv8S2MSzJSkydow@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hello,

On 7 November 2016 at 13:38, Michal Suchanek <msuchanek@suse.de> wrote:
> -    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null)-I/usr/include/ncursesw:"

Cornelia Huck, on Mon 07 Nov 2016 17:26:56 +0100, wrote:
> +    if [ "$curses_inc_list" == ":" ]; then
> +       # some systems don't provide a proper .pc file for ncursesw
> +       curses_inc_list="-I/usr/include/ncursesw:"
> +    fi

Could you rather try the attached patch?

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 765 bytes --]

diff --git a/configure b/configure
index fd6f898..e200aa8 100755
--- a/configure
+++ b/configure
@@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then
     curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):"
     curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses"
   else
-    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
+    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):-I/usr/include/ncursesw:"
     curses_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw"
   fi
   curses_found=no
@@ -2955,6 +2955,9 @@ EOF
         break
       fi
     done
+    if test "$curses_found" = yes ; then
+      break
+    fi
   done
   unset IFS
   if test "$curses_found" = "yes" ; then

  parent reply	other threads:[~2016-11-07 22:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 13:38 [Qemu-devel] [PATCH] Fix legacy ncurses detection Michal Suchanek
2016-11-07 13:55 ` Peter Maydell
2016-11-07 16:26   ` Cornelia Huck
2016-11-07 22:07   ` Samuel Thibault [this message]
2016-11-08 11:34     ` Cornelia Huck
2016-11-08 20:10       ` Samuel Thibault
2016-11-09  8:58         ` Cornelia Huck
2016-11-09  9:04           ` Samuel Thibault
2016-11-09  9:12             ` Cornelia Huck
2016-11-09  9:28               ` Samuel Thibault
2016-11-09  9:40                 ` Cornelia Huck
2016-11-09  9:52                   ` Samuel Thibault
2016-11-09 10:04                     ` Cornelia Huck
2016-11-09 10:15                       ` Sergey Smolov
2016-11-09 10:25                         ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107220741.GL2367@var.home \
    --to=samuel.thibault@gnu.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=msuchanek@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.