Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Tue, 8 Nov 2016 21:10:19 +0100
Samuel Thibault <samuel.thibault@gnu.org> wrote:

> Cornelia Huck, on Tue 08 Nov 2016 12:34:49 +0100, wrote:
> > > diff --git a/configure b/configure
> > > index fd6f898..e200aa8 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then
> > >      curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):"
> > >      curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses"
> > >    else
> > > -    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> > > +    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):-I/usr/include/ncursesw:"
> > 
> > This arrives at
> > 
> > curses_inc_list=":-I/usr/include/ncursesw:"
> > 
> > which causes the parser below to start with an empty curses_inc (with :
> > as separator).
> 
> Yes, this is expected.
> 
> > configure fails as before (with -Werror; passes without).
> 
> Ah!
> So are you getting the following message?
> 
> “
> configure test passed without -Werror but failed with -Werror.
> This is probably a bug in the configure script. The failing command
> will be at the bottom of config.log.
> You can run configure with --disable-werror to bypass this check.
> ”
> 
> If so, you should really have said it, I was really wondering how
> configure could just stopping in your case.  That does explain things
> indeed.

I said so in my very first mail for the issue... appears I was unclear.

> 
> Could you try the attached patch?  It should be able to really fail
> without Werror too.

With your patch, configure runs through and detects curses=no. Not sure
that's correct, though: SLES12SP1 _does_ have curses, but not a .pc
file for ncursesw. I don't know enough about curses to say whether it
should be that way...