From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: devicetree@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Paul Kocialkowski <contact@paulk.fr>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Alexandre Courbot <gnurou@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: tegra: nyan: Mark all USB ports as host
Date: Tue, 8 Nov 2016 12:07:35 +0100 [thread overview]
Message-ID: <20161108110735.GA13098@ulmo.ba.sec> (raw)
In-Reply-To: <58046fbb-8e19-e629-770a-940a40ca6ef9@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 2245 bytes --]
On Tue, Nov 08, 2016 at 09:47:42AM +0000, Jon Hunter wrote:
>
> On 08/11/16 08:54, Peter De Schrijver wrote:
> > On Mon, Nov 07, 2016 at 02:09:31PM +0000, Jon Hunter wrote:
> >>
> >> On 07/11/16 13:28, Thierry Reding wrote:
> >>> * PGP Signed by an unknown key
> >>>
> >>> On Sun, Sep 18, 2016 at 12:28:52PM +0200, Paul Kocialkowski wrote:
> >>>> Nyan boards only have host USB ports (2 external, 1 internal), there is
> >>>> no OTG-enabled connector.
> >>>>
> >>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >>>> ---
> >>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> Where is this information coming from? I don't have one of the Nyans
> >>> myself, but one of the Tegra132 devices I have, which I think was
> >>> derived from one of the Nyans uses one of the external host ports as
> >>> forced recovery port, for which it would need OTG.
> >>>
> >>> I suspect that the way to get U-Boot onto the Nyans is via tegrarcm?
> >>> In that case I think one of the ports must be OTG.
> >>
> >> It is true that the port on the back on the nyan-big can be used with
> >> recovery mode. I was thinking that this is not a true OTG port as it is
> >> just a 4-pin type A socket and does not have an ID pin. Thinking some
> >> more about this the USB spec does include a "Host Negotiation Protocol
> >> (HNP)" that allows a host and device to swap roles and so keeping it as
> >> OTG seems valid afterall.
> >
> > I don't think the bootrom implements that though. I expect recovery mode
> > to just program the controller in device mode, without performing any
> > negotiation.
>
> I am not talking about the bootrom and I would not expect the bootrom to
> do that. However, the kernel could.
Either way, configuring the controller in device mode is enough to make
the host detect it, otherwise tegrarcm wouldn't work.
From the point of view of the binding I think "otg" is the most accurate
option because we know that the controller can operate in both modes. If
it currently doesn't or how exactly switching modes is done is outside
the scope of this property.
Is everyone okay with just dropping this patch?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: nyan: Mark all USB ports as host
Date: Tue, 8 Nov 2016 12:07:35 +0100 [thread overview]
Message-ID: <20161108110735.GA13098@ulmo.ba.sec> (raw)
In-Reply-To: <58046fbb-8e19-e629-770a-940a40ca6ef9@nvidia.com>
On Tue, Nov 08, 2016 at 09:47:42AM +0000, Jon Hunter wrote:
>
> On 08/11/16 08:54, Peter De Schrijver wrote:
> > On Mon, Nov 07, 2016 at 02:09:31PM +0000, Jon Hunter wrote:
> >>
> >> On 07/11/16 13:28, Thierry Reding wrote:
> >>> * PGP Signed by an unknown key
> >>>
> >>> On Sun, Sep 18, 2016 at 12:28:52PM +0200, Paul Kocialkowski wrote:
> >>>> Nyan boards only have host USB ports (2 external, 1 internal), there is
> >>>> no OTG-enabled connector.
> >>>>
> >>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >>>> ---
> >>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> Where is this information coming from? I don't have one of the Nyans
> >>> myself, but one of the Tegra132 devices I have, which I think was
> >>> derived from one of the Nyans uses one of the external host ports as
> >>> forced recovery port, for which it would need OTG.
> >>>
> >>> I suspect that the way to get U-Boot onto the Nyans is via tegrarcm?
> >>> In that case I think one of the ports must be OTG.
> >>
> >> It is true that the port on the back on the nyan-big can be used with
> >> recovery mode. I was thinking that this is not a true OTG port as it is
> >> just a 4-pin type A socket and does not have an ID pin. Thinking some
> >> more about this the USB spec does include a "Host Negotiation Protocol
> >> (HNP)" that allows a host and device to swap roles and so keeping it as
> >> OTG seems valid afterall.
> >
> > I don't think the bootrom implements that though. I expect recovery mode
> > to just program the controller in device mode, without performing any
> > negotiation.
>
> I am not talking about the bootrom and I would not expect the bootrom to
> do that. However, the kernel could.
Either way, configuring the controller in device mode is enough to make
the host detect it, otherwise tegrarcm wouldn't work.
>From the point of view of the binding I think "otg" is the most accurate
option because we know that the controller can operate in both modes. If
it currently doesn't or how exactly switching modes is done is outside
the scope of this property.
Is everyone okay with just dropping this patch?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161108/a45c4288/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Paul Kocialkowski <contact@paulk.fr>,
devicetree@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Alexandre Courbot <gnurou@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: tegra: nyan: Mark all USB ports as host
Date: Tue, 8 Nov 2016 12:07:35 +0100 [thread overview]
Message-ID: <20161108110735.GA13098@ulmo.ba.sec> (raw)
In-Reply-To: <58046fbb-8e19-e629-770a-940a40ca6ef9@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]
On Tue, Nov 08, 2016 at 09:47:42AM +0000, Jon Hunter wrote:
>
> On 08/11/16 08:54, Peter De Schrijver wrote:
> > On Mon, Nov 07, 2016 at 02:09:31PM +0000, Jon Hunter wrote:
> >>
> >> On 07/11/16 13:28, Thierry Reding wrote:
> >>> * PGP Signed by an unknown key
> >>>
> >>> On Sun, Sep 18, 2016 at 12:28:52PM +0200, Paul Kocialkowski wrote:
> >>>> Nyan boards only have host USB ports (2 external, 1 internal), there is
> >>>> no OTG-enabled connector.
> >>>>
> >>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >>>> ---
> >>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> Where is this information coming from? I don't have one of the Nyans
> >>> myself, but one of the Tegra132 devices I have, which I think was
> >>> derived from one of the Nyans uses one of the external host ports as
> >>> forced recovery port, for which it would need OTG.
> >>>
> >>> I suspect that the way to get U-Boot onto the Nyans is via tegrarcm?
> >>> In that case I think one of the ports must be OTG.
> >>
> >> It is true that the port on the back on the nyan-big can be used with
> >> recovery mode. I was thinking that this is not a true OTG port as it is
> >> just a 4-pin type A socket and does not have an ID pin. Thinking some
> >> more about this the USB spec does include a "Host Negotiation Protocol
> >> (HNP)" that allows a host and device to swap roles and so keeping it as
> >> OTG seems valid afterall.
> >
> > I don't think the bootrom implements that though. I expect recovery mode
> > to just program the controller in device mode, without performing any
> > negotiation.
>
> I am not talking about the bootrom and I would not expect the bootrom to
> do that. However, the kernel could.
Either way, configuring the controller in device mode is enough to make
the host detect it, otherwise tegrarcm wouldn't work.
From the point of view of the binding I think "otg" is the most accurate
option because we know that the controller can operate in both modes. If
it currently doesn't or how exactly switching modes is done is outside
the scope of this property.
Is everyone okay with just dropping this patch?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-08 11:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 10:28 [PATCH] ARM: tegra: nyan: Mark all USB ports as host Paul Kocialkowski
2016-09-18 10:28 ` Paul Kocialkowski
2016-09-18 10:28 ` Paul Kocialkowski
[not found] ` <20160918102852.6593-1-contact-W9ppeneeCTY@public.gmane.org>
2016-09-20 11:51 ` Jon Hunter
2016-09-20 11:51 ` Jon Hunter
2016-09-20 11:51 ` Jon Hunter
2016-11-07 13:28 ` Thierry Reding
2016-11-07 13:28 ` Thierry Reding
[not found] ` <20161107132854.GF12559-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-11-07 14:09 ` Jon Hunter
2016-11-07 14:09 ` Jon Hunter
2016-11-07 14:09 ` Jon Hunter
2016-11-08 8:54 ` Peter De Schrijver
2016-11-08 8:54 ` Peter De Schrijver
2016-11-08 8:54 ` Peter De Schrijver
[not found] ` <20161108085420.GG2478-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2016-11-08 9:09 ` Paul Kocialkowski
2016-11-08 9:09 ` Paul Kocialkowski
2016-11-08 9:09 ` Paul Kocialkowski
2016-11-08 9:47 ` Jon Hunter
2016-11-08 9:47 ` Jon Hunter
2016-11-08 9:47 ` Jon Hunter
2016-11-08 11:07 ` Thierry Reding [this message]
2016-11-08 11:07 ` Thierry Reding
2016-11-08 11:07 ` Thierry Reding
[not found] ` <20161108110735.GA13098-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-11-08 11:09 ` Jon Hunter
2016-11-08 11:09 ` Jon Hunter
2016-11-08 11:09 ` Jon Hunter
2016-11-08 13:02 ` Paul Kocialkowski
2016-11-08 13:02 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108110735.GA13098@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.