From: Will Deacon <will.deacon@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Robert Ritcher <rritcher@cavium.com>,
ard.biesheuvel@linaro.org, marc.zyngier@arm.com,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
Tirumalesh Chalamarla <tchalamarla@cavium.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] arm64: Add hypervisor safe helper for checking constant capabilities
Date: Tue, 8 Nov 2016 18:11:03 +0000 [thread overview]
Message-ID: <20161108181103.GM20591@arm.com> (raw)
In-Reply-To: <1478613381-5718-2-git-send-email-suzuki.poulose@arm.com>
On Tue, Nov 08, 2016 at 01:56:20PM +0000, Suzuki K Poulose wrote:
> The hypervisor may not have full access to the kernel data structures
> and hence cannot safely use cpus_have_cap() helper for checking the
> system capability. Add a safe helper for hypervisors to check a constant
> system capability, which *doesn't* fall back to checking the bitmap
> maintained by the kernel. With this, make the cpus_have_cap() only
> check the bitmask and force constant cap checks to use the new API
> for quicker checks.
>
> Cc: Robert Ritcher <rritcher@cavium.com>
> Cc: Tirumalesh Chalamarla <tchalamarla@cavium.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> arch/arm64/include/asm/cpufeature.h | 19 ++++++++++++-------
> arch/arm64/kernel/cpufeature.c | 2 +-
> arch/arm64/kernel/process.c | 2 +-
> drivers/irqchip/irq-gic-v3.c | 13 +------------
It might be worth having the GIC changes as a separate patch, but either
way:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] arm64: Add hypervisor safe helper for checking constant capabilities
Date: Tue, 8 Nov 2016 18:11:03 +0000 [thread overview]
Message-ID: <20161108181103.GM20591@arm.com> (raw)
In-Reply-To: <1478613381-5718-2-git-send-email-suzuki.poulose@arm.com>
On Tue, Nov 08, 2016 at 01:56:20PM +0000, Suzuki K Poulose wrote:
> The hypervisor may not have full access to the kernel data structures
> and hence cannot safely use cpus_have_cap() helper for checking the
> system capability. Add a safe helper for hypervisors to check a constant
> system capability, which *doesn't* fall back to checking the bitmap
> maintained by the kernel. With this, make the cpus_have_cap() only
> check the bitmask and force constant cap checks to use the new API
> for quicker checks.
>
> Cc: Robert Ritcher <rritcher@cavium.com>
> Cc: Tirumalesh Chalamarla <tchalamarla@cavium.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> arch/arm64/include/asm/cpufeature.h | 19 ++++++++++++-------
> arch/arm64/kernel/cpufeature.c | 2 +-
> arch/arm64/kernel/process.c | 2 +-
> drivers/irqchip/irq-gic-v3.c | 13 +------------
It might be worth having the GIC changes as a separate patch, but either
way:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org,
catalin.marinas@arm.com, mark.rutland@arm.com,
marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu,
Robert Ritcher <rritcher@cavium.com>,
Tirumalesh Chalamarla <tchalamarla@cavium.com>
Subject: Re: [PATCH v3 1/2] arm64: Add hypervisor safe helper for checking constant capabilities
Date: Tue, 8 Nov 2016 18:11:03 +0000 [thread overview]
Message-ID: <20161108181103.GM20591@arm.com> (raw)
In-Reply-To: <1478613381-5718-2-git-send-email-suzuki.poulose@arm.com>
On Tue, Nov 08, 2016 at 01:56:20PM +0000, Suzuki K Poulose wrote:
> The hypervisor may not have full access to the kernel data structures
> and hence cannot safely use cpus_have_cap() helper for checking the
> system capability. Add a safe helper for hypervisors to check a constant
> system capability, which *doesn't* fall back to checking the bitmap
> maintained by the kernel. With this, make the cpus_have_cap() only
> check the bitmask and force constant cap checks to use the new API
> for quicker checks.
>
> Cc: Robert Ritcher <rritcher@cavium.com>
> Cc: Tirumalesh Chalamarla <tchalamarla@cavium.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> arch/arm64/include/asm/cpufeature.h | 19 ++++++++++++-------
> arch/arm64/kernel/cpufeature.c | 2 +-
> arch/arm64/kernel/process.c | 2 +-
> drivers/irqchip/irq-gic-v3.c | 13 +------------
It might be worth having the GIC changes as a separate patch, but either
way:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2016-11-08 18:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:56 [PATCH v3 0/2] arm64: Support systems without FP/ASIMD Suzuki K Poulose
2016-11-08 13:56 ` Suzuki K Poulose
2016-11-08 13:56 ` Suzuki K Poulose
2016-11-08 13:56 ` [PATCH v3 1/2] arm64: Add hypervisor safe helper for checking constant capabilities Suzuki K Poulose
2016-11-08 13:56 ` Suzuki K Poulose
2016-11-08 18:11 ` Will Deacon [this message]
2016-11-08 18:11 ` Will Deacon
2016-11-08 18:11 ` Will Deacon
2016-11-08 13:56 ` [PATCH v3 2/2] arm64: Support systems without FP/ASIMD Suzuki K Poulose
2016-11-08 13:56 ` Suzuki K Poulose
2016-11-08 13:56 ` Suzuki K Poulose
2016-11-14 11:48 ` Catalin Marinas
2016-11-14 11:48 ` Catalin Marinas
2016-11-14 11:48 ` Catalin Marinas
2016-11-15 10:42 ` Suzuki K Poulose
2016-11-15 10:42 ` Suzuki K Poulose
2016-11-15 10:42 ` Suzuki K Poulose
2016-11-11 13:41 ` [PATCH v3 0/2] " Marc Zyngier
2016-11-11 13:41 ` Marc Zyngier
2016-11-14 11:08 ` Catalin Marinas
2016-11-14 11:08 ` Catalin Marinas
2016-11-14 11:08 ` Catalin Marinas
2016-11-16 18:11 ` Catalin Marinas
2016-11-16 18:11 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108181103.GM20591@arm.com \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rritcher@cavium.com \
--cc=suzuki.poulose@arm.com \
--cc=tchalamarla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.