All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/3] btrfs-progs: send: fix handling of -c option
@ 2016-10-19  2:35 Tsutomu Itoh
  2016-11-02 12:22 ` David Sterba
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Tsutomu Itoh @ 2016-10-19  2:35 UTC (permalink / raw)
  To: linux-btrfs

When two or more -c options are specified, cannot find a suitable
parent. So, output stream is bigger than correct one.

[before]
# btrfs send -f /tmp/data1 -c Snap0 -c ../SnapX Snap[12] ../SnapY
At subvol Snap1
At subvol Snap2
At subvol ../SnapY
# ls -l /tmp/data1
-rw------- 1 root root 3153 Oct 19 10:37 /tmp/data1
#

[after]
# btrfs send -f /tmp/data1 -c Snap0 -c ../SnapX Snap[12] ../SnapY
At subvol Snap1
At subvol Snap2
At subvol ../SnapY
# ls -l /tmp/data1
-rw------- 1 root root 1492 Oct 19 10:39 /tmp/data1
#

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
---
 cmds-send.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/cmds-send.c b/cmds-send.c
index 2a8a697..b93a667 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -651,6 +651,18 @@ int cmd_send(int argc, char **argv)
 		}
 
 		if (!full_send && root_id) {
+			ret = init_root_path(&send, subvol);
+			if (ret < 0)
+				goto out;
+
+			ret = get_root_id(&send,
+				subvol_strip_mountpoint(send.root_path, subvol),
+				&root_id);
+			if (ret < 0) {
+				error("cannot resolve rootid for %s", subvol);
+				goto out;
+			}
+
 			ret = find_good_parent(&send, root_id, &parent_root_id);
 			if (ret < 0) {
 				error("parent determination failed for %lld",
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-11-09 10:49 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19  2:35 [PATCH 3/3] btrfs-progs: send: fix handling of -c option Tsutomu Itoh
2016-11-02 12:22 ` David Sterba
2016-11-04  2:10   ` Tsutomu Itoh
2016-11-04  8:33 ` [PATCH v2 " Tsutomu Itoh
2016-11-07 15:57   ` David Sterba
2016-11-04  8:35 ` [PATCH] btrfs-progs: send-test: add checking of clone-src option Tsutomu Itoh
2016-11-07 15:16   ` David Sterba
2016-11-09  1:25   ` [PATCH v2] " Tsutomu Itoh
2016-11-09  1:39     ` Qu Wenruo
2016-11-09  1:57       ` Tsutomu Itoh
2016-11-09  4:44   ` [PATCH v3] " Tsutomu Itoh
2016-11-09 10:49     ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.