Re: Question about 2 gp8psk patches I noticed, and possible bug.

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Wed, 9 Nov 2016 07:49:43 -0800
VDR User <user.vdr@gmail.com> escreveu:

> $ gdb /usr/src/linux/vmlinux
> GNU gdb (Debian 7.11.1-2) 7.11.1
> ...
> Reading symbols from /usr/src/linux/vmlinux...done.
> (gdb) l *module_put+0x67
> 0xc10a4b87 is in module_put (kernel/module.c:1108).
> 1103            int ret;
> 1104
> 1105            if (module) {
> 1106                    preempt_disable();
> 1107                    ret = atomic_dec_if_positive(&module->refcnt);
> 1108                    WARN_ON(ret < 0);       /* Failed to put refcount */
> 1109                    trace_module_put(module, _RET_IP_);
> 1110                    preempt_enable();
> 1111            }
> 1112    }

OK, I guess we've made progress. Please try the enclosed patch.

Regards,
Mauro

[media] gp8psk: Fix DVB frontend attach

it should be calling module_get() at attach, as otherwise
module_put() will crash.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>


Thanks,
Mauro