Re: Question about 2 gp8psk patches I noticed, and possible bug.

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Wed, 9 Nov 2016 17:03:52 -0800
VDR User <user.vdr@gmail.com> escreveu:

> >> (gdb) l *module_put+0x67
> >> 0xc10a4b87 is in module_put (kernel/module.c:1108).
> >> 1103            int ret;
> >> 1104
> >> 1105            if (module) {
> >> 1106                    preempt_disable();
> >> 1107                    ret = atomic_dec_if_positive(&module->refcnt);
> >> 1108                    WARN_ON(ret < 0);       /* Failed to put refcount */
> >> 1109                    trace_module_put(module, _RET_IP_);
> >> 1110                    preempt_enable();
> >> 1111            }
> >> 1112    }  
> >
> > OK, I guess we've made progress. Please try the enclosed patch.
> >
> > Regards,
> > Mauro
> >
> > [media] gp8psk: Fix DVB frontend attach
> >
> > it should be calling module_get() at attach, as otherwise
> > module_put() will crash.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>  
> 
> I think you forgot the patch. :)

commit 0c979a12309af49894bb1dc60e747c3cd53fa888
Author: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Date:   Wed Nov 9 15:33:17 2016 -0200

    [media] gp8psk: Fix DVB frontend attach
    
    it should be calling module_get() at attach, as otherwise
    module_put() will crash.
    
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/usb/dvb-usb/gp8psk.c b/drivers/media/usb/dvb-usb/gp8psk.c
index cede0d8b0f8a..24eb6c6c8e24 100644
--- a/drivers/media/usb/dvb-usb/gp8psk.c
+++ b/drivers/media/usb/dvb-usb/gp8psk.c
@@ -250,7 +250,7 @@ static int gp8psk_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)
 
 static int gp8psk_frontend_attach(struct dvb_usb_adapter *adap)
 {
-	adap->fe_adap[0].fe = gp8psk_fe_attach(adap->dev);
+	adap->fe_adap[0].fe = dvb_attach(gp8psk_fe_attach, adap->dev);
 	return 0;
 }