From: Christoph Hellwig <hch@infradead.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Dan J. Williams" <dan.j.williams@intel.com>,
linux-nvdimm@ml01.01.org, linux-block@vger.kernel.org
Subject: Re: [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events
Date: Wed, 9 Nov 2016 11:34:41 -0800 [thread overview]
Message-ID: <20161109193441.GA17343@infradead.org> (raw)
In-Reply-To: <x49mvh8o3fx.fsf@segfault.boston.devel.redhat.com>
On Wed, Nov 09, 2016 at 02:31:30PM -0500, Jeff Moyer wrote:
> bio_endio is still called for request_fn drivers, so you'd see two
> completion events for those drivers if we did that, no?
We'd see the bio_endio trace in addition to the request one, but
they are at different granularities. Similar to how on the issue side
we have trace_block_bio_queue for each bio, and trace_block_rq_issue
for each request.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Jeff Moyer <jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events
Date: Wed, 9 Nov 2016 11:34:41 -0800 [thread overview]
Message-ID: <20161109193441.GA17343@infradead.org> (raw)
In-Reply-To: <x49mvh8o3fx.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
On Wed, Nov 09, 2016 at 02:31:30PM -0500, Jeff Moyer wrote:
> bio_endio is still called for request_fn drivers, so you'd see two
> completion events for those drivers if we did that, no?
We'd see the bio_endio trace in addition to the request one, but
they are at different granularities. Similar to how on the issue side
we have trace_block_bio_queue for each bio, and trace_block_rq_issue
for each request.
next prev parent reply other threads:[~2016-11-09 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:08 [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events Jeff Moyer
2016-11-09 19:08 ` Jeff Moyer
2016-11-09 19:17 ` Christoph Hellwig
2016-11-09 19:17 ` Christoph Hellwig
2016-11-09 19:31 ` Jeff Moyer
2016-11-09 19:34 ` Christoph Hellwig [this message]
2016-11-09 19:34 ` Christoph Hellwig
2016-11-09 19:43 ` Jeff Moyer
2016-11-10 19:33 ` Christoph Hellwig
2016-11-11 14:55 ` Jeff Moyer
2016-11-16 4:56 ` Ross Zwisler
2016-11-16 14:06 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109193441.GA17343@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.