[PATCH] clk: gate: fix coding style

[PATCH] clk: gate: fix coding style

[Uwe Kleine-König]

The : of the ?: operator should have a leading space.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

I always wonder if I should send such patches or if they hurt more than
they are worth. *shrug* ignore at will.

Best regards
Uwe

 drivers/clk/clk-gate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-gate.c b/drivers/clk/clk-gate.c
index 4e691e35483a..59e302538d23 100644
--- a/drivers/clk/clk-gate.c
+++ b/drivers/clk/clk-gate.c
@@ -145,7 +145,7 @@ struct clk_hw *clk_hw_register_gate(struct device *dev, const char *name,
 	init.name = name;
 	init.ops = &clk_gate_ops;
 	init.flags = flags | CLK_IS_BASIC;
-	init.parent_names = (parent_name ? &parent_name: NULL);
+	init.parent_names = (parent_name ? &parent_name : NULL);
 	init.num_parents = (parent_name ? 1 : 0);
 
 	/* struct clk_gate assignments */
-- 
2.10.1

Re: [PATCH] clk: gate: fix coding style

[Masahiro Yamada]

2016-11-09 20:00 GMT+09:00 Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutron=
ix.de>:
> The : of the ?: operator should have a leading space.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I always wonder if I should send such patches or if they hurt more than
> they are worth. *shrug* ignore at will.
>
> Best regards
> Uwe
>
>  drivers/clk/clk-gate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-gate.c b/drivers/clk/clk-gate.c
> index 4e691e35483a..59e302538d23 100644
> --- a/drivers/clk/clk-gate.c
> +++ b/drivers/clk/clk-gate.c
> @@ -145,7 +145,7 @@ struct clk_hw *clk_hw_register_gate(struct device *de=
v, const char *name,
>         init.name =3D name;
>         init.ops =3D &clk_gate_ops;
>         init.flags =3D flags | CLK_IS_BASIC;
> -       init.parent_names =3D (parent_name ? &parent_name: NULL);
> +       init.parent_names =3D (parent_name ? &parent_name : NULL);
>         init.num_parents =3D (parent_name ? 1 : 0);
>

Do we need the parentheses?


--=20
Best Regards
Masahiro Yamada

Re: [PATCH] clk: gate: fix coding style

[Uwe Kleine-König]

Hello,

On Wed, Nov 09, 2016 at 08:25:22PM +0900, Masahiro Yamada wrote:
> 2016-11-09 20:00 GMT+09:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> >         init.flags = flags | CLK_IS_BASIC;
> > -       init.parent_names = (parent_name ? &parent_name: NULL);
> > +       init.parent_names = (parent_name ? &parent_name : NULL);
> >         init.num_parents = (parent_name ? 1 : 0);
> 
> Do we need the parentheses?

	init.num_parents = parent_name ? 1 : 0;

has the same semantics. I didn't remove the parentheses because they
might make it easier to understand what happens if you don't have the
operator precedence table at hand. But actually I don't care. If they
should be dropped and nobody else volunteers, I can resend with the
parentheses removed.

Best regards,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] clk: gate: fix coding style

[Stephen Boyd]

On 11/09, Uwe Kleine-König wrote:
> The : of the ?: operator should have a leading space.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I always wonder if I should send such patches or if they hurt more than
> they are worth. *shrug* ignore at will.
> 

Applied to clk-next plus got rid of the parenthesis in the area.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project