Re: [Qemu-devel] [PATCHv2 0/3] Allow ISA to be disabled on some platforms

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Wed, Nov 09, 2016 at 11:22:01PM +1100, David Gibson wrote:
> This is a rebase and revision of a series I wrote quite some time ago.
> This makes some cleanups that are a start on allowing ISA to be
> compiled out for platforms which don't use it.
> 
> Unfortunately, a lot of the pieces here don't have a clear maintainer.
> So, I'm hoping to get some Acked-bys from the maintainers of the
> affected targets, then I intend to send a pull request direct to Peter.

Looks good to me:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Best regards,
Edgar

> 
> Notes:
>   * Patch 3/3 triggers a style warning, but that's just because I'm
>     moving a C++ // comment verbatim from one file to another
> 
> Changes since v1:
>   * Fixed some silly compile errors in 3/3 exposed by some
>     changes in other headers
> 
> David Gibson (3):
>   Split serial-isa into its own config option
>   Allow ISA bus to be configured out
>   Split ISA and sysbus versions of m48t59 device
> 
>  default-configs/alpha-softmmu.mak       |   1 +
>  default-configs/arm-softmmu.mak         |   1 +
>  default-configs/i386-softmmu.mak        |   1 +
>  default-configs/mips-softmmu-common.mak |   1 +
>  default-configs/moxie-softmmu.mak       |   2 +
>  default-configs/pci.mak                 |   3 +
>  default-configs/ppc-softmmu.mak         |   1 +
>  default-configs/ppc64-softmmu.mak       |   1 +
>  default-configs/ppcemb-softmmu.mak      |   1 +
>  default-configs/sh4-softmmu.mak         |   1 +
>  default-configs/sh4eb-softmmu.mak       |   1 +
>  default-configs/sparc-softmmu.mak       |   1 +
>  default-configs/sparc64-softmmu.mak     |   1 +
>  default-configs/unicore32-softmmu.mak   |   1 +
>  default-configs/x86_64-softmmu.mak      |   1 +
>  hw/char/Makefile.objs                   |   3 +-
>  hw/isa/Makefile.objs                    |   2 +-
>  hw/timer/Makefile.objs                  |   3 +
>  hw/timer/m48t59-internal.h              |  82 ++++++++++++
>  hw/timer/m48t59-isa.c                   | 181 +++++++++++++++++++++++++
>  hw/timer/m48t59.c                       | 228 +++-----------------------------
>  21 files changed, 305 insertions(+), 212 deletions(-)
>  create mode 100644 hw/timer/m48t59-internal.h
>  create mode 100644 hw/timer/m48t59-isa.c
> 
> -- 
> 2.7.4
>