* [patch] staging/lustre/osc: indent an if statement
@ 2016-11-10 12:50 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-11-10 12:50 UTC (permalink / raw)
To: lustre-devel
We accidentally removed a tab here. Let's add it back, and some curly
braces as well since this is a muti-line indent.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c b/drivers/staging/lustre/lustre/osc/osc_lock.c
index e337e87..bfc8d38 100644
--- a/drivers/staging/lustre/lustre/osc/osc_lock.c
+++ b/drivers/staging/lustre/lustre/osc/osc_lock.c
@@ -607,9 +607,11 @@ static int osc_ldlm_glimpse_ast(struct ldlm_lock *dlmlock, void *data)
lvb = req_capsule_server_get(cap, &RMF_DLM_LVB);
result = cl_object_glimpse(env, obj, lvb);
}
- if (!exp_connect_lvb_type(req->rq_export))
- req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
- sizeof(struct ost_lvb_v1), RCL_SERVER);
+ if (!exp_connect_lvb_type(req->rq_export)) {
+ req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
+ sizeof(struct ost_lvb_v1),
+ RCL_SERVER);
+ }
cl_object_put(env, obj);
} else {
/*
^ permalink raw reply related [flat|nested] 4+ messages in thread* [lustre-devel] [patch] staging/lustre/osc: indent an if statement
@ 2016-11-10 12:50 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-11-10 12:50 UTC (permalink / raw)
To: lustre-devel
We accidentally removed a tab here. Let's add it back, and some curly
braces as well since this is a muti-line indent.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c b/drivers/staging/lustre/lustre/osc/osc_lock.c
index e337e87..bfc8d38 100644
--- a/drivers/staging/lustre/lustre/osc/osc_lock.c
+++ b/drivers/staging/lustre/lustre/osc/osc_lock.c
@@ -607,9 +607,11 @@ static int osc_ldlm_glimpse_ast(struct ldlm_lock *dlmlock, void *data)
lvb = req_capsule_server_get(cap, &RMF_DLM_LVB);
result = cl_object_glimpse(env, obj, lvb);
}
- if (!exp_connect_lvb_type(req->rq_export))
- req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
- sizeof(struct ost_lvb_v1), RCL_SERVER);
+ if (!exp_connect_lvb_type(req->rq_export)) {
+ req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
+ sizeof(struct ost_lvb_v1),
+ RCL_SERVER);
+ }
cl_object_put(env, obj);
} else {
/*
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] staging/lustre/osc: indent an if statement
2016-11-10 12:50 ` [lustre-devel] " Dan Carpenter
@ 2016-11-10 17:49 ` James Simmons
-1 siblings, 0 replies; 4+ messages in thread
From: James Simmons @ 2016-11-10 17:49 UTC (permalink / raw)
To: lustre-devel
> We accidentally removed a tab here. Let's add it back, and some curly
> braces as well since this is a muti-line indent.
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c b/drivers/staging/lustre/lustre/osc/osc_lock.c
> index e337e87..bfc8d38 100644
> --- a/drivers/staging/lustre/lustre/osc/osc_lock.c
> +++ b/drivers/staging/lustre/lustre/osc/osc_lock.c
> @@ -607,9 +607,11 @@ static int osc_ldlm_glimpse_ast(struct ldlm_lock *dlmlock, void *data)
> lvb = req_capsule_server_get(cap, &RMF_DLM_LVB);
> result = cl_object_glimpse(env, obj, lvb);
> }
> - if (!exp_connect_lvb_type(req->rq_export))
> - req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
> - sizeof(struct ost_lvb_v1), RCL_SERVER);
> + if (!exp_connect_lvb_type(req->rq_export)) {
> + req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
> + sizeof(struct ost_lvb_v1),
> + RCL_SERVER);
> + }
> cl_object_put(env, obj);
> } else {
> /*
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [lustre-devel] [patch] staging/lustre/osc: indent an if statement
@ 2016-11-10 17:49 ` James Simmons
0 siblings, 0 replies; 4+ messages in thread
From: James Simmons @ 2016-11-10 17:49 UTC (permalink / raw)
To: lustre-devel
> We accidentally removed a tab here. Let's add it back, and some curly
> braces as well since this is a muti-line indent.
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c b/drivers/staging/lustre/lustre/osc/osc_lock.c
> index e337e87..bfc8d38 100644
> --- a/drivers/staging/lustre/lustre/osc/osc_lock.c
> +++ b/drivers/staging/lustre/lustre/osc/osc_lock.c
> @@ -607,9 +607,11 @@ static int osc_ldlm_glimpse_ast(struct ldlm_lock *dlmlock, void *data)
> lvb = req_capsule_server_get(cap, &RMF_DLM_LVB);
> result = cl_object_glimpse(env, obj, lvb);
> }
> - if (!exp_connect_lvb_type(req->rq_export))
> - req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
> - sizeof(struct ost_lvb_v1), RCL_SERVER);
> + if (!exp_connect_lvb_type(req->rq_export)) {
> + req_capsule_shrink(&req->rq_pill, &RMF_DLM_LVB,
> + sizeof(struct ost_lvb_v1),
> + RCL_SERVER);
> + }
> cl_object_put(env, obj);
> } else {
> /*
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-10 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 12:50 [patch] staging/lustre/osc: indent an if statement Dan Carpenter
2016-11-10 12:50 ` [lustre-devel] " Dan Carpenter
2016-11-10 17:49 ` James Simmons
2016-11-10 17:49 ` [lustre-devel] " James Simmons
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.