All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Sascha Sommer" <saschasommer@freenet.de>,
	"Johan Hovold" <johan@kernel.org>,
	"Sonic Zhang" <sonic.zhang@analog.com>,
	devel@driverdev.osuosl.org,
	"Russell King" <linux@armlinux.org.uk>,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Pierre Ossman" <pierre@ossman.eu>,
	"Harald Welte" <HaraldWelte@viatech.com>,
	"Alex Dubov" <oakad@yahoo.com>,
	adi-buildroot-devel@lists.sourceforge.net,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	linux-mediatek@lists.infradead.org,
	"Ben Dooks" <ben-linux@fluff.org>,
	"Tony Olech" <tony.olech@elandigitalsystems.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Nicolas Pitre" <nico@fluxnic.net>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()
Date: Thu, 10 Nov 2016 14:35:59 +0100	[thread overview]
Message-ID: <20161110133559.GA10191@kroah.com> (raw)
In-Reply-To: <1478784263-18777-1-git-send-email-yamada.masahiro@socionext.com>

On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
> 
> sdhci_alloc_host() returns an error pointer when it fails.
> but mmc_alloc_host() cannot.
> 
> This series allow to propagate a proper error code
> when host-allocation fails.

Why?  What can we really do about the error except give up?  Why does
having a explicit error value make any difference to the caller, they
can't do anything different, right?

I suggest just leaving it as-is, it's simple, and you don't have to mess
with PTR_ERR() anywhere.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()
Date: Thu, 10 Nov 2016 14:35:59 +0100	[thread overview]
Message-ID: <20161110133559.GA10191@kroah.com> (raw)
In-Reply-To: <1478784263-18777-1-git-send-email-yamada.masahiro@socionext.com>

On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
> 
> sdhci_alloc_host() returns an error pointer when it fails.
> but mmc_alloc_host() cannot.
> 
> This series allow to propagate a proper error code
> when host-allocation fails.

Why?  What can we really do about the error except give up?  Why does
having a explicit error value make any difference to the caller, they
can't do anything different, right?

I suggest just leaving it as-is, it's simple, and you don't have to mess
with PTR_ERR() anywhere.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc@vger.kernel.org,
	"Jarkko Lavinen" <jarkko.lavinen@nokia.com>,
	"Rui Miguel Silva" <rmfrfs@gmail.com>,
	linux-kernel@vger.kernel.org, "Nicolas Pitre" <nico@fluxnic.net>,
	devel@driverdev.osuosl.org,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	"Pierre Ossman" <pierre@ossman.eu>,
	"Johan Hovold" <johan@kernel.org>, "Alex Dubov" <oakad@yahoo.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Tony Olech" <tony.olech@elandigitalsystems.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Sascha Sommer" <saschasommer@freenet.de>,
	adi-buildroot-devel@lists.sourceforge.net,
	"Ben Dooks" <ben-linux@fluff.org>,
	"Alex Elder" <elder@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Tony Prisk" <linux@prisktech.co.nz>,
	linux-omap@vger.kernel.org,
	"Manuel Lauss" <manuel.lauss@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Ludovic Desroches" <ludovic.desroches@atmel.com>,
	linux-usb@vger.kernel.org, "Bruce Chang" <brucechang@via.com.tw>,
	"Sonic Zhang" <sonic.zhang@analog.com>,
	"Harald Welte" <HaraldWelte@viatech.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()
Date: Thu, 10 Nov 2016 14:35:59 +0100	[thread overview]
Message-ID: <20161110133559.GA10191@kroah.com> (raw)
In-Reply-To: <1478784263-18777-1-git-send-email-yamada.masahiro@socionext.com>

On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
> 
> sdhci_alloc_host() returns an error pointer when it fails.
> but mmc_alloc_host() cannot.
> 
> This series allow to propagate a proper error code
> when host-allocation fails.

Why?  What can we really do about the error except give up?  Why does
having a explicit error value make any difference to the caller, they
can't do anything different, right?

I suggest just leaving it as-is, it's simple, and you don't have to mess
with PTR_ERR() anywhere.

thanks,

greg k-h

  parent reply	other threads:[~2016-11-10 13:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10 13:24 [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc() Masahiro Yamada
2016-11-10 13:24 ` Masahiro Yamada
2016-11-10 13:24 ` Masahiro Yamada
     [not found] ` <1478784263-18777-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2016-11-10 13:24   ` [PATCH 1/2] mmc: allow mmc_alloc_host() to return proper error code Masahiro Yamada
2016-11-10 13:24     ` Masahiro Yamada
2016-11-10 13:24     ` Masahiro Yamada
2016-11-10 13:24 ` [PATCH 2/2] mmc: tmio: allow tmio_mmc_host_alloc() " Masahiro Yamada
2016-11-10 13:35 ` Greg Kroah-Hartman [this message]
2016-11-10 13:35   ` [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc() Greg Kroah-Hartman
2016-11-10 13:35   ` Greg Kroah-Hartman
2016-11-11  3:19   ` Masahiro Yamada
2016-11-11  3:19     ` Masahiro Yamada
2016-11-11  3:19     ` Masahiro Yamada
2016-11-13 10:58     ` Greg Kroah-Hartman
2016-11-13 10:58       ` Greg Kroah-Hartman
2016-11-13 10:58       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161110133559.GA10191@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=HaraldWelte@viatech.com \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=adrian.hunter@intel.com \
    --cc=ben-linux@fluff.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jh80.chung@samsung.com \
    --cc=johan@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=matthias.bgg@gmail.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=nico@fluxnic.net \
    --cc=oakad@yahoo.com \
    --cc=pierre@ossman.eu \
    --cc=saschasommer@freenet.de \
    --cc=sonic.zhang@analog.com \
    --cc=tony.olech@elandigitalsystems.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.