* [PATCH] staging: rtl8192e: Fix checkpatch warnings
@ 2016-11-10 16:02 Y M Patil
2016-11-10 16:09 ` Greg KH
2016-11-10 16:09 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Y M Patil @ 2016-11-10 16:02 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Y M Patil
This patch fixes block comment coding style warnings.
And added new line after variable declaration.
Signed-off-by: Y M Patil <goudapatilk@gmail.com>
---
drivers/staging/rtl8192e/dot11d.c | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 3 ++-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib_rx.c | 4 ++--
drivers/staging/rtl8192e/rtllib_wx.c | 2 +-
5 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
index 25725b1..56c8950 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -11,7 +11,7 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ *******************************************************************************/
#include "dot11d.h"
struct channel_list {
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index c7fd1b1..cdd3df4 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -11,7 +11,8 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ ********************************************************************************/
+
#include <asm/byteorder.h>
#include <asm/unaligned.h>
#include <linux/etherdevice.h>
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index dd9c0c8..41a77df 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -11,7 +11,7 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ *******************************************************************************/
#include "rtllib.h"
#include "rtl819x_HT.h"
u8 MCS_FILTER_ALL[16] = {
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index d67e3f3..57a16ae 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -916,7 +916,7 @@ static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee,
rx_stats->bContainHTC = true;
}
- if (RTLLIB_QOS_HAS_SEQ(fc))
+ if (RTLLIB_QOS_HAS_SEQ(fc))
rx_stats->bIsQosData = true;
return hdrlen;
@@ -1201,6 +1201,7 @@ static int rtllib_rx_decrypt(struct rtllib_device *ieee, struct sk_buff *skb,
if (crypt && !(fc & RTLLIB_FCTL_WEP) &&
rtllib_is_eapol_frame(ieee, skb, hdrlen)) {
struct eapol *eap = (struct eapol *)(skb->data + 24);
+
netdev_dbg(ieee->dev, "RX: IEEE 802.1X EAPOL frame: %s\n",
eap_get_type(eap->type));
}
@@ -1223,7 +1224,6 @@ static void rtllib_rx_check_leave_lps(struct rtllib_device *ieee, u8 unicast,
u8 nr_subframes)
{
if (unicast) {
-
if (ieee->state == RTLLIB_LINKED) {
if (((ieee->LinkDetectInfo.NumRxUnicastOkInPeriod +
ieee->LinkDetectInfo.NumTxOkInPeriod) > 8) ||
diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index b1500ee..1102135 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -668,7 +668,7 @@ int rtllib_wx_set_encode_ext(struct rtllib_device *ieee,
if (ieee->set_security)
ieee->set_security(ieee->dev, &sec);
- if (ieee->reset_on_keychange &&
+ if (ieee->reset_on_keychange &&
ieee->iw_mode != IW_MODE_INFRA &&
ieee->reset_port && ieee->reset_port(dev)) {
netdev_dbg(ieee->dev, "Port reset failed\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8192e: Fix checkpatch warnings
2016-11-10 16:02 [PATCH] staging: rtl8192e: Fix checkpatch warnings Y M Patil
@ 2016-11-10 16:09 ` Greg KH
2016-11-10 16:09 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-11-10 16:09 UTC (permalink / raw)
To: Y M Patil; +Cc: devel, linux-kernel
On Thu, Nov 10, 2016 at 09:32:30PM +0530, Y M Patil wrote:
> This patch fixes block comment coding style warnings.
> And added new line after variable declaration.
Please only do one-thing-per-patch. If you have to say "And", that's a
huge hint that this should be broken up into multiple patches. Please
do so here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix checkpatch warnings
2016-11-10 16:02 [PATCH] staging: rtl8192e: Fix checkpatch warnings Y M Patil
2016-11-10 16:09 ` Greg KH
@ 2016-11-10 16:09 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-11-10 16:09 UTC (permalink / raw)
To: Y M Patil; +Cc: devel, linux-kernel
On Thu, Nov 10, 2016 at 09:32:30PM +0530, Y M Patil wrote:
> This patch fixes block comment coding style warnings.
> And added new line after variable declaration.
>
> Signed-off-by: Y M Patil <goudapatilk@gmail.com>
Also, I need a "full" name please...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: rtl8192e: Fix checkpatch warnings
@ 2016-11-10 17:01 Yamanappagouda Patil
2016-11-14 14:50 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Yamanappagouda Patil @ 2016-11-10 17:01 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Yamanappagouda Patil
Fixed checkpatch.pl warning on Block comments.
Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com>
---
drivers/staging/rtl8192e/dot11d.c | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
index 25725b1..56c8950 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -11,7 +11,7 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ *******************************************************************************/
#include "dot11d.h"
struct channel_list {
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index c7fd1b1..6cf9d31 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -11,7 +11,7 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ *******************************************************************************/
#include <asm/byteorder.h>
#include <asm/unaligned.h>
#include <linux/etherdevice.h>
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index dd9c0c8..41a77df 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -11,7 +11,7 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ *******************************************************************************/
#include "rtllib.h"
#include "rtl819x_HT.h"
u8 MCS_FILTER_ALL[16] = {
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index a966a8e..48bbd9e 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -11,7 +11,7 @@
*
* Contact Information:
* wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ ******************************************************************************/
#include "rtllib.h"
#include <linux/etherdevice.h>
#include "rtl819x_TS.h"
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8192e: Fix checkpatch warnings
2016-11-10 17:01 Yamanappagouda Patil
@ 2016-11-14 14:50 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-11-14 14:50 UTC (permalink / raw)
To: Yamanappagouda Patil; +Cc: devel, linux-kernel
On Thu, Nov 10, 2016 at 10:31:32PM +0530, Yamanappagouda Patil wrote:
> Fixed checkpatch.pl warning on Block comments.
>
> Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com>
> ---
Both of your patches did different things, yet you had the same subject
line :(
Please fix them up and resend with unique subjects (hint, adding ".pl"
doesn't make it unique...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-14 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 16:02 [PATCH] staging: rtl8192e: Fix checkpatch warnings Y M Patil
2016-11-10 16:09 ` Greg KH
2016-11-10 16:09 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-11-10 17:01 Yamanappagouda Patil
2016-11-14 14:50 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.