From: Pavel Machek <pavel@ucw.cz>
To: Chen Yu <yu.c.chen@intel.com>
Cc: linux-pm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
John Stultz <john.stultz@linaro.org>,
Xunlei Pang <xlpang@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Len Brown <lenb@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled
Date: Thu, 10 Nov 2016 17:32:25 +0100 [thread overview]
Message-ID: <20161110163225.GB28832@amd> (raw)
In-Reply-To: <1478753753-24650-1-git-send-email-yu.c.chen@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
On Thu 2016-11-10 12:55:53, Chen Yu wrote:
> Previously we encountered some memory overflow issues due to
> the bogus sleep time brought by inconsistent rtc, which is
> triggered when pm_trace is enabled, and we have fixed it
> in recent kernel. However it's improper in the first place
> to call __timekeeping_inject_sleeptime() in case that pm_trace
> is enabled simply because that "hash" time value will wreckage
> the timekeeping subsystem.
>
> This patch is originally written by Thomas, which would bypass
> the bogus rtc interval when pm_trace is enabled.
> Meanwhile, if system succeed to resume back with pm_trace set, the
> users are warned to adjust the bogus rtc either by ntp-date or rdate,
> by resetting pm_trace_rtc_abused to false, otherwise above tools might
> not work as expected.
>
> Originally-from: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Xunlei Pang <xlpang@redhat.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Chen Yu <yu.c.chen@intel.com>
Cc: linux-pm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
John Stultz <john.stultz@linaro.org>,
Xunlei Pang <xlpang@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Len Brown <lenb@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [rtc-linux] Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled
Date: Thu, 10 Nov 2016 17:32:25 +0100 [thread overview]
Message-ID: <20161110163225.GB28832@amd> (raw)
In-Reply-To: <1478753753-24650-1-git-send-email-yu.c.chen@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1790 bytes --]
On Thu 2016-11-10 12:55:53, Chen Yu wrote:
> Previously we encountered some memory overflow issues due to
> the bogus sleep time brought by inconsistent rtc, which is
> triggered when pm_trace is enabled, and we have fixed it
> in recent kernel. However it's improper in the first place
> to call __timekeeping_inject_sleeptime() in case that pm_trace
> is enabled simply because that "hash" time value will wreckage
> the timekeeping subsystem.
>
> This patch is originally written by Thomas, which would bypass
> the bogus rtc interval when pm_trace is enabled.
> Meanwhile, if system succeed to resume back with pm_trace set, the
> users are warned to adjust the bogus rtc either by ntp-date or rdate,
> by resetting pm_trace_rtc_abused to false, otherwise above tools might
> not work as expected.
>
> Originally-from: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Xunlei Pang <xlpang@redhat.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-11-10 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 4:55 [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Chen Yu
2016-11-10 4:55 ` [rtc-linux] " Chen Yu
2016-11-10 16:32 ` Pavel Machek [this message]
2016-11-10 16:32 ` [rtc-linux] " Pavel Machek
2016-11-10 17:16 ` Thomas Gleixner
2016-11-10 17:16 ` [rtc-linux] " Thomas Gleixner
2016-11-10 18:26 ` John Stultz
2016-11-10 18:26 ` [rtc-linux] " John Stultz
[not found] ` <CALAqxLXVaVWBTNs2w-4t6wNsPukQu40wgVcM9B9zudv2KL682Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-11 1:27 ` Rafael J. Wysocki
2016-11-11 1:27 ` Rafael J. Wysocki
2016-11-11 1:27 ` [rtc-linux] " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110163225.GB28832@amd \
--to=pavel@ucw.cz \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xlpang@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.