From: James Hogan <james.hogan@imgtec.com>
To: <fengguang.wu@intel.com>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.cz>,
stable@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
linux-mips@linux-mips.org, kvm@vger.kernel.org,
"Paul Burton" <Paul.Burton@imgtec.com>
Subject: Re: [BACKPORT PATCH 3.10..3.16] KVM: MIPS: Drop other CPU ASIDs on guest MMU changes
Date: Thu, 10 Nov 2016 17:37:22 +0000 [thread overview]
Message-ID: <20161110173721.GD7075@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20161110060843.GA28639@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]
Hi Fengguang,
On Thu, Nov 10, 2016 at 07:08:43AM +0100, Greg KH wrote:
> On Wed, Nov 09, 2016 at 10:00:43PM +0000, James Hogan wrote:
> > On Wed, Nov 09, 2016 at 10:22:01PM +0100, Jiri Slaby wrote:
> > > On 11/09/2016, 03:46 PM, James Hogan wrote:
> > > > Unfortunately the original commit went in to v3.12.65 as commit
> > > > 168e5ebbd63e, without fixing up the references to tlb_lo[0/1] to
> > > > tlb_lo0/1 which broke the MIPS KVM build, and I didn't twig that I
> > > > already had a correct backport outstanding (sorry!). That commit should
> > > > be reverted before applying this backport to 3.12.
> > >
> > > Thanks, reverted and applied. I wonder the builders didn't break given 4
> > > mips configurations are tested. I indeed could reproduce locally.
> >
> > I'm guessing malta_kvm_defconfig isn't one of those defconfigs (and the
> > imgtec buildbots don't yet test stable branches). Which builders do you
> > use?
>
> I use 0-day for these types of things, and it is not showing up any
> errors for the 4.4-stable kernel. Can you get these configurations
> added to it so that we can ensure it doesn't regress?
Can we please get a few MIPS defconfigs added to the 0-day testing?
- malta_kvm_defconfig
this probably doesn't need to be a high priority build, but other
configs don't yet cover MIPS KVM so its worth having (that bit us
recently with 3.12 and 4.4 stable branches).
- 64r6el_defconfig and 32r2_defconfig (4.9 and later)
these are just a couple of the new generic/multiplatform kernel
configurations added in 4.9 (Paul Burton Cc'd). There are others too,
but these will probably give decent coverage. These are likely to be
increasingly relevant as more/new platforms are converted to use it.
(note, the r6 one may require a newish toolchain).
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: fengguang.wu@intel.com
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.cz>,
stable@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
linux-mips@linux-mips.org, kvm@vger.kernel.org,
"Paul Burton" <Paul.Burton@imgtec.com>
Subject: Re: [BACKPORT PATCH 3.10..3.16] KVM: MIPS: Drop other CPU ASIDs on guest MMU changes
Date: Thu, 10 Nov 2016 17:37:22 +0000 [thread overview]
Message-ID: <20161110173721.GD7075@jhogan-linux.le.imgtec.org> (raw)
Message-ID: <20161110173722.QMmP88eeHvlom6nS4p6zVAcjPpD5X31krmWBaydizKo@z> (raw)
In-Reply-To: <20161110060843.GA28639@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]
Hi Fengguang,
On Thu, Nov 10, 2016 at 07:08:43AM +0100, Greg KH wrote:
> On Wed, Nov 09, 2016 at 10:00:43PM +0000, James Hogan wrote:
> > On Wed, Nov 09, 2016 at 10:22:01PM +0100, Jiri Slaby wrote:
> > > On 11/09/2016, 03:46 PM, James Hogan wrote:
> > > > Unfortunately the original commit went in to v3.12.65 as commit
> > > > 168e5ebbd63e, without fixing up the references to tlb_lo[0/1] to
> > > > tlb_lo0/1 which broke the MIPS KVM build, and I didn't twig that I
> > > > already had a correct backport outstanding (sorry!). That commit should
> > > > be reverted before applying this backport to 3.12.
> > >
> > > Thanks, reverted and applied. I wonder the builders didn't break given 4
> > > mips configurations are tested. I indeed could reproduce locally.
> >
> > I'm guessing malta_kvm_defconfig isn't one of those defconfigs (and the
> > imgtec buildbots don't yet test stable branches). Which builders do you
> > use?
>
> I use 0-day for these types of things, and it is not showing up any
> errors for the 4.4-stable kernel. Can you get these configurations
> added to it so that we can ensure it doesn't regress?
Can we please get a few MIPS defconfigs added to the 0-day testing?
- malta_kvm_defconfig
this probably doesn't need to be a high priority build, but other
configs don't yet cover MIPS KVM so its worth having (that bit us
recently with 3.12 and 4.4 stable branches).
- 64r6el_defconfig and 32r2_defconfig (4.9 and later)
these are just a couple of the new generic/multiplatform kernel
configurations added in 4.9 (Paul Burton Cc'd). There are others too,
but these will probably give decent coverage. These are likely to be
increasingly relevant as more/new platforms are converted to use it.
(note, the r6 one may require a newish toolchain).
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-10 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 14:46 [BACKPORT PATCH 3.10..3.16] KVM: MIPS: Drop other CPU ASIDs on guest MMU changes James Hogan
2016-11-09 14:46 ` James Hogan
2016-11-09 17:34 ` Willy Tarreau
2016-11-09 21:22 ` Jiri Slaby
2016-11-09 22:00 ` James Hogan
2016-11-10 6:08 ` Greg KH
2016-11-10 17:37 ` James Hogan [this message]
2016-11-10 17:37 ` James Hogan
2016-11-11 2:56 ` Fengguang Wu
2016-11-11 8:42 ` Jiri Slaby
2016-11-11 8:58 ` Paul Burton
2016-11-11 23:11 ` Fengguang Wu
2016-11-12 3:08 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110173721.GD7075@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=Paul.Burton@imgtec.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rkrcmar@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.