* [patch] staging: lustre: lov: crash in error handling
@ 2016-11-10 19:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-10 19:41 UTC (permalink / raw)
To: Oleg Drokin, John L. Hammond
Cc: Andreas Dilger, James Simmons, Greg Kroah-Hartman,
Amitoj Kaur Chawla, lustre-devel, devel, linux-kernel,
kernel-janitors
We accidentally made this unsigned so now the error handling will loop
until it crashes.
Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
index 53db170..2e2abed 100644
--- a/drivers/staging/lustre/lustre/lov/lov_ea.c
+++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
@@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
size_t oinfo_ptrs_size, lsm_size;
struct lov_stripe_md *lsm;
struct lov_oinfo *loi;
- unsigned int i;
+ int i;
LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] staging: lustre: lov: crash in error handling
@ 2016-11-10 19:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-10 19:41 UTC (permalink / raw)
To: Oleg Drokin, John L. Hammond
Cc: Andreas Dilger, James Simmons, Greg Kroah-Hartman,
Amitoj Kaur Chawla, lustre-devel, devel, linux-kernel,
kernel-janitors
We accidentally made this unsigned so now the error handling will loop
until it crashes.
Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
index 53db170..2e2abed 100644
--- a/drivers/staging/lustre/lustre/lov/lov_ea.c
+++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
@@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
size_t oinfo_ptrs_size, lsm_size;
struct lov_stripe_md *lsm;
struct lov_oinfo *loi;
- unsigned int i;
+ int i;
LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [lustre-devel] [patch] staging: lustre: lov: crash in error handling
@ 2016-11-10 19:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-10 19:41 UTC (permalink / raw)
To: Oleg Drokin, John L. Hammond
Cc: Andreas Dilger, James Simmons, Greg Kroah-Hartman,
Amitoj Kaur Chawla, lustre-devel, devel, linux-kernel,
kernel-janitors
We accidentally made this unsigned so now the error handling will loop
until it crashes.
Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
index 53db170..2e2abed 100644
--- a/drivers/staging/lustre/lustre/lov/lov_ea.c
+++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
@@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
size_t oinfo_ptrs_size, lsm_size;
struct lov_stripe_md *lsm;
struct lov_oinfo *loi;
- unsigned int i;
+ int i;
LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] staging: lustre: lov: crash in error handling
2016-11-10 19:41 ` [lustre-devel] " Dan Carpenter
(?)
@ 2016-11-10 19:44 ` James Simmons
-1 siblings, 0 replies; 6+ messages in thread
From: James Simmons @ 2016-11-10 19:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Oleg Drokin, John L. Hammond, Andreas Dilger, Greg Kroah-Hartman,
Amitoj Kaur Chawla, lustre-devel, devel, linux-kernel,
kernel-janitors
> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
>
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Yep. I just sent a patch to fix that.
> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
> size_t oinfo_ptrs_size, lsm_size;
> struct lov_stripe_md *lsm;
> struct lov_oinfo *loi;
> - unsigned int i;
> + int i;
>
> LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] staging: lustre: lov: crash in error handling
@ 2016-11-10 19:44 ` James Simmons
0 siblings, 0 replies; 6+ messages in thread
From: James Simmons @ 2016-11-10 19:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Oleg Drokin, John L. Hammond, Andreas Dilger, Greg Kroah-Hartman,
Amitoj Kaur Chawla, lustre-devel, devel, linux-kernel,
kernel-janitors
> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
>
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Yep. I just sent a patch to fix that.
> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
> size_t oinfo_ptrs_size, lsm_size;
> struct lov_stripe_md *lsm;
> struct lov_oinfo *loi;
> - unsigned int i;
> + int i;
>
> LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [lustre-devel] [patch] staging: lustre: lov: crash in error handling
@ 2016-11-10 19:44 ` James Simmons
0 siblings, 0 replies; 6+ messages in thread
From: James Simmons @ 2016-11-10 19:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Oleg Drokin, John L. Hammond, Andreas Dilger, Greg Kroah-Hartman,
Amitoj Kaur Chawla, lustre-devel, devel, linux-kernel,
kernel-janitors
> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
>
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Yep. I just sent a patch to fix that.
> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
> size_t oinfo_ptrs_size, lsm_size;
> struct lov_stripe_md *lsm;
> struct lov_oinfo *loi;
> - unsigned int i;
> + int i;
>
> LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-10 19:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 19:41 [patch] staging: lustre: lov: crash in error handling Dan Carpenter
2016-11-10 19:41 ` Dan Carpenter
2016-11-10 19:41 ` [lustre-devel] " Dan Carpenter
2016-11-10 19:44 ` James Simmons
2016-11-10 19:44 ` James Simmons
2016-11-10 19:44 ` [lustre-devel] " James Simmons
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.