From: Stephen Boyd <sboyd@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Sarangdhar Joshi <spjoshi@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jordan Crouse <jcrouse@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency
Date: Thu, 10 Nov 2016 15:17:22 -0800 [thread overview]
Message-ID: <20161110231722.GL16026@codeaurora.org> (raw)
In-Reply-To: <20161110055507.GD11179@tuxbot>
On 11/09, Bjorn Andersson wrote:
> On Wed 09 Nov 17:47 PST 2016, Stephen Boyd wrote:
>
> > On 11/03, Sarangdhar Joshi wrote:
> > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > > index d79fecd..844e90d 100644
> > > --- a/drivers/firmware/qcom_scm.c
> > > +++ b/drivers/firmware/qcom_scm.c
> > > @@ -380,32 +384,40 @@ EXPORT_SYMBOL(qcom_scm_is_available);
> > > static int qcom_scm_probe(struct platform_device *pdev)
> > > {
> > > struct qcom_scm *scm;
> > > + uint32_t clks;
> >
> > If this was unsigned long flags;
> >
>
> I did look at this too and could only find a mixture of ways people have
> done this. Isn't the correct type for this intptr_t?
>
Well unsigned long == sizeof(kernel pointer) on all Linux
platforms so it's safe to do the cast. For example, struct
timer_list stores data in unsigned long. I guess this is a
'kernelism' though? Perhaps we should update
Documentation/CodingStyle if anyone cares.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-10 23:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 0:10 [PATCH v2 0/3] Remove clocks dependency from SCM driver Sarangdhar Joshi
2016-11-04 0:10 ` Sarangdhar Joshi
2016-11-04 0:10 ` Sarangdhar Joshi
2016-11-04 0:10 ` [PATCH v2 1/3] dt-bindings: firmware: scm: Add MSM8996 DT bindings Sarangdhar Joshi
2016-11-04 0:10 ` Sarangdhar Joshi
[not found] ` <1478218237-1737-2-git-send-email-spjoshi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-11-10 1:49 ` Stephen Boyd
2016-11-10 1:49 ` Stephen Boyd
2016-11-10 1:49 ` Stephen Boyd
2016-11-04 0:10 ` [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency Sarangdhar Joshi
2016-11-10 1:47 ` Stephen Boyd
2016-11-10 5:55 ` Bjorn Andersson
2016-11-10 23:17 ` Stephen Boyd [this message]
2016-11-11 22:07 ` Sarangdhar Joshi
2016-11-11 21:59 ` Sarangdhar Joshi
2016-11-04 0:10 ` [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Sarangdhar Joshi
2016-11-10 1:49 ` Stephen Boyd
2016-11-11 21:30 ` Sarangdhar Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110231722.GL16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=spjoshi@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.