From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] dmaengine: qcom_hidma: cleanup sysfs entries during remove
Date: Mon, 14 Nov 2016 08:34:53 +0530 [thread overview]
Message-ID: <20161114030452.GH3000@localhost> (raw)
In-Reply-To: <1476902566-26676-1-git-send-email-okaya@codeaurora.org>
On Wed, Oct 19, 2016 at 02:42:46PM -0400, Sinan Kaya wrote:
> The 4.8-rc8 kernel is printing duplicate file entry warnings while removing
> the HIDMA object. This is caused by stale sysfs entries remaining from the
> previous execution.
>
> _sysfs_warn_dup+0x5c/0x78
> sysfs_add_file_mode_ns+0x13c/0x1c0
> sysfs_create_file_ns+0x2c/0x40
> device_create_file+0x54/0xa0
> hidma_probe+0x7c8/0x808
>
> Create hidma_sysfs_init and hidma_sysfs_uninit functions and call them from
> the probe and remove path. To do proper clean up, adding the attrs object
> to the device data structure to keep it around until remove call is made.
This doesnt apply for me, I think due to other patches applied..
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] dmaengine: qcom_hidma: cleanup sysfs entries during remove
Date: Mon, 14 Nov 2016 08:34:53 +0530 [thread overview]
Message-ID: <20161114030452.GH3000@localhost> (raw)
In-Reply-To: <1476902566-26676-1-git-send-email-okaya@codeaurora.org>
On Wed, Oct 19, 2016 at 02:42:46PM -0400, Sinan Kaya wrote:
> The 4.8-rc8 kernel is printing duplicate file entry warnings while removing
> the HIDMA object. This is caused by stale sysfs entries remaining from the
> previous execution.
>
> _sysfs_warn_dup+0x5c/0x78
> sysfs_add_file_mode_ns+0x13c/0x1c0
> sysfs_create_file_ns+0x2c/0x40
> device_create_file+0x54/0xa0
> hidma_probe+0x7c8/0x808
>
> Create hidma_sysfs_init and hidma_sysfs_uninit functions and call them from
> the probe and remove path. To do proper clean up, adding the attrs object
> to the device data structure to keep it around until remove call is made.
This doesnt apply for me, I think due to other patches applied..
--
~Vinod
next prev parent reply other threads:[~2016-11-14 3:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 18:42 [PATCH V2] dmaengine: qcom_hidma: cleanup sysfs entries during remove Sinan Kaya
2016-10-19 18:42 ` Sinan Kaya
2016-11-14 3:04 ` Vinod Koul [this message]
2016-11-14 3:04 ` Vinod Koul
2016-11-14 3:10 ` Sinan Kaya
2016-11-14 3:10 ` Sinan Kaya
2016-11-14 19:37 ` Sinan Kaya
2016-11-14 19:37 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114030452.GH3000@localhost \
--to=vinod.koul@intel.com \
--cc=cov@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.