From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
akpm@linux-foundation.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH v2 2/2] powerpc/mm/hugetlb: Switch hugetlb update to use pte_update
Date: Mon, 14 Nov 2016 20:50:20 +0530 [thread overview]
Message-ID: <20161114152020.4608-2-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161114152020.4608-1-aneesh.kumar@linux.vnet.ibm.com>
Now that we have updated hugetlb functions to take vm_area_struct and we can
derive huge page size from vma, switch the pte update to use generic functions.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
arch/powerpc/include/asm/book3s/64/hugetlb.h | 34 +++++++---------------------
arch/powerpc/include/asm/hugetlb.h | 2 +-
2 files changed, 9 insertions(+), 27 deletions(-)
diff --git a/arch/powerpc/include/asm/book3s/64/hugetlb.h b/arch/powerpc/include/asm/book3s/64/hugetlb.h
index 80fa0c828413..0a6db2086140 100644
--- a/arch/powerpc/include/asm/book3s/64/hugetlb.h
+++ b/arch/powerpc/include/asm/book3s/64/hugetlb.h
@@ -31,36 +31,18 @@ static inline int hstate_get_psize(struct hstate *hstate)
}
}
-static inline unsigned long huge_pte_update(struct mm_struct *mm, unsigned long addr,
+static inline unsigned long huge_pte_update(struct vm_area_struct *vma, unsigned long addr,
pte_t *ptep, unsigned long clr,
unsigned long set)
{
- if (radix_enabled()) {
- unsigned long old_pte;
+ unsigned long pg_sz;
- if (cpu_has_feature(CPU_FTR_POWER9_DD1)) {
+ VM_WARN_ON(!is_vm_hugetlb_page(vma));
+ pg_sz = huge_page_size(hstate_vma(vma));
- unsigned long new_pte;
-
- old_pte = __radix_pte_update(ptep, ~0, 0);
- asm volatile("ptesync" : : : "memory");
- /*
- * new value of pte
- */
- new_pte = (old_pte | set) & ~clr;
- /*
- * For now let's do heavy pid flush
- * radix__flush_tlb_page_psize(mm, addr, mmu_virtual_psize);
- */
- radix__flush_tlb_mm(mm);
-
- __radix_pte_update(ptep, 0, new_pte);
- } else
- old_pte = __radix_pte_update(ptep, clr, set);
- asm volatile("ptesync" : : : "memory");
- return old_pte;
- }
- return hash__pte_update(mm, addr, ptep, clr, set, true);
+ if (radix_enabled())
+ return radix__pte_update(vma->vm_mm, addr, ptep, clr, set, pg_sz);
+ return hash__pte_update(vma->vm_mm, addr, ptep, clr, set, true);
}
static inline void huge_ptep_set_wrprotect(struct vm_area_struct *vma,
@@ -69,7 +51,7 @@ static inline void huge_ptep_set_wrprotect(struct vm_area_struct *vma,
if ((pte_raw(*ptep) & cpu_to_be64(_PAGE_WRITE)) == 0)
return;
- huge_pte_update(vma->vm_mm, addr, ptep, _PAGE_WRITE, 0);
+ huge_pte_update(vma, addr, ptep, _PAGE_WRITE, 0);
}
#endif
diff --git a/arch/powerpc/include/asm/hugetlb.h b/arch/powerpc/include/asm/hugetlb.h
index bb1bf23d6f90..f0731dff76c2 100644
--- a/arch/powerpc/include/asm/hugetlb.h
+++ b/arch/powerpc/include/asm/hugetlb.h
@@ -136,7 +136,7 @@ static inline pte_t huge_ptep_get_and_clear(struct vm_area_struct *vma,
unsigned long addr, pte_t *ptep)
{
#ifdef CONFIG_PPC64
- return __pte(huge_pte_update(vma->vm_mm, addr, ptep, ~0UL, 0));
+ return __pte(huge_pte_update(vma, addr, ptep, ~0UL, 0));
#else
return __pte(pte_update(ptep, ~0UL, 0));
#endif
--
2.10.2
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
akpm@linux-foundation.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH v2 2/2] powerpc/mm/hugetlb: Switch hugetlb update to use pte_update
Date: Mon, 14 Nov 2016 20:50:20 +0530 [thread overview]
Message-ID: <20161114152020.4608-2-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161114152020.4608-1-aneesh.kumar@linux.vnet.ibm.com>
Now that we have updated hugetlb functions to take vm_area_struct and we can
derive huge page size from vma, switch the pte update to use generic functions.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
arch/powerpc/include/asm/book3s/64/hugetlb.h | 34 +++++++---------------------
arch/powerpc/include/asm/hugetlb.h | 2 +-
2 files changed, 9 insertions(+), 27 deletions(-)
diff --git a/arch/powerpc/include/asm/book3s/64/hugetlb.h b/arch/powerpc/include/asm/book3s/64/hugetlb.h
index 80fa0c828413..0a6db2086140 100644
--- a/arch/powerpc/include/asm/book3s/64/hugetlb.h
+++ b/arch/powerpc/include/asm/book3s/64/hugetlb.h
@@ -31,36 +31,18 @@ static inline int hstate_get_psize(struct hstate *hstate)
}
}
-static inline unsigned long huge_pte_update(struct mm_struct *mm, unsigned long addr,
+static inline unsigned long huge_pte_update(struct vm_area_struct *vma, unsigned long addr,
pte_t *ptep, unsigned long clr,
unsigned long set)
{
- if (radix_enabled()) {
- unsigned long old_pte;
+ unsigned long pg_sz;
- if (cpu_has_feature(CPU_FTR_POWER9_DD1)) {
+ VM_WARN_ON(!is_vm_hugetlb_page(vma));
+ pg_sz = huge_page_size(hstate_vma(vma));
- unsigned long new_pte;
-
- old_pte = __radix_pte_update(ptep, ~0, 0);
- asm volatile("ptesync" : : : "memory");
- /*
- * new value of pte
- */
- new_pte = (old_pte | set) & ~clr;
- /*
- * For now let's do heavy pid flush
- * radix__flush_tlb_page_psize(mm, addr, mmu_virtual_psize);
- */
- radix__flush_tlb_mm(mm);
-
- __radix_pte_update(ptep, 0, new_pte);
- } else
- old_pte = __radix_pte_update(ptep, clr, set);
- asm volatile("ptesync" : : : "memory");
- return old_pte;
- }
- return hash__pte_update(mm, addr, ptep, clr, set, true);
+ if (radix_enabled())
+ return radix__pte_update(vma->vm_mm, addr, ptep, clr, set, pg_sz);
+ return hash__pte_update(vma->vm_mm, addr, ptep, clr, set, true);
}
static inline void huge_ptep_set_wrprotect(struct vm_area_struct *vma,
@@ -69,7 +51,7 @@ static inline void huge_ptep_set_wrprotect(struct vm_area_struct *vma,
if ((pte_raw(*ptep) & cpu_to_be64(_PAGE_WRITE)) == 0)
return;
- huge_pte_update(vma->vm_mm, addr, ptep, _PAGE_WRITE, 0);
+ huge_pte_update(vma, addr, ptep, _PAGE_WRITE, 0);
}
#endif
diff --git a/arch/powerpc/include/asm/hugetlb.h b/arch/powerpc/include/asm/hugetlb.h
index bb1bf23d6f90..f0731dff76c2 100644
--- a/arch/powerpc/include/asm/hugetlb.h
+++ b/arch/powerpc/include/asm/hugetlb.h
@@ -136,7 +136,7 @@ static inline pte_t huge_ptep_get_and_clear(struct vm_area_struct *vma,
unsigned long addr, pte_t *ptep)
{
#ifdef CONFIG_PPC64
- return __pte(huge_pte_update(vma->vm_mm, addr, ptep, ~0UL, 0));
+ return __pte(huge_pte_update(vma, addr, ptep, ~0UL, 0));
#else
return __pte(pte_update(ptep, ~0UL, 0));
#endif
--
2.10.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-14 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 15:20 [PATCH v2 1/2] hugetlb: Change the function prototype to take vma_area_struct as arg Aneesh Kumar K.V
2016-11-14 15:20 ` Aneesh Kumar K.V
2016-11-14 15:20 ` Aneesh Kumar K.V [this message]
2016-11-14 15:20 ` [PATCH v2 2/2] powerpc/mm/hugetlb: Switch hugetlb update to use pte_update Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114152020.4608-2-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.