All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: Omar Sandoval <osandov@osandov.com>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, hch@infradead.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] block: fast-path for small and simple direct I/O requests
Date: Tue, 15 Nov 2016 14:49:32 +0100	[thread overview]
Message-ID: <20161115134932.GA28632@lst.de> (raw)
In-Reply-To: <b10995da-5a09-d015-36f2-c7a52c0abcc4@fb.com>

On Mon, Nov 14, 2016 at 01:00:09PM -0700, Jens Axboe wrote:
> Prefetches like that tend to grow stale, in my experience. So we should
> probably just evaluate the new path cache behavior and see if it makes
> sense.

Yes.  I've tested the patches with that in place, but it didn't
make a difference.  Probably because we're not wasting many cycles
between the possible place for the prefetch and the use of it anyway.

  reply	other threads:[~2016-11-15 13:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-12  5:11 [PATCHSET v3] block: IO polling improvements Jens Axboe
2016-11-12  5:11 ` [PATCH 1/3] block: fast-path for small and simple direct I/O requests Jens Axboe
2016-11-14 19:33   ` Omar Sandoval
2016-11-14 20:00     ` Jens Axboe
2016-11-14 20:00       ` Jens Axboe
2016-11-15 13:49       ` Christoph Hellwig [this message]
2016-11-12  5:11 ` [PATCH 2/3] blk-mq: implement hybrid poll mode for sync O_DIRECT Jens Axboe
2016-11-12  5:11 ` [PATCH 3/3] blk-mq: make the polling code adaptive Jens Axboe
2016-11-14 19:43   ` Omar Sandoval
2016-11-14 19:58     ` Jens Axboe
2016-11-14 19:58       ` Jens Axboe
2016-11-16 17:31 ` [PATCHSET v3] block: IO polling improvements Stephen Bates
2016-11-16 20:59   ` Jens Axboe
2016-11-16 20:59     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115134932.GA28632@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.