From: rabin.vincent@axis.com (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ftrace: fix syscall name matching
Date: Tue, 15 Nov 2016 16:18:27 +0100 [thread overview]
Message-ID: <20161115151826.GA14085@axis.com> (raw)
In-Reply-To: <20161114104008.36e9c40d@gandalf.local.home>
On Mon, Nov 14, 2016 at 10:40:08AM -0500, Steven Rostedt wrote:
> On Mon, 14 Nov 2016 13:40:17 +0000
> Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> > On Mon, Nov 14, 2016 at 02:03:45PM +0100, Rabin Vincent wrote:
> > > +static inline bool arch_syscall_match_sym_name(const char *sym,
> > > + const char *name)
> > > +{
> > > + /* Skip sys_ */
> > > + sym += 4;
> > > + name += 4;
> >
> > Is this really safe? What guarantees that we can wind forward four
> > bytes here? If it's always safe, it needs a better comment than just
> > two words.
>
> I believe it is, but a comment would do well.
I ended up just getting rid of the skip and comparing the whole name
instead. I've sent a v2.
WARNING: multiple messages have this Message-ID (diff)
From: Rabin Vincent <rabin.vincent@axis.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: ftrace: fix syscall name matching
Date: Tue, 15 Nov 2016 16:18:27 +0100 [thread overview]
Message-ID: <20161115151826.GA14085@axis.com> (raw)
In-Reply-To: <20161114104008.36e9c40d@gandalf.local.home>
On Mon, Nov 14, 2016 at 10:40:08AM -0500, Steven Rostedt wrote:
> On Mon, 14 Nov 2016 13:40:17 +0000
> Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> > On Mon, Nov 14, 2016 at 02:03:45PM +0100, Rabin Vincent wrote:
> > > +static inline bool arch_syscall_match_sym_name(const char *sym,
> > > + const char *name)
> > > +{
> > > + /* Skip sys_ */
> > > + sym += 4;
> > > + name += 4;
> >
> > Is this really safe? What guarantees that we can wind forward four
> > bytes here? If it's always safe, it needs a better comment than just
> > two words.
>
> I believe it is, but a comment would do well.
I ended up just getting rid of the skip and comparing the whole name
instead. I've sent a v2.
next prev parent reply other threads:[~2016-11-15 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 13:03 [PATCH] ARM: ftrace: fix syscall name matching Rabin Vincent
2016-11-14 13:03 ` Rabin Vincent
2016-11-14 13:40 ` Russell King - ARM Linux
2016-11-14 13:40 ` Russell King - ARM Linux
2016-11-14 15:40 ` Steven Rostedt
2016-11-14 15:40 ` Steven Rostedt
2016-11-14 15:44 ` Steven Rostedt
2016-11-14 15:44 ` Steven Rostedt
2016-11-15 15:18 ` Rabin Vincent [this message]
2016-11-15 15:18 ` Rabin Vincent
2016-11-15 10:17 ` [PATCHv2] " Rabin Vincent
2016-11-15 10:17 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115151826.GA14085@axis.com \
--to=rabin.vincent@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.