From: Andrew Lunn <andrew@lunn.ch>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
davem@davemloft.net, charrer@alacritech.com, liodot@gmail.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver
Date: Wed, 16 Nov 2016 00:03:17 +0100 [thread overview]
Message-ID: <20161115230317.GG23231@lunn.ch> (raw)
In-Reply-To: <c645c726-dbe2-108d-c79a-d8db350a13b8@gmx.de>
> >>>>> + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG |
> >>>>> + SLIC_PCR_AUTONEG_RST;
> >>>>> + slic_write(sdev, SLIC_REG_WPHY, val);
> Thats essentially what I meant by setting a flag in the irq handler. The mdio
> function would have to check somehow if the irq has been fired (be it by means
> of a flag or a completion that is set by the irq handler and checked by the
> mdio function). So I agree that it should work (if reading via the AP command
> is actually possible).
It seems odd you have a nice simple way to do writes, but reads are
very complex. There might be a simple read method hiding somewhere.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: devel@driverdev.osuosl.org,
Florian Fainelli <f.fainelli@gmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
liodot@gmail.com, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver
Date: Wed, 16 Nov 2016 00:03:17 +0100 [thread overview]
Message-ID: <20161115230317.GG23231@lunn.ch> (raw)
In-Reply-To: <c645c726-dbe2-108d-c79a-d8db350a13b8@gmx.de>
> >>>>> + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG |
> >>>>> + SLIC_PCR_AUTONEG_RST;
> >>>>> + slic_write(sdev, SLIC_REG_WPHY, val);
> Thats essentially what I meant by setting a flag in the irq handler. The mdio
> function would have to check somehow if the irq has been fired (be it by means
> of a flag or a completion that is set by the irq handler and checked by the
> mdio function). So I agree that it should work (if reading via the AP command
> is actually possible).
It seems odd you have a nice simple way to do writes, but reads are
very complex. There might be a simple read method hiding somewhere.
Andrew
next prev parent reply other threads:[~2016-11-15 23:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 4:47 Gigabit ethernet driver for Alacritechs SLIC devices Lino Sanfilippo
2016-11-13 4:47 ` [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo
2016-11-13 7:13 ` kbuild test robot
2016-11-13 7:13 ` kbuild test robot
2016-11-13 8:38 ` kbuild test robot
2016-11-13 19:55 ` Andrew Lunn
2016-11-15 20:46 ` Lino Sanfilippo
2016-11-15 20:54 ` Florian Fainelli
2016-11-15 20:54 ` Florian Fainelli
2016-11-15 21:24 ` Lino Sanfilippo
2016-11-15 21:59 ` Andrew Lunn
2016-11-15 22:34 ` Lino Sanfilippo
2016-11-15 22:39 ` Florian Fainelli
2016-11-15 22:54 ` Lino Sanfilippo
2016-11-15 23:03 ` Andrew Lunn [this message]
2016-11-15 23:03 ` Andrew Lunn
2016-11-15 23:14 ` Lino Sanfilippo
2016-11-15 23:14 ` Lino Sanfilippo
2016-11-24 12:30 ` Aw: " Lino Sanfilippo
2016-11-13 4:47 ` [net-next 2/2] MAINTAINERS: add entry for slicoss " Lino Sanfilippo
2016-11-13 4:47 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115230317.GG23231@lunn.ch \
--to=andrew@lunn.ch \
--cc=LinoSanfilippo@gmx.de \
--cc=charrer@alacritech.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.