* [PATCH] mxs-auart: count FIFO overrun errors
@ 2016-11-15 11:05 ` Wolfgang Ocker
0 siblings, 0 replies; 5+ messages in thread
From: Wolfgang Ocker @ 2016-11-15 11:05 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, linux-serial
Cc: Greg Kroah-Hartman, Jiri Slaby
The mxs-auart driver does not count FIFO overrun errors. These errors never
appear in /proc/tty/driver/ttyAPP. This is because the OERR status bit is
masked by read_status_mask in the rx interrupt function, but the
AUART_STAT_OERR bit is never set in read_status_mask. The patch enables the
counting of overrun errors.
Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
---
drivers/tty/serial/mxs-auart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 770454e0dfa3..8c1c9112b3fd 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -1016,7 +1016,7 @@ static void mxs_auart_settermios(struct uart_port *u,
ctrl |= AUART_LINECTRL_EPS;
}
- u->read_status_mask = 0;
+ u->read_status_mask = AUART_STAT_OERR;
if (termios->c_iflag & INPCK)
u->read_status_mask |= AUART_STAT_PERR;
--
2.10.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mxs-auart: count FIFO overrun errors
@ 2016-11-15 11:05 ` Wolfgang Ocker
0 siblings, 0 replies; 5+ messages in thread
From: Wolfgang Ocker @ 2016-11-15 11:05 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, linux-serial
Cc: Greg Kroah-Hartman, Jiri Slaby
The mxs-auart driver does not count FIFO overrun errors. These errors never
appear in /proc/tty/driver/ttyAPP. This is because the OERR status bit is
masked by read_status_mask in the rx interrupt function, but the
AUART_STAT_OERR bit is never set in read_status_mask. The patch enables the
counting of overrun errors.
Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
---
drivers/tty/serial/mxs-auart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 770454e0dfa3..8c1c9112b3fd 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -1016,7 +1016,7 @@ static void mxs_auart_settermios(struct uart_port *u,
ctrl |= AUART_LINECTRL_EPS;
}
- u->read_status_mask = 0;
+ u->read_status_mask = AUART_STAT_OERR;
if (termios->c_iflag & INPCK)
u->read_status_mask |= AUART_STAT_PERR;
--
2.10.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mxs-auart: count FIFO overrun errors
@ 2016-11-15 11:05 ` Wolfgang Ocker
0 siblings, 0 replies; 5+ messages in thread
From: Wolfgang Ocker @ 2016-11-15 11:05 UTC (permalink / raw)
To: linux-arm-kernel
The mxs-auart driver does not count FIFO overrun errors. These errors never
appear in /proc/tty/driver/ttyAPP. This is because the OERR status bit is
masked by read_status_mask in the rx interrupt function, but the
AUART_STAT_OERR bit is never set in read_status_mask. The patch enables the
counting of overrun errors.
Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
---
?drivers/tty/serial/mxs-auart.c | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 770454e0dfa3..8c1c9112b3fd 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -1016,7 +1016,7 @@ static void mxs_auart_settermios(struct uart_port *u,
? ctrl |= AUART_LINECTRL_EPS;
? }
?
- u->read_status_mask = 0;
+ u->read_status_mask = AUART_STAT_OERR;
?
? if (termios->c_iflag & INPCK)
? u->read_status_mask |= AUART_STAT_PERR;
--?
2.10.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mxs-auart: count FIFO overrun errors
2016-11-15 11:05 ` Wolfgang Ocker
@ 2016-11-16 9:57 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-11-16 9:57 UTC (permalink / raw)
To: Wolfgang Ocker; +Cc: linux-arm-kernel, linux-kernel, linux-serial, Jiri Slaby
On Tue, Nov 15, 2016 at 12:05:29PM +0100, Wolfgang Ocker wrote:
> The mxs-auart driver does not count FIFO overrun errors. These errors never
> appear in /proc/tty/driver/ttyAPP. This is because the OERR status bit is
> masked by read_status_mask in the rx interrupt function, but the
> AUART_STAT_OERR bit is never set in read_status_mask. The patch enables the
> counting of overrun errors.
>
> Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
> ---
> drivers/tty/serial/mxs-auart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index 770454e0dfa3..8c1c9112b3fd 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -1016,7 +1016,7 @@ static void mxs_auart_settermios(struct uart_port *u,
> ctrl |= AUART_LINECTRL_EPS;
> }
>
> - u->read_status_mask = 0;
> + u->read_status_mask = AUART_STAT_OERR;
>
> if (termios->c_iflag & INPCK)
> u->read_status_mask |= AUART_STAT_PERR;
> --
> 2.10.0
This patch is corrupted and can not be applied, what did you do here?
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mxs-auart: count FIFO overrun errors
@ 2016-11-16 9:57 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-11-16 9:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 15, 2016 at 12:05:29PM +0100, Wolfgang Ocker wrote:
> The mxs-auart driver does not count FIFO overrun errors. These errors never
> appear in /proc/tty/driver/ttyAPP. This is because the OERR status bit is
> masked by read_status_mask in the rx interrupt function, but the
> AUART_STAT_OERR bit is never set in read_status_mask. The patch enables the
> counting of overrun errors.
>
> Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
> ---
> ?drivers/tty/serial/mxs-auart.c | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index 770454e0dfa3..8c1c9112b3fd 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -1016,7 +1016,7 @@ static void mxs_auart_settermios(struct uart_port *u,
> ? ctrl |= AUART_LINECTRL_EPS;
> ? }
> ?
> - u->read_status_mask = 0;
> + u->read_status_mask = AUART_STAT_OERR;
> ?
> ? if (termios->c_iflag & INPCK)
> ? u->read_status_mask |= AUART_STAT_PERR;
> --?
> 2.10.0
This patch is corrupted and can not be applied, what did you do here?
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-16 9:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 11:05 [PATCH] mxs-auart: count FIFO overrun errors Wolfgang Ocker
2016-11-15 11:05 ` Wolfgang Ocker
2016-11-15 11:05 ` Wolfgang Ocker
2016-11-16 9:57 ` Greg Kroah-Hartman
2016-11-16 9:57 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.