From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Cc: Cor Peters
<cpeters-JQzsJ8WnmGqc6Wr4J9gsBQC/G2K4zDHf@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: am33xx.dtsi: Added syscon compatible prcm_dev device
Date: Wed, 16 Nov 2016 09:14:42 -0800 [thread overview]
Message-ID: <20161116171442.GR4082@atomide.com> (raw)
In-Reply-To: <6861ab40-8727-86ab-17bc-6bb7dc3de30a-l0cyMroinI0@public.gmane.org>
* Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org> [161115 11:18]:
> On 15/11/16 19:38, Tony Lindgren wrote:
> > * Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [161115 09:35]:
> > > * Cor Peters <cpeters-JQzsJ8WnmGqc6Wr4J9gsBQC/G2K4zDHf@public.gmane.org> [161115 01:00]:
> > > > This patch adds the PRM_DEV as a syscon compatible device to
> > > > am33xx.dtsi. This is needed for the watchdog bootstatus patch.
> > >
> > > We somehow need to see the bootreason for sure.. But we need to
> > > check with Tero on the reset driver work too.
> > >
> > > Tero, does setting up of PRM_DEVICE as syscon cause issues for
> > > your reset driver work?
>
> Good question, currently the reset driver is on hold waiting for hwmod /
> interconnect work to nudge forward. We could probably try to even re-use the
> syscon reset driver for OMAPs (drivers/reset/reset-ti-syscon.c); reset
> handling is not performance critical as such, and we only have few sources
> for these so...
>
> >
> > The nightmare scenario is that we have drivers calling random
> > syscon areas across various interconnect targets and then we have
> > zero chance of getting genpd to ever to work properly.
>
> Exporting this specific area exposes a few interesting features, like
> performing a system wide reset or tweaking SRAM PM configs (preventing SRAM
> LDOs from idling for example.)
>
> > Do the reset drivers offer some way of exporting the reset status?
>
> reset_control_status() can be used to read the reset status, this is however
> mostly meant for checking if reset line is currently asserted or not. We
> could in theory overload this for checking if reset has been asserted
> previously or not (checking current status for watchdog reset doesn't make
> much sense for example.)
OK in that case I'd prefer that we get the status from a reset driver.
I think a minimal reset driver could be already done as a regular
device driver that works also as a loadable module. It probably still
needs some callback functions passed to it in platform_data via
pdata-quirks.c though.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: Cor Peters <cpeters@victronenergy.com>,
linux-omap@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: am33xx.dtsi: Added syscon compatible prcm_dev device
Date: Wed, 16 Nov 2016 09:14:42 -0800 [thread overview]
Message-ID: <20161116171442.GR4082@atomide.com> (raw)
In-Reply-To: <6861ab40-8727-86ab-17bc-6bb7dc3de30a@ti.com>
* Tero Kristo <t-kristo@ti.com> [161115 11:18]:
> On 15/11/16 19:38, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [161115 09:35]:
> > > * Cor Peters <cpeters@victronenergy.com> [161115 01:00]:
> > > > This patch adds the PRM_DEV as a syscon compatible device to
> > > > am33xx.dtsi. This is needed for the watchdog bootstatus patch.
> > >
> > > We somehow need to see the bootreason for sure.. But we need to
> > > check with Tero on the reset driver work too.
> > >
> > > Tero, does setting up of PRM_DEVICE as syscon cause issues for
> > > your reset driver work?
>
> Good question, currently the reset driver is on hold waiting for hwmod /
> interconnect work to nudge forward. We could probably try to even re-use the
> syscon reset driver for OMAPs (drivers/reset/reset-ti-syscon.c); reset
> handling is not performance critical as such, and we only have few sources
> for these so...
>
> >
> > The nightmare scenario is that we have drivers calling random
> > syscon areas across various interconnect targets and then we have
> > zero chance of getting genpd to ever to work properly.
>
> Exporting this specific area exposes a few interesting features, like
> performing a system wide reset or tweaking SRAM PM configs (preventing SRAM
> LDOs from idling for example.)
>
> > Do the reset drivers offer some way of exporting the reset status?
>
> reset_control_status() can be used to read the reset status, this is however
> mostly meant for checking if reset line is currently asserted or not. We
> could in theory overload this for checking if reset has been asserted
> previously or not (checking current status for watchdog reset doesn't make
> much sense for example.)
OK in that case I'd prefer that we get the status from a reset driver.
I think a minimal reset driver could be already done as a regular
device driver that works also as a loadable module. It probably still
needs some callback functions passed to it in platform_data via
pdata-quirks.c though.
Regards,
Tony
next prev parent reply other threads:[~2016-11-16 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 8:44 [PATCH 2/2] ARM: am33xx.dtsi: Added syscon compatible prcm_dev device Cor Peters
2016-11-15 8:44 ` Cor Peters
2016-11-15 17:35 ` Tony Lindgren
2016-11-15 17:35 ` Tony Lindgren
[not found] ` <20161115173515.GL4082-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-11-15 17:38 ` Tony Lindgren
2016-11-15 17:38 ` Tony Lindgren
[not found] ` <20161115173816.GM4082-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-11-15 19:18 ` Tero Kristo
2016-11-15 19:18 ` Tero Kristo
[not found] ` <6861ab40-8727-86ab-17bc-6bb7dc3de30a-l0cyMroinI0@public.gmane.org>
2016-11-16 17:14 ` Tony Lindgren [this message]
2016-11-16 17:14 ` Tony Lindgren
[not found] ` <20161116171442.GR4082-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-11-16 18:58 ` Tero Kristo
2016-11-16 18:58 ` Tero Kristo
2016-11-15 18:38 ` Guenter Roeck
2016-11-15 18:38 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116171442.GR4082@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=cpeters-JQzsJ8WnmGqc6Wr4J9gsBQC/G2K4zDHf@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.