From: Alan Tull <atull@opensource.altera.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Moritz Fischer <moritz.fischer@ettus.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
kernel-janitors@vger.kernel.org, delicious.quinoa@gmail.com
Subject: [PATCH 1/1] ARM: socfpga: checking the wrong variable
Date: Thu, 17 Nov 2016 01:54:40 +0000 [thread overview]
Message-ID: <20161117015440.3113-2-atull@opensource.altera.com> (raw)
In-Reply-To: <20161117015440.3113-1-atull@opensource.altera.com>
From: Dan Carpenter <dan.carpenter@oracle.com>
This is a cut and paste bug. We had intended to check "sysmgr".
Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Acked-by: Alan Tull <atull@opensource.altera.com>
---
drivers/fpga/altera-fpga2sdram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 7ab358e..d4eeb74 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
}
sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
- if (IS_ERR(priv->sdrctl)) {
+ if (IS_ERR(sysmgr)) {
dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
return PTR_ERR(sysmgr);
}
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Alan Tull <atull@opensource.altera.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
<kernel-janitors@vger.kernel.org>, <delicious.quinoa@gmail.com>
Subject: [PATCH 1/1] ARM: socfpga: checking the wrong variable
Date: Wed, 16 Nov 2016 19:54:40 -0600 [thread overview]
Message-ID: <20161117015440.3113-2-atull@opensource.altera.com> (raw)
In-Reply-To: <20161117015440.3113-1-atull@opensource.altera.com>
From: Dan Carpenter <dan.carpenter@oracle.com>
This is a cut and paste bug. We had intended to check "sysmgr".
Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Acked-by: Alan Tull <atull@opensource.altera.com>
---
drivers/fpga/altera-fpga2sdram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 7ab358e..d4eeb74 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
}
sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
- if (IS_ERR(priv->sdrctl)) {
+ if (IS_ERR(sysmgr)) {
dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
return PTR_ERR(sysmgr);
}
--
2.7.4
next prev parent reply other threads:[~2016-11-17 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 1:54 [PATCH 0/1] One bug fix for FPGA Alan Tull
2016-11-17 1:54 ` Alan Tull
2016-11-17 1:54 ` Alan Tull [this message]
2016-11-17 1:54 ` [PATCH 1/1] ARM: socfpga: checking the wrong variable Alan Tull
2016-11-17 7:14 ` [PATCH 0/1] One bug fix for FPGA Greg Kroah-Hartman
2016-11-17 7:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117015440.3113-2-atull@opensource.altera.com \
--to=atull@opensource.altera.com \
--cc=dan.carpenter@oracle.com \
--cc=delicious.quinoa@gmail.com \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.