From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: trond.myklebust@primarydata.com, Anna.Schumaker@Netapp.com,
chuck.lever@oracle.com, stable@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree
Date: Thu, 17 Nov 2016 12:06:54 +0100 [thread overview]
Message-ID: <20161117110654.GB20153@kroah.com> (raw)
In-Reply-To: <092fc57d-c150-6614-3492-f67f101c91b2@bmw-carit.de>
On Thu, Nov 17, 2016 at 11:55:31AM +0100, Daniel Wagner wrote:
> Hi Greg,
>
> On 11/17/2016 08:15 AM, gregkh@linuxfoundation.org wrote:
> > From 5690a22d8612e1788b48b4ea53c59868589cd2db Mon Sep 17 00:00:00 2001
> > From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> > Date: Fri, 23 Sep 2016 10:41:57 +0200
> > Subject: xprtrdma: use complete() instead complete_all()
> >
> > From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> >
> > commit 5690a22d8612e1788b48b4ea53c59868589cd2db upstream.
> >
> > There is only one waiter for the completion, therefore there
> > is no need to use complete_all(). Let's make that clear by
> > using complete() instead of complete_all().
> >
> > The usage pattern of the completion is:
> >
> > waiter context waker context
> >
> > frwr_op_unmap_sync()
> > reinit_completion()
> > ib_post_send()
> > wait_for_completion()
> >
> > frwr_wc_localinv_wake()
> > complete()
>
> I don't think this needs to got into stable. The original code isn't broken.
> This patch is a cleanup unless I miss something :)
It is needed for the patch after this one in the series.
thanks,
greg k-h
next prev parent reply other threads:[~2016-11-17 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 7:15 Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree gregkh
2016-11-17 10:55 ` Daniel Wagner
2016-11-17 11:06 ` Greg KH [this message]
2016-11-17 13:52 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117110654.GB20153@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Anna.Schumaker@Netapp.com \
--cc=chuck.lever@oracle.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.