From: Dan Carpenter <dan.carpenter@oracle.com>
To: bojan prtvar <prtvar.b@gmail.com>
Cc: alsa-devel@alsa-project.org,
Manuel Lauss <mano@roarinelk.homelinux.net>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf
Date: Thu, 17 Nov 2016 16:55:38 +0300 [thread overview]
Message-ID: <20161117135537.GV28558@mwanda> (raw)
In-Reply-To: <CAOmT4fR2Y5BPdpM8KrtdVqTpg2ewGOVyzzBC_wij55NSzbOdfQ@mail.gmail.com>
On Thu, Nov 17, 2016 at 02:31:06PM +0100, bojan prtvar wrote:
> Hi,
>
> On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
>
> > - pr_debug("PCM data: addr 0x%08ulx len %d\n",
> > + pr_debug("PCM data: addr 0x%08lx len %d\n",
> > (u32)runtime->dma_addr, runtime->dma_bytes);
>
> While there, why not using %pad as suggested by
> Documentation/printk-formats.txt?
Oh crap. I never even compiled this stuff... I'm really sorry it's
been a while since I screwed up like this. Sorry about this.
That sounds like a good idea but I don't have a cross compiler set up
so I'm going to leave it alone for now.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: bojan prtvar <prtvar.b@gmail.com>
Cc: alsa-devel@alsa-project.org,
Manuel Lauss <mano@roarinelk.homelinux.net>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf
Date: Thu, 17 Nov 2016 13:55:38 +0000 [thread overview]
Message-ID: <20161117135537.GV28558@mwanda> (raw)
In-Reply-To: <CAOmT4fR2Y5BPdpM8KrtdVqTpg2ewGOVyzzBC_wij55NSzbOdfQ@mail.gmail.com>
On Thu, Nov 17, 2016 at 02:31:06PM +0100, bojan prtvar wrote:
> Hi,
>
> On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
>
> > - pr_debug("PCM data: addr 0x%08ulx len %d\n",
> > + pr_debug("PCM data: addr 0x%08lx len %d\n",
> > (u32)runtime->dma_addr, runtime->dma_bytes);
>
> While there, why not using %pad as suggested by
> Documentation/printk-formats.txt?
Oh crap. I never even compiled this stuff... I'm really sorry it's
been a while since I screwed up like this. Sorry about this.
That sounds like a good idea but I don't have a cross compiler set up
so I'm going to leave it alone for now.
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-17 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 11:00 [patch] ASoC: sh: dma-sh7760: fix a debug printf Dan Carpenter
2016-11-17 11:00 ` Dan Carpenter
2016-11-17 13:31 ` bojan prtvar
2016-11-17 13:31 ` bojan prtvar
2016-11-17 13:55 ` Dan Carpenter [this message]
2016-11-17 13:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117135537.GV28558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mano@roarinelk.homelinux.net \
--cc=prtvar.b@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.