From: Tony Lindgren <tony@atomide.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] ARM: dts: omap5: replace gpio-key,wakeup with wakeup-source property
Date: Thu, 17 Nov 2016 07:27:18 -0800 [thread overview]
Message-ID: <20161117152717.GS4082@atomide.com> (raw)
In-Reply-To: <1479138250-17780-1-git-send-email-sudeep.holla@arm.com>
* Sudeep Holla <sudeep.holla@arm.com> [161114 07:44]:
> Though the keyboard driver for GPIO buttons(gpio-keys) will continue to
> check for/support the legacy "gpio-key,wakeup" boolean property to
> enable gpio buttons as wakeup source, "wakeup-source" is the new
> standard binding.
>
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property in order to avoid any further copy-paste
> duplication.
>
> Cc: "Benoît Cousson" <bcousson@baylibre.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi,
>
> Inspite of getting rid of most of the legacy property almost a year ago,
> addition of new platforms have brought this back and over time it's
> now found again in few places. Just get rid of them *again*
Thanks for the annual check up :)
Acked-by: Tony Lindgren <tony@atomide.com>
Please let me know if you want me to pick this up instead.
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index 2fcdc516da45..a8c72611fbe3 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -41,7 +41,7 @@
> label = "BTN1";
> linux,code = <169>;
> gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; /* gpio3_83 */
> - gpio-key,wakeup;
> + wakeup-source;
> autorepeat;
> debounce_interval = <50>;
> };
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] ARM: dts: omap5: replace gpio-key,wakeup with wakeup-source property
Date: Thu, 17 Nov 2016 07:27:18 -0800 [thread overview]
Message-ID: <20161117152717.GS4082@atomide.com> (raw)
In-Reply-To: <1479138250-17780-1-git-send-email-sudeep.holla@arm.com>
* Sudeep Holla <sudeep.holla@arm.com> [161114 07:44]:
> Though the keyboard driver for GPIO buttons(gpio-keys) will continue to
> check for/support the legacy "gpio-key,wakeup" boolean property to
> enable gpio buttons as wakeup source, "wakeup-source" is the new
> standard binding.
>
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property in order to avoid any further copy-paste
> duplication.
>
> Cc: "Beno?t Cousson" <bcousson@baylibre.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi,
>
> Inspite of getting rid of most of the legacy property almost a year ago,
> addition of new platforms have brought this back and over time it's
> now found again in few places. Just get rid of them *again*
Thanks for the annual check up :)
Acked-by: Tony Lindgren <tony@atomide.com>
Please let me know if you want me to pick this up instead.
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index 2fcdc516da45..a8c72611fbe3 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -41,7 +41,7 @@
> label = "BTN1";
> linux,code = <169>;
> gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; /* gpio3_83 */
> - gpio-key,wakeup;
> + wakeup-source;
> autorepeat;
> debounce_interval = <50>;
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-11-17 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 15:44 [PATCH -next] ARM: dts: omap5: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2016-11-14 15:44 ` [PATCH -next] ARM: dts: omap5: replace gpio-key,wakeup " Sudeep Holla
2016-11-17 15:27 ` Tony Lindgren [this message]
2016-11-17 15:27 ` Tony Lindgren
2016-11-17 15:32 ` Sudeep Holla
2016-11-17 15:32 ` Sudeep Holla
2016-11-17 15:47 ` Tony Lindgren
2016-11-17 15:47 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117152717.GS4082@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.