All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Feng Tang <feng.tang@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Feng Tang <feng.79.tang@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	Rik van Riel <riel@redhat.com>,
	"Srivatsa S. Bhat" <srivatsa@mit.edu>,
	Peter Zijlstra <peterz@infradead.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul McKenney <paulmck@linux.vnet.ibm.com>,
	Paul Turner <pjt@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.k>
Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")]
Date: Thu, 17 Nov 2016 19:14:56 +0200	[thread overview]
Message-ID: <20161117171456.GZ31595@intel.com> (raw)
In-Reply-To: <CA+55aFyOSHrP0--+dNB0qcoCumTP4KUd6g=2Jt3WUw_W6o+aRg@mail.gmail.com>

On Tue, Nov 08, 2016 at 10:08:37PM -0800, Linus Torvalds wrote:
> On Tue, Nov 8, 2016 at 7:54 PM, Feng Tang <feng.tang@intel.com> wrote:
> > On Wed, Nov 02, 2016 at 04:47:37AM +0800, Ville Syrjälä wrote:
> >>
> >> I left the thing running for the weekend and it failed 26 out of 16057
> >> times with the 25ms timeout. Looks like it takes ~5 minutes to resume
> >> when it fails, but eventually it does come back.
> >
> > Just came back from a travel. Yes, the 5 minutes delay may be due to the
> > expiration of the HPET timer, counting from 0 to 0xffffffff for a 13M
> > frequencey HPET takes about 300 seconds. After resume, it seems nobody
> > arms it so my old patch forces to arm one event.
> 
> Ville, what happens if you disable HPET? Can you force the TSC with
> "clocksource=tsc" or "tsc=reliable". Does resume work reliably then?
> 
> Or is this one of the CPU's where tsc just doesn't work?

tsc=reliable allows use of the tsc it seems. Doesn't seem to help
with resuming though.

-- 
Ville Syrjälä
Intel OTC

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Feng Tang <feng.tang@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Feng Tang <feng.79.tang@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	Rik van Riel <riel@redhat.com>,
	"Srivatsa S. Bhat" <srivatsa@mit.edu>,
	Peter Zijlstra <peterz@infradead.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul McKenney <paulmck@linux.vnet.ibm.com>,
	Paul Turner <pjt@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	"Brown, Len" <len.brown@intel.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")]
Date: Thu, 17 Nov 2016 19:14:56 +0200	[thread overview]
Message-ID: <20161117171456.GZ31595@intel.com> (raw)
Message-ID: <20161117171456.8P4IMYg7byUgYFL64-pINFJFXdSTbP42JgCi4qIQBJ0@z> (raw)
In-Reply-To: <CA+55aFyOSHrP0--+dNB0qcoCumTP4KUd6g=2Jt3WUw_W6o+aRg@mail.gmail.com>

On Tue, Nov 08, 2016 at 10:08:37PM -0800, Linus Torvalds wrote:
> On Tue, Nov 8, 2016 at 7:54 PM, Feng Tang <feng.tang@intel.com> wrote:
> > On Wed, Nov 02, 2016 at 04:47:37AM +0800, Ville Syrjälä wrote:
> >>
> >> I left the thing running for the weekend and it failed 26 out of 16057
> >> times with the 25ms timeout. Looks like it takes ~5 minutes to resume
> >> when it fails, but eventually it does come back.
> >
> > Just came back from a travel. Yes, the 5 minutes delay may be due to the
> > expiration of the HPET timer, counting from 0 to 0xffffffff for a 13M
> > frequencey HPET takes about 300 seconds. After resume, it seems nobody
> > arms it so my old patch forces to arm one event.
> 
> Ville, what happens if you disable HPET? Can you force the TSC with
> "clocksource=tsc" or "tsc=reliable". Does resume work reliably then?
> 
> Or is this one of the CPU's where tsc just doesn't work?

tsc=reliable allows use of the tsc it seems. Doesn't seem to help
with resuming though.

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2016-11-17 17:15 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 10:19 S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Ville Syrjälä
2016-05-11 12:11 ` Sebastian Andrzej Siewior
2016-05-11 12:21   ` Ville Syrjälä
2016-05-11 12:24     ` Sebastian Andrzej Siewior
2016-05-11 12:41       ` Ville Syrjälä
2016-05-11 12:44     ` Steven Rostedt
2016-05-11 13:34       ` Ville Syrjälä
2016-05-16 19:39         ` Ville Syrjälä
2016-05-17 23:14           ` Rafael J. Wysocki
2016-05-18  7:24             ` Ville Syrjälä
2016-05-26 18:32               ` Ville Syrjälä
2016-05-30 20:43                 ` Rafael J. Wysocki
2016-05-31  7:26                   ` Ville Syrjälä
2016-05-31  7:26                     ` Ville Syrjälä
2016-07-13 14:54                     ` Ville Syrjälä
2016-07-13 14:54                       ` Ville Syrjälä
2016-07-14  8:29                       ` Feng Tang
2016-07-14  8:29                         ` Feng Tang
2016-08-09 17:20                         ` Ville Syrjälä
2016-08-09 17:20                           ` Ville Syrjälä
2016-10-27 17:28                           ` Ville Syrjälä
2016-10-27 17:28                             ` Ville Syrjälä
2016-10-27 18:48                             ` Thomas Gleixner
2016-10-27 18:48                               ` Thomas Gleixner
2016-10-27 19:20                               ` Ville Syrjälä
2016-10-27 19:20                                 ` Ville Syrjälä
2016-10-27 19:25                                 ` Thomas Gleixner
2016-10-27 19:25                                   ` Thomas Gleixner
2016-10-27 20:37                                   ` Ville Syrjälä
2016-10-27 20:37                                     ` Ville Syrjälä
2016-10-27 20:41                                     ` Thomas Gleixner
2016-10-27 20:41                                       ` Thomas Gleixner
2016-10-28 15:56                                       ` Ville Syrjälä
2016-10-28 15:56                                         ` Ville Syrjälä
2016-10-28 18:58                                         ` Thomas Gleixner
2016-10-28 18:58                                           ` Thomas Gleixner
2016-11-01 20:47                                           ` Ville Syrjälä
2016-11-01 20:47                                             ` Ville Syrjälä
2016-11-07 11:49                                             ` Ville Syrjälä
2016-11-07 11:49                                               ` Ville Syrjälä
2016-11-07 13:07                                               ` Thomas Gleixner
2016-11-07 13:07                                                 ` Thomas Gleixner
2016-11-07 16:45                                                 ` Ville Syrjälä
2016-11-07 16:45                                                   ` Ville Syrjälä
2016-11-09  3:54                                             ` Feng Tang
2016-11-09  3:54                                               ` Feng Tang
2016-11-09  6:08                                               ` Linus Torvalds
2016-11-09  6:08                                                 ` Linus Torvalds
2016-11-17 17:14                                                 ` Ville Syrjälä [this message]
2016-11-17 17:14                                                   ` Ville Syrjälä
2016-05-11 13:36     ` Rafael J. Wysocki
2016-05-11 15:25       ` Jim Bos
2016-05-11 16:19         ` Rafael J. Wysocki
2016-05-11 16:21           ` Sebastian Andrzej Siewior
2016-05-11 16:24             ` Rafael J. Wysocki
2016-05-11 12:44 ` Arjan van de Ven
2016-05-11 15:26 ` Arjan van de Ven
2016-05-11 17:09   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161117171456.GZ31595@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=feng.79.tang@gmail.com \
    --cc=feng.tang@intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.k \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    --cc=riel@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=srivatsa@mit.edu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.