From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Nayna <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted
Date: Thu, 17 Nov 2016 09:36:41 -0800 [thread overview]
Message-ID: <20161117173641.uppc5vetyfuab7ts@intel.com> (raw)
In-Reply-To: <582D891D.9000801-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
On Thu, Nov 17, 2016 at 04:10:29PM +0530, Nayna wrote:
> On 11/15/2016 05:14 AM, Jarkko Sakkinen wrote:
> > - if (chip->flags & (TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_VIRTUAL))
> > - return 0;
> > + if (test_bit(TPM_CHIP_FLAG_TPM2, &chip->flags) ||
> > + test_bit(TPM_CHIP_FLAG_VIRTUAL, &chip->flags))
> > + return;
>
> guess should be "return 0;"
Ouch. Good catch. Thank you.
/Jarkko
------------------------------------------------------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna <nayna@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
Christophe Ricard <christophe.ricard@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: drop chip->is_open and chip->duration_adjusted
Date: Thu, 17 Nov 2016 09:36:41 -0800 [thread overview]
Message-ID: <20161117173641.uppc5vetyfuab7ts@intel.com> (raw)
In-Reply-To: <582D891D.9000801@linux.vnet.ibm.com>
On Thu, Nov 17, 2016 at 04:10:29PM +0530, Nayna wrote:
> On 11/15/2016 05:14 AM, Jarkko Sakkinen wrote:
> > - if (chip->flags & (TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_VIRTUAL))
> > - return 0;
> > + if (test_bit(TPM_CHIP_FLAG_TPM2, &chip->flags) ||
> > + test_bit(TPM_CHIP_FLAG_VIRTUAL, &chip->flags))
> > + return;
>
> guess should be "return 0;"
Ouch. Good catch. Thank you.
/Jarkko
next prev parent reply other threads:[~2016-11-17 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 23:44 [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jarkko Sakkinen
2016-11-14 23:44 ` Jarkko Sakkinen
2016-11-15 4:30 ` Jason Gunthorpe
[not found] ` <20161115043001.GA22482-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-15 5:11 ` Jarkko Sakkinen
2016-11-15 5:11 ` Jarkko Sakkinen
2016-11-16 5:28 ` Jason Gunthorpe
2016-11-16 22:54 ` Jarkko Sakkinen
[not found] ` <20161114234500.24839-1-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-11-17 10:40 ` Nayna
2016-11-17 10:40 ` [tpmdd-devel] " Nayna
[not found] ` <582D891D.9000801-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-17 17:36 ` Jarkko Sakkinen [this message]
2016-11-17 17:36 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117173641.uppc5vetyfuab7ts@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.