From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>, linux-block@vger.kernel.org
Subject: Re: [PATCHSET] Add support for simplified async direct-io
Date: Thu, 17 Nov 2016 13:04:48 -0800 [thread overview]
Message-ID: <20161117210448.GA25566@infradead.org> (raw)
In-Reply-To: <721c8908-ea89-a2f4-0bfd-7243a9aa4c03@kernel.dk>
On Thu, Nov 17, 2016 at 01:30:12PM -0700, Jens Axboe wrote:
> The last patch seems to have some issues:
>
> + bool is_sync = is_sync = is_sync_kiocb(iocb);
>
> and it's reverting part of the dio->is_sync that was part of my union
> waiter/iocb change. So I'll leave that out for now, for those reasons.
dio->is_sync isn't needed once the completion handlers are split.
That beeing said I wonder how the above statement even compiled,
there should just be a single assignment obviously.
Did I mention that I don't like the split anyway? :)
next prev parent reply other threads:[~2016-11-17 21:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 17:28 [PATCHSET] Add support for simplified async direct-io Jens Axboe
2016-11-14 17:28 ` [PATCH 1/2] block: support any sized IO for simplified bdev direct-io Jens Axboe
2016-11-14 17:28 ` [PATCH 2/2] block: add support for async simple direct-io for bdevs Jens Axboe
2016-11-14 17:37 ` [PATCHSET] Add support for simplified async direct-io Christoph Hellwig
2016-11-14 17:47 ` Jens Axboe
2016-11-14 18:00 ` Christoph Hellwig
2016-11-14 18:02 ` Jens Axboe
2016-11-14 18:05 ` Christoph Hellwig
2016-11-14 18:08 ` Jens Axboe
2016-11-14 18:11 ` Christoph Hellwig
2016-11-14 18:17 ` Jens Axboe
2016-11-15 13:58 ` Christoph Hellwig
2016-11-16 16:09 ` Jens Axboe
2016-11-16 16:31 ` Christoph Hellwig
2016-11-16 16:57 ` Jens Axboe
2016-11-16 17:16 ` Christoph Hellwig
2016-11-16 20:02 ` Jens Axboe
2016-11-16 20:36 ` Jens Axboe
2016-11-16 20:51 ` Jens Axboe
2016-11-17 3:44 ` Jens Axboe
2016-11-17 4:43 ` Jens Axboe
2016-11-17 12:50 ` Christoph Hellwig
2016-11-17 13:25 ` Jens Axboe
2016-11-17 15:03 ` Jens Axboe
2016-11-17 15:16 ` Christoph Hellwig
2016-11-17 20:17 ` Christoph Hellwig
2016-11-17 20:30 ` Jens Axboe
2016-11-17 21:04 ` Christoph Hellwig [this message]
2016-11-17 21:06 ` Jens Axboe
2016-11-17 12:46 ` Christoph Hellwig
2016-11-17 13:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117210448.GA25566@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.