From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCHSET] Add support for simplified async direct-io
Date: Wed, 16 Nov 2016 21:43:57 -0700 [thread overview]
Message-ID: <c2e20890-16ce-a3bd-c696-c53ae14a583a@kernel.dk> (raw)
In-Reply-To: <c46c5e60-a5eb-2862-2b1b-f994fd0d3fe3@kernel.dk>
On 11/16/2016 01:02 PM, Jens Axboe wrote:
> On 11/16/2016 10:16 AM, Christoph Hellwig wrote:
>> I've pushed out a new version of my code that avoids atomic ops
>> for the single bio case:
>>
>> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/new-dio
>>
>> I think we should take your extension of the existing
>> __blkdev_direct_IO_simple to kmalloc up to BIO_MAX_PAGES and then use
>> the above implementation for AIO and large synchronous I/O.
>>
>> I think I can also kill of blkdev_dio_pool by simply using bio_kmalloc
>> as we're only doing the allocation at the beginning of the call,
>> but I'd like to agree on an approach before spending too much time on
>> it.
>>
>
> I'm fine with this approach, but I would still REALLY like to see
> blkdev_bio_end_io() split in two, once for sync and once for async. That
> would be a lot cleaner, imho.
OK, I'm getting reasonably happy with it now:
http://git.kernel.dk/cgit/linux-block/log/?h=for-4.10/hch-dio
Sharing the FUA setting to avoid the manual flush between the two, and
removing the remnants of SYNC support from __blkdev_direct_IO().
I'll fire off some overnight testing now and leave it for the day.
--
Jens Axboe
next prev parent reply other threads:[~2016-11-17 4:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 17:28 [PATCHSET] Add support for simplified async direct-io Jens Axboe
2016-11-14 17:28 ` [PATCH 1/2] block: support any sized IO for simplified bdev direct-io Jens Axboe
2016-11-14 17:28 ` [PATCH 2/2] block: add support for async simple direct-io for bdevs Jens Axboe
2016-11-14 17:37 ` [PATCHSET] Add support for simplified async direct-io Christoph Hellwig
2016-11-14 17:47 ` Jens Axboe
2016-11-14 18:00 ` Christoph Hellwig
2016-11-14 18:02 ` Jens Axboe
2016-11-14 18:05 ` Christoph Hellwig
2016-11-14 18:08 ` Jens Axboe
2016-11-14 18:11 ` Christoph Hellwig
2016-11-14 18:17 ` Jens Axboe
2016-11-15 13:58 ` Christoph Hellwig
2016-11-16 16:09 ` Jens Axboe
2016-11-16 16:31 ` Christoph Hellwig
2016-11-16 16:57 ` Jens Axboe
2016-11-16 17:16 ` Christoph Hellwig
2016-11-16 20:02 ` Jens Axboe
2016-11-16 20:36 ` Jens Axboe
2016-11-16 20:51 ` Jens Axboe
2016-11-17 3:44 ` Jens Axboe
2016-11-17 4:43 ` Jens Axboe [this message]
2016-11-17 12:50 ` Christoph Hellwig
2016-11-17 13:25 ` Jens Axboe
2016-11-17 15:03 ` Jens Axboe
2016-11-17 15:16 ` Christoph Hellwig
2016-11-17 20:17 ` Christoph Hellwig
2016-11-17 20:30 ` Jens Axboe
2016-11-17 21:04 ` Christoph Hellwig
2016-11-17 21:06 ` Jens Axboe
2016-11-17 12:46 ` Christoph Hellwig
2016-11-17 13:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2e20890-16ce-a3bd-c696-c53ae14a583a@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.