From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Milo Kim <woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Robert Nelson
<robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts
Date: Fri, 18 Nov 2016 14:53:53 +0000 [thread overview]
Message-ID: <20161118145353.GE2301@dell.home> (raw)
In-Reply-To: <20161028123702.21849-6-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, 28 Oct 2016, Milo Kim wrote:
> TPS65217 supports three interrupt sources. This patch enables assigning
> each IRQ number in the charger and power button node. Then corresponding
> IRQ will be requested by each driver.
>
> Signed-off-by: Milo Kim <woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> include/dt-bindings/mfd/tps65217.h | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 include/dt-bindings/mfd/tps65217.h
>
> diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h
> new file mode 100644
> index 0000000..cafb9e6
> --- /dev/null
> +++ b/include/dt-bindings/mfd/tps65217.h
> @@ -0,0 +1,26 @@
> +/*
> + * This header provides macros for TI TPS65217 DT bindings.
> + *
> + * Copyright (C) 2016 Texas Instruments
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef __DT_BINDINGS_TPS65217_H__
> +#define __DT_BINDINGS_TPS65217_H__
> +
> +#define TPS65217_IRQ_USB 0
> +#define TPS65217_IRQ_AC 1
> +#define TPS65217_IRQ_PB 2
What are "AC" and "PB". Seeing as these are meant to be "human
readable", let's make them more human friendly.
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts
Date: Fri, 18 Nov 2016 14:53:53 +0000 [thread overview]
Message-ID: <20161118145353.GE2301@dell.home> (raw)
In-Reply-To: <20161028123702.21849-6-woogyom.kim@gmail.com>
On Fri, 28 Oct 2016, Milo Kim wrote:
> TPS65217 supports three interrupt sources. This patch enables assigning
> each IRQ number in the charger and power button node. Then corresponding
> IRQ will be requested by each driver.
>
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
> include/dt-bindings/mfd/tps65217.h | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 include/dt-bindings/mfd/tps65217.h
>
> diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h
> new file mode 100644
> index 0000000..cafb9e6
> --- /dev/null
> +++ b/include/dt-bindings/mfd/tps65217.h
> @@ -0,0 +1,26 @@
> +/*
> + * This header provides macros for TI TPS65217 DT bindings.
> + *
> + * Copyright (C) 2016 Texas Instruments
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef __DT_BINDINGS_TPS65217_H__
> +#define __DT_BINDINGS_TPS65217_H__
> +
> +#define TPS65217_IRQ_USB 0
> +#define TPS65217_IRQ_AC 1
> +#define TPS65217_IRQ_PB 2
What are "AC" and "PB". Seeing as these are meant to be "human
readable", let's make them more human friendly.
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Milo Kim <woogyom.kim@gmail.com>
Cc: bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts
Date: Fri, 18 Nov 2016 14:53:53 +0000 [thread overview]
Message-ID: <20161118145353.GE2301@dell.home> (raw)
In-Reply-To: <20161028123702.21849-6-woogyom.kim@gmail.com>
On Fri, 28 Oct 2016, Milo Kim wrote:
> TPS65217 supports three interrupt sources. This patch enables assigning
> each IRQ number in the charger and power button node. Then corresponding
> IRQ will be requested by each driver.
>
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
> include/dt-bindings/mfd/tps65217.h | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 include/dt-bindings/mfd/tps65217.h
>
> diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h
> new file mode 100644
> index 0000000..cafb9e6
> --- /dev/null
> +++ b/include/dt-bindings/mfd/tps65217.h
> @@ -0,0 +1,26 @@
> +/*
> + * This header provides macros for TI TPS65217 DT bindings.
> + *
> + * Copyright (C) 2016 Texas Instruments
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef __DT_BINDINGS_TPS65217_H__
> +#define __DT_BINDINGS_TPS65217_H__
> +
> +#define TPS65217_IRQ_USB 0
> +#define TPS65217_IRQ_AC 1
> +#define TPS65217_IRQ_PB 2
What are "AC" and "PB". Seeing as these are meant to be "human
readable", let's make them more human friendly.
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-11-18 14:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 12:36 [PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` [PATCH v2 1/8] ARM: dts: tps65217: Specify the interrupt controller Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` [PATCH v2 2/8] ARM: dts: tps65217: Add the charger device Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` [PATCH v2 3/8] ARM: dts: tps65217: Add the power button device Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` [PATCH v2 4/8] ARM: dts: am335x: Support the PMIC interrupt Milo Kim
2016-10-28 12:36 ` Milo Kim
2016-10-28 12:36 ` [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts Milo Kim
2016-10-28 12:36 ` Milo Kim
[not found] ` <20161028123702.21849-6-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-18 14:53 ` Lee Jones [this message]
2016-11-18 14:53 ` Lee Jones
2016-11-18 14:53 ` Lee Jones
2016-11-18 15:10 ` Tony Lindgren
2016-11-18 15:10 ` Tony Lindgren
2016-11-21 13:05 ` Milo Kim
2016-11-21 13:05 ` Milo Kim
2016-10-28 12:37 ` [PATCH v2 6/8] ARM: dts: am335x: Add the charger interrupt Milo Kim
2016-10-28 12:37 ` Milo Kim
2016-10-28 12:37 ` [PATCH v2 7/8] ARM: dts: am335x: Add the power button interrupt Milo Kim
2016-10-28 12:37 ` Milo Kim
2016-10-28 12:37 ` [PATCH v2 8/8] mfd: tps65217: Fix mismatched interrupt number Milo Kim
2016-10-28 12:37 ` Milo Kim
[not found] ` <20161028123702.21849-1-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-09 21:38 ` [PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT Tony Lindgren
2016-11-09 21:38 ` Tony Lindgren
2016-11-09 21:38 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118145353.GE2301@dell.home \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.