From: Quentin Lambert <lambert.quentin@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] coresight: perf: Add a missing call to etm_free_aux
Date: Sat, 19 Nov 2016 17:41:24 +0000 [thread overview]
Message-ID: <20161119174124.20136-1-lambert.quentin@gmail.com> (raw)
Most error branches following the call to alloc_event_data contain a call to
etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -215,7 +215,7 @@ static void *etm_setup_aux(int event_cpu
*/
sink = coresight_get_enabled_sink(true);
if (!sink)
- return NULL;
+ goto err;
INIT_WORK(&event_data->work, free_event_data);
WARNING: multiple messages have this Message-ID (diff)
From: lambert.quentin@gmail.com (Quentin Lambert)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] coresight: perf: Add a missing call to etm_free_aux
Date: Sat, 19 Nov 2016 18:41:24 +0100 [thread overview]
Message-ID: <20161119174124.20136-1-lambert.quentin@gmail.com> (raw)
Most error branches following the call to alloc_event_data contain a call to
etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -215,7 +215,7 @@ static void *etm_setup_aux(int event_cpu
*/
sink = coresight_get_enabled_sink(true);
if (!sink)
- return NULL;
+ goto err;
INIT_WORK(&event_data->work, free_event_data);
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Lambert <lambert.quentin@gmail.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: Quentin Lambert <lambert.quentin@gmail.com>
Subject: [PATCH] coresight: perf: Add a missing call to etm_free_aux
Date: Sat, 19 Nov 2016 18:41:24 +0100 [thread overview]
Message-ID: <20161119174124.20136-1-lambert.quentin@gmail.com> (raw)
Most error branches following the call to alloc_event_data contain a call to
etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -215,7 +215,7 @@ static void *etm_setup_aux(int event_cpu
*/
sink = coresight_get_enabled_sink(true);
if (!sink)
- return NULL;
+ goto err;
INIT_WORK(&event_data->work, free_event_data);
next reply other threads:[~2016-11-19 17:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 17:41 Quentin Lambert [this message]
2016-11-19 17:41 ` [PATCH] coresight: perf: Add a missing call to etm_free_aux Quentin Lambert
2016-11-19 17:41 ` Quentin Lambert
2016-11-19 18:22 ` Quentin Lambert
2016-11-19 18:22 ` Quentin Lambert
2016-11-19 18:22 ` Quentin Lambert
2016-11-19 18:42 ` Quentin Lambert
2016-11-19 18:42 ` Quentin Lambert
2016-11-19 18:42 ` Quentin Lambert
2016-11-21 17:17 ` Mathieu Poirier
2016-11-21 17:17 ` Mathieu Poirier
2016-11-21 17:17 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119174124.20136-1-lambert.quentin@gmail.com \
--to=lambert.quentin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.