All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>,
	babu.moger@oracle.com, mingo@redhat.com,
	akpm@linux-foundation.org, keescook@chromium.org,
	dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org,
	sam@ravnborg.org, linux-kernel@vger.kernel.org,
	sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Ajust lockdep static allocations for sparc
Date: Mon, 21 Nov 2016 07:17:00 +0000	[thread overview]
Message-ID: <20161121071659.GA28747@gmail.com> (raw)
In-Reply-To: <20161119115301.GT3568@worktop.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Nov 18, 2016 at 02:34:07PM -0500, David Miller wrote:
> > From: Babu Moger <babu.moger@oracle.com>
> > Date: Tue, 27 Sep 2016 12:33:26 -0700
> > 
> > > These patches limit the static allocations for lockdep data structures
> > > used for debugging locking correctness. For sparc, all the kernel's code,
> > > data, and bss, must have locked translations in the TLB so that we don't
> > > get TLB misses on kernel code and data. Current sparc chips have 8 TLB
> > > entries available that may be locked down, and with a 4mb page size,
> > > this gives a maximum of 32MB. With PROVE_LOCKING we could go over this
> > > limit and cause system boot-up problems. These patches limit the static
> > > allocations so that everything fits in current required size limit.
> > > 
> > > patch 1 : Adds new config parameter CONFIG_PROVE_LOCKING_SMALL
> > > Patch 2 : Adjusts the sizes based on the new config parameter
> > > 
> > > v2-> v3:
> > >    Some more comments from Sam Ravnborg and Peter Zijlstra.
> > >    Defined PROVE_LOCKING_SMALL as invisible and moved the selection to
> > >    arch/sparc/Kconfig. 
> > > 
> > > v1-> v2:
> > >    As suggested by Peter Zijlstra, keeping the default as is.
> > >    Introduced new config variable CONFIG_PROVE_LOCKING_SMALL
> > >    to handle sparc specific case.
> > > 
> > > v0:
> > >    Initial revision.
> > 
> > Series applied, thanks.
> 
> Heh, I was only waiting for an ACK from you, but this works too :-)

Works for me too - as usual davem is fantastic in terms of efficient patch flow :)

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>,
	babu.moger@oracle.com, mingo@redhat.com,
	akpm@linux-foundation.org, keescook@chromium.org,
	dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org,
	sam@ravnborg.org, linux-kernel@vger.kernel.org,
	sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Ajust lockdep static allocations for sparc
Date: Mon, 21 Nov 2016 08:17:00 +0100	[thread overview]
Message-ID: <20161121071659.GA28747@gmail.com> (raw)
In-Reply-To: <20161119115301.GT3568@worktop.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Nov 18, 2016 at 02:34:07PM -0500, David Miller wrote:
> > From: Babu Moger <babu.moger@oracle.com>
> > Date: Tue, 27 Sep 2016 12:33:26 -0700
> > 
> > > These patches limit the static allocations for lockdep data structures
> > > used for debugging locking correctness. For sparc, all the kernel's code,
> > > data, and bss, must have locked translations in the TLB so that we don't
> > > get TLB misses on kernel code and data. Current sparc chips have 8 TLB
> > > entries available that may be locked down, and with a 4mb page size,
> > > this gives a maximum of 32MB. With PROVE_LOCKING we could go over this
> > > limit and cause system boot-up problems. These patches limit the static
> > > allocations so that everything fits in current required size limit.
> > > 
> > > patch 1 : Adds new config parameter CONFIG_PROVE_LOCKING_SMALL
> > > Patch 2 : Adjusts the sizes based on the new config parameter
> > > 
> > > v2-> v3:
> > >    Some more comments from Sam Ravnborg and Peter Zijlstra.
> > >    Defined PROVE_LOCKING_SMALL as invisible and moved the selection to
> > >    arch/sparc/Kconfig. 
> > > 
> > > v1-> v2:
> > >    As suggested by Peter Zijlstra, keeping the default as is.
> > >    Introduced new config variable CONFIG_PROVE_LOCKING_SMALL
> > >    to handle sparc specific case.
> > > 
> > > v0:
> > >    Initial revision.
> > 
> > Series applied, thanks.
> 
> Heh, I was only waiting for an ACK from you, but this works too :-)

Works for me too - as usual davem is fantastic in terms of efficient patch flow :)

Thanks,

	Ingo

  reply	other threads:[~2016-11-21  7:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 19:33 [PATCH v3 0/2] Ajust lockdep static allocations for sparc Babu Moger
2016-09-27 19:33 ` Babu Moger
2016-09-27 19:33 ` [PATCH v3 1/2] config: Adding the new config parameter CONFIG_PROVE_LOCKING_SMALL " Babu Moger
2016-09-27 19:33   ` Babu Moger
2016-09-28  8:39   ` Peter Zijlstra
2016-09-28  8:39     ` Peter Zijlstra
2016-09-29 13:53     ` Babu Moger
2016-09-29 13:53       ` Babu Moger
2016-09-30  5:19       ` David Miller
2016-09-30  5:19         ` David Miller
2016-10-05 22:56         ` Babu Moger
2016-10-05 22:56           ` Babu Moger
2016-10-06  4:27           ` Sam Ravnborg
2016-10-06  4:27             ` Sam Ravnborg
2016-09-28 20:51   ` Sam Ravnborg
2016-09-28 20:51     ` Sam Ravnborg
2016-09-27 19:33 ` [PATCH v3 2/2] lockdep: Limit static allocations if PROVE_LOCKING_SMALL is defined Babu Moger
2016-09-27 19:33   ` Babu Moger
2016-09-28 20:51   ` Sam Ravnborg
2016-09-28 20:51     ` Sam Ravnborg
2016-09-29 13:55   ` Babu Moger
2016-09-29 13:55     ` Babu Moger
2016-11-18 19:34 ` [PATCH v3 0/2] Ajust lockdep static allocations for sparc David Miller
2016-11-18 19:34   ` David Miller
2016-11-19 11:53   ` Peter Zijlstra
2016-11-19 11:53     ` Peter Zijlstra
2016-11-21  7:17     ` Ingo Molnar [this message]
2016-11-21  7:17       ` Ingo Molnar
2016-11-29 11:14 ` Geert Uytterhoeven
2016-11-29 11:14   ` Geert Uytterhoeven
2016-11-29 11:41   ` Peter Zijlstra
2016-11-29 11:41     ` Peter Zijlstra
2016-11-29 11:52     ` Geert Uytterhoeven
2016-11-29 11:52       ` Geert Uytterhoeven
2016-11-29 12:29       ` Peter Zijlstra
2016-11-29 12:29         ` Peter Zijlstra
2016-11-29 12:35         ` Peter Zijlstra
2016-11-29 12:35           ` Peter Zijlstra
2016-11-29 13:26         ` Geert Uytterhoeven
2016-11-29 13:26           ` Geert Uytterhoeven
2016-11-29 13:31           ` Peter Zijlstra
2016-11-29 13:31             ` Peter Zijlstra
2016-11-29 13:39             ` Geert Uytterhoeven
2016-11-29 13:39               ` Geert Uytterhoeven
2016-11-29 13:50               ` Peter Zijlstra
2016-11-29 13:50                 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121071659.GA28747@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=babu.moger@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.