From: Jerome Glisse <j.glisse-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: harry.wentland-5C7GfCeVMHo@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 00/76] DAL Patches Nov 21, 2016
Date: Tue, 22 Nov 2016 19:06:54 -0500 [thread overview]
Message-ID: <20161123000638.GA3312@gmail.com> (raw)
In-Reply-To: <20161121230136.5208-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
I hate to shime in but from review point of view what i don't undersntand is why
isn't there a single reviewable patchset for DAL ?
What i mean by that is a patchset in which you collapse all fixes and cleanup so
that there is an easy way to review thing. Yes this means loosing history and
major work to just spawn a new patchset but quite frankly in this state this thing
is just unreviewable. The only sane way today is to look at git tree with the whole
thing applied and avoid looking at individual patch. That not a sane way to do
review in my mind.
That just my opinion other might disagree but i thought i would say that outloud.
Cheers,
Jérôme
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-11-23 0:06 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 23:00 [PATCH 00/76] DAL Patches Nov 21, 2016 Harry Wentland
[not found] ` <20161121230136.5208-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2016-11-21 23:00 ` [PATCH 01/76] drm/amd/dal: bring all of dc under a single log category table Harry Wentland
2016-11-21 23:00 ` [PATCH 02/76] drm/amd/dal: clean up asic cap Harry Wentland
2016-11-21 23:00 ` [PATCH 03/76] drm/amd/dal: Remove unused code in dce112 hwss Harry Wentland
2016-11-21 23:00 ` [PATCH 04/76] drm/amd/dal: Consolidate link encoder from each dce version Harry Wentland
2016-11-21 23:00 ` [PATCH 05/76] drm/amd/dal: Remove wireless_data_source Harry Wentland
2016-11-21 23:00 ` [PATCH 06/76] drm/amd/dal: Move gpio_service out of adapter_service Harry Wentland
2016-11-21 23:00 ` [PATCH 07/76] drm/amd/dal: Fix warning about comparing different types Harry Wentland
2016-11-21 23:00 ` [PATCH 08/76] drm/amd/dal: fix dc creation Harry Wentland
2016-11-21 23:00 ` [PATCH 09/76] drm/amd/dal: add chroma support to program_size_and_rotation Harry Wentland
2016-11-21 23:00 ` [PATCH 10/76] drm/amd/dal: add meta address to video address struct Harry Wentland
2016-11-21 23:00 ` [PATCH 11/76] drm/amd/dal: Refactor i2c_hw_engine Harry Wentland
2016-11-21 23:00 ` [PATCH 12/76] drm/amd/dal: modify DCE HW sequence to be re-usable for next gen HW Harry Wentland
2016-11-21 23:00 ` [PATCH 13/76] drm/amd/dal: DCC support Harry Wentland
2016-11-21 23:00 ` [PATCH 14/76] drm/amd/dal: Expose some HWS functions so we can re-use them Harry Wentland
2016-11-21 23:00 ` [PATCH 15/76] drm/amd/dal: Modify regsiter access to use macro Harry Wentland
2016-11-21 23:00 ` [PATCH 16/76] drm/amd/dal: refactor bios scratch register access Harry Wentland
2016-11-21 23:00 ` [PATCH 17/76] drm/amd/dal: Remove adapter service from display clock Harry Wentland
2016-11-21 23:00 ` [PATCH 18/76] drm/amd/dal: Use future proof reg access for HPD and DDC Harry Wentland
2016-11-21 23:00 ` [PATCH 19/76] drm/amd/dal: Remove adapter service dependency from dc_link Harry Wentland
2016-11-21 23:00 ` [PATCH 20/76] drm/amd/dal: rotation and mirror support Harry Wentland
2016-11-21 23:00 ` [PATCH 21/76] drm/amd/dal: remove unnessary AS dependency Harry Wentland
2016-11-21 23:00 ` [PATCH 22/76] drm/amd/dal: remove AS dependency from i2c_aux Harry Wentland
2016-11-21 23:00 ` [PATCH 23/76] drm/amd/dal: remove dal_adapter_service_get_integrated_info Harry Wentland
2016-11-21 23:00 ` [PATCH 24/76] drm/amd/dal: instantiate i2caux outside of AS Harry Wentland
2016-11-21 23:00 ` [PATCH 25/76] drm/amd/dal: fix DDC pad mode detection logic Harry Wentland
2016-11-21 23:00 ` [PATCH 26/76] drm/amd/dal: Fix MST crash by skipping branch connector Harry Wentland
2016-11-21 23:00 ` [PATCH 27/76] drm/amd/dal: Lower max link cap by reportedLinkCap Harry Wentland
2016-11-21 23:00 ` [PATCH 28/76] drm/amd/dal: Allow timing with req_bw equal to max_bw Harry Wentland
2016-11-21 23:00 ` [PATCH 29/76] drm/amd/dal: Perform link training in dp_retrain_link Harry Wentland
2016-11-21 23:00 ` [PATCH 30/76] drm/amd/dal: Poll AUX_SW_DONE to 0 before AUX_SW_GO Harry Wentland
2016-11-21 23:00 ` [PATCH 31/76] drm/amd/dal: Fallback LT without retry in verify_link_cap Harry Wentland
2016-11-21 23:00 ` [PATCH 32/76] drm/amd/dal: Remove adapter service dependency in power_down Harry Wentland
2016-11-21 23:00 ` [PATCH 33/76] drm/amd/dal: remove supported_stream_engines Harry Wentland
2016-11-21 23:00 ` [PATCH 34/76] drm/amd/dal: Rotation and mirror support Harry Wentland
2016-11-21 23:00 ` [PATCH 35/76] drm/amd/dal: Pass in shift and mask for stream encoder Harry Wentland
2016-11-21 23:00 ` [PATCH 36/76] drm/amd/dal: Fixed wrong return value check condition Harry Wentland
2016-11-21 23:00 ` [PATCH 37/76] drm/amd/dal: Make set_overscan_blank_color optional Harry Wentland
2016-11-21 23:00 ` [PATCH 38/76] drm/amd/dal: Hard-coded LB_MEMORY_SIZE Harry Wentland
2016-11-21 23:00 ` [PATCH 39/76] drm/amd/dal: Rotation and mirror support Harry Wentland
2016-11-21 23:01 ` [PATCH 40/76] drm/amd/dal: remove unnessary adapter service functions Harry Wentland
2016-11-21 23:01 ` [PATCH 41/76] drm/amd/dal: remove dal_override_parameters Harry Wentland
2016-11-21 23:01 ` [PATCH 42/76] drm/amd/dal: remove unnessary adapter service functions Harry Wentland
2016-11-21 23:01 ` [PATCH 43/76] " Harry Wentland
2016-11-21 23:01 ` [PATCH 44/76] drm/amd/dal: Fix null pointer missed in earlier refactor Harry Wentland
2016-11-21 23:01 ` [PATCH 45/76] drm/amd/dal: fix typo disalbe_dfs_bypass Harry Wentland
2016-11-21 23:01 ` [PATCH 46/76] drm/amd/dal: Remove unused function from dc Harry Wentland
2016-11-21 23:01 ` [PATCH 47/76] drm/amd/dal: remove dal_adapter_service_should_optimize Harry Wentland
2016-11-21 23:01 ` [PATCH 48/76] drm/amd/dal: remove dal_adapter_service_get_feature_value Harry Wentland
2016-11-21 23:01 ` [PATCH 49/76] drm/amd/dal: remove adapter_service from Harry Wentland
2016-11-21 23:01 ` [PATCH 50/76] drm/amd/dal: remove adapter_service dependency Harry Wentland
2016-11-21 23:01 ` [PATCH 51/76] drm/amd/dal: remove SKIP_PSR_WAIT_FOR_PLL_LOCK_BIT Harry Wentland
2016-11-21 23:01 ` [PATCH 52/76] drm/amd/dal: remove adapter_service and asic_capability Harry Wentland
2016-11-21 23:01 ` [PATCH 53/76] drm/amd/dal: Update stream_encoder programming sequence Harry Wentland
2016-11-21 23:01 ` [PATCH 54/76] drm/amd/dal: Disable bit depth reduction in set link test pattern Harry Wentland
2016-11-21 23:01 ` [PATCH 55/76] drm/amd/dal: Handle AUX error during RECIEVE state of transaction Harry Wentland
2016-11-21 23:01 ` [PATCH 56/76] drm/amd/dal: Remove unnecessary increment in scaler ratio calculation Harry Wentland
2016-11-21 23:01 ` [PATCH 57/76] drm/amd/dal: Add YCBCR420 to stream encoder Harry Wentland
2016-11-21 23:01 ` [PATCH 58/76] drm/amd/dal: Add surface log to dc Harry Wentland
2016-11-21 23:01 ` [PATCH 59/76] drm/amd/dal: add stoney bounding box to bw_calcs Harry Wentland
2016-11-21 23:01 ` [PATCH 60/76] drm/amd/dal: Implement DCHUB interface Harry Wentland
2016-11-21 23:01 ` [PATCH 61/76] drm/amd/dal: fix initial bw_calc parameters Harry Wentland
2016-11-21 23:01 ` [PATCH 62/76] drm/amd/dal: Don't read I2C_DATA register when in write mode Harry Wentland
2016-11-21 23:01 ` [PATCH 63/76] drm/amd/dal: disable break_to_debugger for bandwidth failures in diags Harry Wentland
2016-11-21 23:01 ` [PATCH 64/76] drm/amd/dal: PSR second monitor blackout fix Harry Wentland
2016-11-21 23:01 ` [PATCH 65/76] drm/amd/dal: Fixe linux compile error Harry Wentland
2016-11-21 23:01 ` [PATCH 66/76] drm/amd/dal: consolidate DCE hw_sequencer Harry Wentland
2016-11-21 23:01 ` [PATCH 67/76] " Harry Wentland
2016-11-21 23:01 ` [PATCH 68/76] drm/amd/dal: debug options Harry Wentland
2016-11-21 23:01 ` [PATCH 69/76] drm/amd/dal: remove dc_clock_gating in gpu Harry Wentland
2016-11-21 23:01 ` [PATCH 70/76] drm/amd/dal: dce_crtc_switch_to_clk_src Harry Wentland
2016-11-21 23:01 ` [PATCH 71/76] drm/amd/dal: include dm_services.h in reg_helper.h Harry Wentland
2016-11-21 23:01 ` [PATCH 72/76] drm/amd/dal: consolidate mem_input Harry Wentland
2016-11-21 23:01 ` [PATCH 73/76] drm/amd/dal: Add reg check before access Harry Wentland
2016-11-21 23:01 ` [PATCH 74/76] drm/amd/dal: Fix typo in mem_input Harry Wentland
2016-11-21 23:01 ` [PATCH 75/76] drm/amd/dal: Make bunch of scaler structs static Harry Wentland
2016-11-21 23:01 ` [PATCH 76/76] drm/amd/dal: Expose Polaris validate functions Harry Wentland
2016-11-23 0:06 ` Jerome Glisse [this message]
[not found] ` <20161123000638.GA3312-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-23 2:31 ` [PATCH 00/76] DAL Patches Nov 21, 2016 Harry Wentland
2016-11-23 18:56 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123000638.GA3312@gmail.com \
--to=j.glisse-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.