From: vinod.koul@intel.com (Vinod Koul)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v3 2/2] DW DMAC: add multi-block property to device tree
Date: Wed, 23 Nov 2016 09:45:13 +0530 [thread overview]
Message-ID: <20161123041513.GF2698@localhost> (raw)
In-Reply-To: <1479497593.22212.45.camel@linux.intel.com>
On Fri, Nov 18, 2016@09:33:13PM +0200, Andy Shevchenko wrote:
> > @@ -1569,7 +1569,7 @@ int dw_dma_probe(struct dw_dma_chip *chip)
> > ? (dwc_params >> DWC_PARAMS_MBLK_EN &
> > 0x1) == 0;
> > ? } else {
> > ? dwc->block_size = pdata->block_size;
> > - dwc->nollp = pdata->is_nollp;
> > + dwc->nollp = pdata->multi_block[i];
>
> You missed the point. You assign positive value to negative variable.
> It's a bug. Have you tested this? How?
>
> In case of positive property you have to update DTS. By the way, I'm
> pretty sure that spare13xx boards has auto configuration enabled, though
> it has to be checked with vendor (I assume you may have fast response
> from them).
Yeah why are we not using auto configuration here would be the first
question..
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH v3 2/2] DW DMAC: add multi-block property to device tree
Date: Wed, 23 Nov 2016 09:45:13 +0530 [thread overview]
Message-ID: <20161123041513.GF2698@localhost> (raw)
In-Reply-To: <1479497593.22212.45.camel@linux.intel.com>
On Fri, Nov 18, 2016 at 09:33:13PM +0200, Andy Shevchenko wrote:
> > @@ -1569,7 +1569,7 @@ int dw_dma_probe(struct dw_dma_chip *chip)
> > (dwc_params >> DWC_PARAMS_MBLK_EN &
> > 0x1) == 0;
> > } else {
> > dwc->block_size = pdata->block_size;
> > - dwc->nollp = pdata->is_nollp;
> > + dwc->nollp = pdata->multi_block[i];
>
> You missed the point. You assign positive value to negative variable.
> It's a bug. Have you tested this? How?
>
> In case of positive property you have to update DTS. By the way, I'm
> pretty sure that spare13xx boards has auto configuration enabled, though
> it has to be checked with vendor (I assume you may have fast response
> from them).
Yeah why are we not using auto configuration here would be the first
question..
--
~Vinod
next prev parent reply other threads:[~2016-11-23 4:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 19:12 [PATCH v3 0/2] DW DMAC: update device tree Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:12 ` [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:27 ` Andy Shevchenko
2016-11-18 19:27 ` Andy Shevchenko
2016-11-18 19:27 ` Andy Shevchenko
2016-11-18 19:12 ` [PATCH v3 2/2] DW DMAC: add multi-block property to device tree Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:33 ` Andy Shevchenko
2016-11-18 19:33 ` Andy Shevchenko
2016-11-18 19:33 ` Andy Shevchenko
2016-11-23 4:15 ` Vinod Koul [this message]
2016-11-23 4:15 ` Vinod Koul
2016-11-21 13:53 ` Arnd Bergmann
2016-11-21 13:53 ` Arnd Bergmann
2016-11-21 13:53 ` Arnd Bergmann
2016-11-18 19:26 ` [PATCH v3 0/2] DW DMAC: update " Andy Shevchenko
2016-11-18 19:26 ` Andy Shevchenko
2016-11-18 19:26 ` Andy Shevchenko
2016-11-21 10:02 ` Alexey Brodkin
2016-11-21 10:02 ` Alexey Brodkin
2016-11-21 10:37 ` Andy Shevchenko
2016-11-21 10:37 ` Andy Shevchenko
2016-11-21 10:37 ` Andy Shevchenko
2016-11-23 4:06 ` Vinod Koul
2016-11-23 4:06 ` Vinod Koul
2016-11-23 4:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123041513.GF2698@localhost \
--to=vinod.koul@intel.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.